[INFO] fetching crate srp 0.6.0... [INFO] checking srp-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate srp 0.6.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate srp 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate srp 0.6.0 [INFO] finished tweaking crates.io crate srp 0.6.0 [INFO] tweaked toml for crates.io crate srp 0.6.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hex-literal v0.3.4 (latest: v0.4.1) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe35683edda0b9674f5cbbe65e9b85f05c8d923540100b8be09d1764ec2b5b11 [INFO] running `Command { std: "docker" "start" "-a" "fe35683edda0b9674f5cbbe65e9b85f05c8d923540100b8be09d1764ec2b5b11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe35683edda0b9674f5cbbe65e9b85f05c8d923540100b8be09d1764ec2b5b11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe35683edda0b9674f5cbbe65e9b85f05c8d923540100b8be09d1764ec2b5b11", kill_on_drop: false }` [INFO] [stdout] fe35683edda0b9674f5cbbe65e9b85f05c8d923540100b8be09d1764ec2b5b11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b62fe34437dc42c3af894bda4a151e63f5322d00590646200fad9608ac74dce5 [INFO] running `Command { std: "docker" "start" "-a" "b62fe34437dc42c3af894bda4a151e63f5322d00590646200fad9608ac74dce5", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling hex-literal v0.3.4 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking srp v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:135:33 [INFO] [stdout] | [INFO] [stdout] 132 | let mut x = D::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | BigUint::from_bytes_be(&x.finalize()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 200 | let identity_hash = Self::compute_identity_hash(username, password); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let m1 = compute_m1::( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let m2 = compute_m2::(&a_pub.to_bytes_be(), &m1, &key.to_bytes_be()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | [INFO] [stdout] 213 | Ok(SrpClientVerifier { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | m1, [INFO] [stdout] 215 | | m2, [INFO] [stdout] 216 | | key: key.to_bytes_be(), [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 147 | let m1 = compute_m1::( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let m2 = compute_m2::(&a_pub.to_bytes_be(), &m1, &key.to_bytes_be()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | [INFO] [stdout] 155 | Ok(SrpServerVerifier { [INFO] [stdout] | ____________^ [INFO] [stdout] 156 | | m1, [INFO] [stdout] 157 | | m2, [INFO] [stdout] 158 | | key: key.to_bytes_be(), [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:11:29 [INFO] [stdout] | [INFO] [stdout] 8 | let mut u = D::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | BigUint::from_bytes_be(&u.finalize()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:25:28 [INFO] [stdout] | [INFO] [stdout] 22 | let mut d = D::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | BigUint::from_bytes_be(d.finalize().as_slice()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:135:33 [INFO] [stdout] | [INFO] [stdout] 132 | let mut x = D::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | BigUint::from_bytes_be(&x.finalize()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 200 | let identity_hash = Self::compute_identity_hash(username, password); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let m1 = compute_m1::( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let m2 = compute_m2::(&a_pub.to_bytes_be(), &m1, &key.to_bytes_be()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 212 | [INFO] [stdout] 213 | Ok(SrpClientVerifier { [INFO] [stdout] | ____________^ [INFO] [stdout] 214 | | m1, [INFO] [stdout] 215 | | m2, [INFO] [stdout] 216 | | key: key.to_bytes_be(), [INFO] [stdout] 217 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 147 | let m1 = compute_m1::( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let m2 = compute_m2::(&a_pub.to_bytes_be(), &m1, &key.to_bytes_be()); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | [INFO] [stdout] 155 | Ok(SrpServerVerifier { [INFO] [stdout] | ____________^ [INFO] [stdout] 156 | | m1, [INFO] [stdout] 157 | | m2, [INFO] [stdout] 158 | | key: key.to_bytes_be(), [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:11:29 [INFO] [stdout] | [INFO] [stdout] 8 | let mut u = D::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | BigUint::from_bytes_be(&u.finalize()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:25:28 [INFO] [stdout] | [INFO] [stdout] 22 | let mut d = D::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | BigUint::from_bytes_be(d.finalize().as_slice()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `srp` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `srp` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "b62fe34437dc42c3af894bda4a151e63f5322d00590646200fad9608ac74dce5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b62fe34437dc42c3af894bda4a151e63f5322d00590646200fad9608ac74dce5", kill_on_drop: false }` [INFO] [stdout] b62fe34437dc42c3af894bda4a151e63f5322d00590646200fad9608ac74dce5