[INFO] fetching crate srfs 0.1.2... [INFO] checking srfs-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate srfs 0.1.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate srfs 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate srfs 0.1.2 [INFO] finished tweaking crates.io crate srfs 0.1.2 [INFO] tweaked toml for crates.io crate srfs 0.1.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding bitflags v2.4.2 (latest: v2.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b00551a40ced1ce846bf3dba9399060436fc916ed9a838f6d6006c6d15859553 [INFO] running `Command { std: "docker" "start" "-a" "b00551a40ced1ce846bf3dba9399060436fc916ed9a838f6d6006c6d15859553", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b00551a40ced1ce846bf3dba9399060436fc916ed9a838f6d6006c6d15859553", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b00551a40ced1ce846bf3dba9399060436fc916ed9a838f6d6006c6d15859553", kill_on_drop: false }` [INFO] [stdout] b00551a40ced1ce846bf3dba9399060436fc916ed9a838f6d6006c6d15859553 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e12b981e26837800c8539c9a35226add0d8a23dc68ce96de2a8cb1d28ee341a7 [INFO] running `Command { std: "docker" "start" "-a" "e12b981e26837800c8539c9a35226add0d8a23dc68ce96de2a8cb1d28ee341a7", kill_on_drop: false }` [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking srfs-core v0.1.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking srfs v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn open_device(block_device: Box) -> Result { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let fs = srfs_core::SyncFileSystem::open_fs(block_device).map_err(error::to_ioerror)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | [INFO] [stdout] 225 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 226 | | inner: Rc::new(RefCell::new(FileSystemInner { [INFO] [stdout] 227 | | fs_core: fs, [INFO] [stdout] 228 | | cache: lru::LruCache::new(Self::CACHE_SIZE), [INFO] [stdout] 229 | | })), [INFO] [stdout] 230 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 243 | Ok(crate::File::from(file_id, self.inner.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:252:12 [INFO] [stdout] | [INFO] [stdout] 252 | Ok(crate::File::from(file_id, self.inner.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/readdir.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn read_dir(path: &str, fs: Rc>) -> Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | path: path.to_owned(), [INFO] [stdout] 61 | | parent, [INFO] [stdout] 62 | | cur_pos: 0, [INFO] [stdout] 63 | | num_entries, [INFO] [stdout] 64 | | fs, [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:225:12 [INFO] [stdout] | [INFO] [stdout] 222 | pub fn open_device(block_device: Box) -> Result { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | let fs = srfs_core::SyncFileSystem::open_fs(block_device).map_err(error::to_ioerror)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | [INFO] [stdout] 225 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 226 | | inner: Rc::new(RefCell::new(FileSystemInner { [INFO] [stdout] 227 | | fs_core: fs, [INFO] [stdout] 228 | | cache: lru::LruCache::new(Self::CACHE_SIZE), [INFO] [stdout] 229 | | })), [INFO] [stdout] 230 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:243:12 [INFO] [stdout] | [INFO] [stdout] 243 | Ok(crate::File::from(file_id, self.inner.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem.rs:252:12 [INFO] [stdout] | [INFO] [stdout] 252 | Ok(crate::File::from(file_id, self.inner.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/readdir.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 47 | pub(crate) fn read_dir(path: &str, fs: Rc>) -> Result { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | path: path.to_owned(), [INFO] [stdout] 61 | | parent, [INFO] [stdout] 62 | | cur_pos: 0, [INFO] [stdout] 63 | | num_entries, [INFO] [stdout] 64 | | fs, [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `srfs` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `srfs` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "e12b981e26837800c8539c9a35226add0d8a23dc68ce96de2a8cb1d28ee341a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e12b981e26837800c8539c9a35226add0d8a23dc68ce96de2a8cb1d28ee341a7", kill_on_drop: false }` [INFO] [stdout] e12b981e26837800c8539c9a35226add0d8a23dc68ce96de2a8cb1d28ee341a7