[INFO] fetching crate sqlite2dir 0.2.0... [INFO] checking sqlite2dir-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sqlite2dir 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate sqlite2dir 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sqlite2dir 0.2.0 [INFO] finished tweaking crates.io crate sqlite2dir 0.2.0 [INFO] tweaked toml for crates.io crate sqlite2dir 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate sqlite2dir 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04225d9a1166ebbc778a9c353b2092c1505dc356bfead949c40bdc5b92c6a894 [INFO] running `Command { std: "docker" "start" "-a" "04225d9a1166ebbc778a9c353b2092c1505dc356bfead949c40bdc5b92c6a894", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04225d9a1166ebbc778a9c353b2092c1505dc356bfead949c40bdc5b92c6a894", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04225d9a1166ebbc778a9c353b2092c1505dc356bfead949c40bdc5b92c6a894", kill_on_drop: false }` [INFO] [stdout] 04225d9a1166ebbc778a9c353b2092c1505dc356bfead949c40bdc5b92c6a894 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a8cb6d0fa060c9bab2f434dcabeb5f136e607b9cd3a5f7d0def116d35d9c988 [INFO] running `Command { std: "docker" "start" "-a" "5a8cb6d0fa060c9bab2f434dcabeb5f136e607b9cd3a5f7d0def116d35d9c988", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Compiling pkg-config v0.3.15 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling proc-macro2 v1.0.3 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling serde v1.0.99 [INFO] [stderr] Compiling unicode-segmentation v1.3.0 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking once_cell v1.1.0 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling libsqlite3-sys v0.16.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Compiling libgit2-sys v0.9.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking rusqlite v0.20.0 [INFO] [stderr] Checking url v2.1.0 [INFO] [stderr] Checking backtrace v0.3.37 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling structopt-derive v0.3.1 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking structopt v0.3.1 [INFO] [stderr] Checking git2 v0.10.0 [INFO] [stderr] Checking sqlite2dir v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 41 | fn open_table(&mut self, name: impl AsRef) -> io::Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(FileTable { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | file: self.open_file(format!("data/table/{}.json", name.as_ref()))?, [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(Repo { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | repo: git2::Repository::open_bare(path)?, [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn create(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(Repo { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | repo: git2::Repository::init_bare(path)?, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 41 | fn open_table(&mut self, name: impl AsRef) -> io::Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Ok(FileTable { [INFO] [stdout] | ____________^ [INFO] [stdout] 43 | | file: self.open_file(format!("data/table/{}.json", name.as_ref()))?, [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(Repo { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | repo: git2::Repository::open_bare(path)?, [INFO] [stdout] 58 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn create(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Ok(Repo { [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | repo: git2::Repository::init_bare(path)?, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn open(path: impl AsRef) -> rusqlite::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let conn = Connection::open_with_flags(path, OpenFlags::SQLITE_OPEN_READ_ONLY)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(Db { conn }) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sqlite.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn open(path: impl AsRef) -> rusqlite::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let conn = Connection::open_with_flags(path, OpenFlags::SQLITE_OPEN_READ_ONLY)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(Db { conn }) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqlite2dir` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sqlite2dir` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5a8cb6d0fa060c9bab2f434dcabeb5f136e607b9cd3a5f7d0def116d35d9c988", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a8cb6d0fa060c9bab2f434dcabeb5f136e607b9cd3a5f7d0def116d35d9c988", kill_on_drop: false }` [INFO] [stdout] 5a8cb6d0fa060c9bab2f434dcabeb5f136e607b9cd3a5f7d0def116d35d9c988