[INFO] fetching crate sqlite-rs 0.3.7... [INFO] checking sqlite-rs-0.3.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sqlite-rs 0.3.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate sqlite-rs 0.3.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate sqlite-rs 0.3.7 [INFO] finished tweaking crates.io crate sqlite-rs 0.3.7 [INFO] tweaked toml for crates.io crate sqlite-rs 0.3.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate sqlite-rs 0.3.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 549d96f4b004943f153e4c46b738c77c89fb447db103a5e96cfeb8b5022ba1fc [INFO] running `Command { std: "docker" "start" "-a" "549d96f4b004943f153e4c46b738c77c89fb447db103a5e96cfeb8b5022ba1fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "549d96f4b004943f153e4c46b738c77c89fb447db103a5e96cfeb8b5022ba1fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "549d96f4b004943f153e4c46b738c77c89fb447db103a5e96cfeb8b5022ba1fc", kill_on_drop: false }` [INFO] [stdout] 549d96f4b004943f153e4c46b738c77c89fb447db103a5e96cfeb8b5022ba1fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf59b0c0a566bbde1f67f277adaf3086a11a26458bc3d71069e58d2faa94ced9 [INFO] running `Command { std: "docker" "start" "-a" "cf59b0c0a566bbde1f67f277adaf3086a11a26458bc3d71069e58d2faa94ced9", kill_on_drop: false }` [INFO] [stderr] Compiling sqlite-rs v0.3.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/header/magic_header_string.rs:15:30 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct MagicHeaderString([u8; 16]); [INFO] [stdout] | ----------------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/header/reserved_for_expansion.rs:7:33 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct ReservedForExpansion([u8; 20]); [INFO] [stdout] | -------------------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `uri` and `mode` are never read [INFO] [stdout] --> src/io/mod.rs:103:3 [INFO] [stdout] | [INFO] [stdout] 102 | pub struct SqliteUri { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 103 | uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 104 | path: PathBuf, [INFO] [stdout] 105 | mode: SqliteUriFileMode, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SqliteUri` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `btree` is never read [INFO] [stdout] --> src/runtime/mod.rs:17:3 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct SqliteRuntime { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | btree: SqliteBtree, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SqliteRuntime` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SqliteMaster` is never constructed [INFO] [stdout] --> src/runtime/internal_tables/sqlite_master/mod.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | pub(super) struct SqliteMaster(()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SqliteMaster` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SqliteSequence` is never constructed [INFO] [stdout] --> src/runtime/internal_tables/sqlite_sequence/mod.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | pub(super) struct SqliteSequence(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SqliteSequence` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn open(conn_str: impl AsRef) -> SqliteResult { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let io = SqliteIo::open(conn_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let pager = SqlitePager::connect(io)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let runtime = SqliteRuntime::start(pager)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Self { runtime }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/mod.rs:13:27 [INFO] [stdout] | [INFO] [stdout] 13 | LOGGER.get_or_init(|| maybe_loglevel_str.parse().unwrap_or_default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/mod.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn start(mut pager: SqlitePager) -> SqliteResult { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 30 | | pager, [INFO] [stdout] 31 | | header, [INFO] [stdout] 32 | | btree, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqlite-rs` (lib test) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/header/magic_header_string.rs:15:30 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct MagicHeaderString([u8; 16]); [INFO] [stdout] | ----------------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/header/reserved_for_expansion.rs:7:33 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct ReservedForExpansion([u8; 20]); [INFO] [stdout] | -------------------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `uri` and `mode` are never read [INFO] [stdout] --> src/io/mod.rs:103:3 [INFO] [stdout] | [INFO] [stdout] 102 | pub struct SqliteUri { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 103 | uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 104 | path: PathBuf, [INFO] [stdout] 105 | mode: SqliteUriFileMode, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SqliteUri` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `btree` is never read [INFO] [stdout] --> src/runtime/mod.rs:17:3 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct SqliteRuntime { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | btree: SqliteBtree, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SqliteRuntime` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SqliteMaster` is never constructed [INFO] [stdout] --> src/runtime/internal_tables/sqlite_master/mod.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | pub(super) struct SqliteMaster(()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SqliteMaster` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SqliteSequence` is never constructed [INFO] [stdout] --> src/runtime/internal_tables/sqlite_sequence/mod.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | pub(super) struct SqliteSequence(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SqliteSequence` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn open(conn_str: impl AsRef) -> SqliteResult { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let io = SqliteIo::open(conn_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let pager = SqlitePager::connect(io)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let runtime = SqliteRuntime::start(pager)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Self { runtime }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log/mod.rs:13:27 [INFO] [stdout] | [INFO] [stdout] 13 | LOGGER.get_or_init(|| maybe_loglevel_str.parse().unwrap_or_default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/mod.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn start(mut pager: SqlitePager) -> SqliteResult { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 30 | | pager, [INFO] [stdout] 31 | | header, [INFO] [stdout] 32 | | btree, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqlite-rs` (lib) due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cf59b0c0a566bbde1f67f277adaf3086a11a26458bc3d71069e58d2faa94ced9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf59b0c0a566bbde1f67f277adaf3086a11a26458bc3d71069e58d2faa94ced9", kill_on_drop: false }` [INFO] [stdout] cf59b0c0a566bbde1f67f277adaf3086a11a26458bc3d71069e58d2faa94ced9