[INFO] fetching crate sql_from_models-proc-macro 0.1.2... [INFO] checking sql_from_models-proc-macro-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sql_from_models-proc-macro 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate sql_from_models-proc-macro 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sql_from_models-proc-macro 0.1.2 [INFO] finished tweaking crates.io crate sql_from_models-proc-macro 0.1.2 [INFO] tweaked toml for crates.io crate sql_from_models-proc-macro 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36b0a707f9e76cfbf680d6288de390cc2fe16812748b803af5c0e57a605ccc5a [INFO] running `Command { std: "docker" "start" "-a" "36b0a707f9e76cfbf680d6288de390cc2fe16812748b803af5c0e57a605ccc5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36b0a707f9e76cfbf680d6288de390cc2fe16812748b803af5c0e57a605ccc5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36b0a707f9e76cfbf680d6288de390cc2fe16812748b803af5c0e57a605ccc5a", kill_on_drop: false }` [INFO] [stdout] 36b0a707f9e76cfbf680d6288de390cc2fe16812748b803af5c0e57a605ccc5a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63ad5ce1dbdd3f195b8f74c18f2068bfe2a17d76ed9de0a487bacb9e3d8da293 [INFO] running `Command { std: "docker" "start" "-a" "63ad5ce1dbdd3f195b8f74c18f2068bfe2a17d76ed9de0a487bacb9e3d8da293", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking sql_from_models-parser v0.2.1 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking sql_from_models-proc-macro v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `collections::HashMap` [INFO] [stdout] --> src/prelude.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub use collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/prelude.rs:2:35 [INFO] [stdout] | [INFO] [stdout] 2 | pub use proc_macro::{TokenStream, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `collections::HashMap` [INFO] [stdout] --> src/prelude.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub use collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/prelude.rs:2:35 [INFO] [stdout] | [INFO] [stdout] 2 | pub use proc_macro::{TokenStream, *}; [INFO] [stdout] | ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/model/constraint.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct NamedConstraint { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 10 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NamedConstraint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/model/constraint.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct NamedConstraint { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 10 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NamedConstraint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:88:45 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|constr| NamedConstraint { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | name: self.constr_name(&constr.method(), &col_name, &constr.column_names()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:88:45 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|constr| NamedConstraint { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | name: self.constr_name(&constr.method(), &col_name, &constr.column_names()), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:88:74 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|constr| NamedConstraint { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | name: self.constr_name(&constr.method(), &col_name, &constr.column_names()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:89:33 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|constr| NamedConstraint { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | name: self.constr_name(&constr.method(), &col_name, &constr.column_names()), [INFO] [stdout] 89 | field_name: col_name.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/column/mod.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 43 | let ty = field.ty.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let default = Self::get_default(field.attrs.clone())?; [INFO] [stdout] 45 | let name = field.ident.clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Ok(Self { ty, default, name }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:88:74 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|constr| NamedConstraint { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | name: self.constr_name(&constr.method(), &col_name, &constr.column_names()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/constraint.rs:180:12 [INFO] [stdout] | [INFO] [stdout] 149 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let _paren = parenthesized!(content in input); [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | [INFO] [stdout] 152 | let foreign_table = content.parse::()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | content.parse::()?; [INFO] [stdout] 154 | let mut on_delete = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let mut on_update = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let column = content.parse::()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | Ok(ForeignKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 181 | | foreign_table, [INFO] [stdout] 182 | | column, [INFO] [stdout] 183 | | on_delete, [INFO] [stdout] 184 | | on_update, [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:89:33 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|constr| NamedConstraint { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | name: self.constr_name(&constr.method(), &col_name, &constr.column_names()), [INFO] [stdout] 89 | field_name: col_name.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/column/mod.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 43 | let ty = field.ty.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let default = Self::get_default(field.attrs.clone())?; [INFO] [stdout] 45 | let name = field.ident.clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Ok(Self { ty, default, name }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/constraint.rs:180:12 [INFO] [stdout] | [INFO] [stdout] 149 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let _paren = parenthesized!(content in input); [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | [INFO] [stdout] 152 | let foreign_table = content.parse::()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | content.parse::()?; [INFO] [stdout] 154 | let mut on_delete = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let mut on_update = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let column = content.parse::()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | Ok(ForeignKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 181 | | foreign_table, [INFO] [stdout] 182 | | column, [INFO] [stdout] 183 | | on_delete, [INFO] [stdout] 184 | | on_update, [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/constraint.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 191 | let mut out = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Ok(Constraints(out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/constraint.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 191 | let mut out = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Ok(Constraints(out)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sql_from_models-proc-macro` (lib test) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sql_from_models-proc-macro` (lib) due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "63ad5ce1dbdd3f195b8f74c18f2068bfe2a17d76ed9de0a487bacb9e3d8da293", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63ad5ce1dbdd3f195b8f74c18f2068bfe2a17d76ed9de0a487bacb9e3d8da293", kill_on_drop: false }` [INFO] [stdout] 63ad5ce1dbdd3f195b8f74c18f2068bfe2a17d76ed9de0a487bacb9e3d8da293