[INFO] fetching crate sqids 0.4.1... [INFO] checking sqids-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sqids 0.4.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sqids 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sqids 0.4.1 [INFO] finished tweaking crates.io crate sqids 0.4.1 [INFO] tweaked toml for crates.io crate sqids 0.4.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f37a68517376a06654c5f7ed7f5dbd82aded1060fb40d2bb7dc41a8cbe3cbb9f [INFO] running `Command { std: "docker" "start" "-a" "f37a68517376a06654c5f7ed7f5dbd82aded1060fb40d2bb7dc41a8cbe3cbb9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f37a68517376a06654c5f7ed7f5dbd82aded1060fb40d2bb7dc41a8cbe3cbb9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f37a68517376a06654c5f7ed7f5dbd82aded1060fb40d2bb7dc41a8cbe3cbb9f", kill_on_drop: false }` [INFO] [stdout] f37a68517376a06654c5f7ed7f5dbd82aded1060fb40d2bb7dc41a8cbe3cbb9f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ab6eec98d9e2d9e717b037e6ecf18a30e9179b9a8c1eddefbeb53e0a83c34260 [INFO] running `Command { std: "docker" "start" "-a" "ab6eec98d9e2d9e717b037e6ecf18a30e9179b9a8c1eddefbeb53e0a83c34260", kill_on_drop: false }` [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling derive_builder_core v0.20.1 [INFO] [stderr] Compiling derive_builder_macro v0.20.1 [INFO] [stderr] Checking derive_builder v0.20.1 [INFO] [stderr] Checking sqids v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:6 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let unique_chars: HashSet = alphabet.iter().cloned().collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let filtered_blocklist: HashSet = self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(Sqids { [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | alphabet: Sqids::shuffle(&alphabet), [INFO] [stdout] 184 | | min_length: self.min_length.unwrap_or(0), [INFO] [stdout] 185 | | blocklist: filtered_blocklist, [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:194:3 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn new(options: Option) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let options = options.unwrap_or_default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | / Self::builder() [INFO] [stdout] 195 | | .min_length(options.min_length) [INFO] [stdout] 196 | | .alphabet(options.alphabet.chars().collect()) [INFO] [stdout] 197 | | .blocklist(options.blocklist) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqids` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:6 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let unique_chars: HashSet = alphabet.iter().cloned().collect(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let filtered_blocklist: HashSet = self [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(Sqids { [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | alphabet: Sqids::shuffle(&alphabet), [INFO] [stdout] 184 | | min_length: self.min_length.unwrap_or(0), [INFO] [stdout] 185 | | blocklist: filtered_blocklist, [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:194:3 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn new(options: Option) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let options = options.unwrap_or_default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | / Self::builder() [INFO] [stdout] 195 | | .min_length(options.min_length) [INFO] [stdout] 196 | | .alphabet(options.alphabet.chars().collect()) [INFO] [stdout] 197 | | .blocklist(options.blocklist) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sqids` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "ab6eec98d9e2d9e717b037e6ecf18a30e9179b9a8c1eddefbeb53e0a83c34260", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab6eec98d9e2d9e717b037e6ecf18a30e9179b9a8c1eddefbeb53e0a83c34260", kill_on_drop: false }` [INFO] [stdout] ab6eec98d9e2d9e717b037e6ecf18a30e9179b9a8c1eddefbeb53e0a83c34260