[INFO] fetching crate spx 0.5.0... [INFO] checking spx-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spx 0.5.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate spx 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spx 0.5.0 [INFO] finished tweaking crates.io crate spx 0.5.0 [INFO] tweaked toml for crates.io crate spx 0.5.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 38 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e11ebba6b51d2d92e0d2de0b44ee429749a4ae00211be3e66a5d206669bc3db [INFO] running `Command { std: "docker" "start" "-a" "3e11ebba6b51d2d92e0d2de0b44ee429749a4ae00211be3e66a5d206669bc3db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e11ebba6b51d2d92e0d2de0b44ee429749a4ae00211be3e66a5d206669bc3db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e11ebba6b51d2d92e0d2de0b44ee429749a4ae00211be3e66a5d206669bc3db", kill_on_drop: false }` [INFO] [stdout] 3e11ebba6b51d2d92e0d2de0b44ee429749a4ae00211be3e66a5d206669bc3db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f7a18a3b53fb0afb11a850b0b2392620f8b3e5e8431ecf95b5237499bae5914 [INFO] running `Command { std: "docker" "start" "-a" "6f7a18a3b53fb0afb11a850b0b2392620f8b3e5e8431ecf95b5237499bae5914", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking const-fnv1a-hash v1.1.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking spx v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | Poll::Ready(Ok(read)) [INFO] [stdout] | ^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 118 | Poll::Ready(Ok(pos)) [INFO] [stdout] | ^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn open(mut self, path: &(impl AsRef + ?Sized)) -> io::Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(SpxCipherReader::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | cipher, [INFO] [stdout] 60 | | SpxRawFileStream { [INFO] [stdout] 61 | | file, [INFO] [stdout] 62 | | stream: self.stream.take(file.size), [INFO] [stdout] 63 | | }, [INFO] [stdout] 64 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 74 | let res = self.open_raw(path).ok_or_else(|| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut stream = self.stream; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(SpxCipherReader::new( [INFO] [stdout] | ________________^ [INFO] [stdout] 88 | | cipher, [INFO] [stdout] 89 | | SpxRawFileStream { [INFO] [stdout] 90 | | file, [INFO] [stdout] 91 | | stream: stream.take(file.size), [INFO] [stdout] 92 | | }, [INFO] [stdout] 93 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | Poll::Ready(Ok(file_pos)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spx` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | Poll::Ready(Ok(read)) [INFO] [stdout] | ^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto.rs:118:21 [INFO] [stdout] | [INFO] [stdout] 118 | Poll::Ready(Ok(pos)) [INFO] [stdout] | ^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn open(mut self, path: &(impl AsRef + ?Sized)) -> io::Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(SpxCipherReader::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | cipher, [INFO] [stdout] 60 | | SpxRawFileStream { [INFO] [stdout] 61 | | file, [INFO] [stdout] 62 | | stream: self.stream.take(file.size), [INFO] [stdout] 63 | | }, [INFO] [stdout] 64 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:87:16 [INFO] [stdout] | [INFO] [stdout] 74 | let res = self.open_raw(path).ok_or_else(|| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let mut stream = self.stream; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(SpxCipherReader::new( [INFO] [stdout] | ________________^ [INFO] [stdout] 88 | | cipher, [INFO] [stdout] 89 | | SpxRawFileStream { [INFO] [stdout] 90 | | file, [INFO] [stdout] 91 | | stream: stream.take(file.size), [INFO] [stdout] 92 | | }, [INFO] [stdout] 93 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | Poll::Ready(Ok(file_pos)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spx` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "6f7a18a3b53fb0afb11a850b0b2392620f8b3e5e8431ecf95b5237499bae5914", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f7a18a3b53fb0afb11a850b0b2392620f8b3e5e8431ecf95b5237499bae5914", kill_on_drop: false }` [INFO] [stdout] 6f7a18a3b53fb0afb11a850b0b2392620f8b3e5e8431ecf95b5237499bae5914