[INFO] fetching crate spurs 0.9.2... [INFO] checking spurs-0.9.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spurs 0.9.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate spurs 0.9.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spurs 0.9.2 [INFO] finished tweaking crates.io crate spurs 0.9.2 [INFO] tweaked toml for crates.io crate spurs 0.9.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 64 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v0.7.0 (latest: v2.6.0) [INFO] [stderr] Adding blake2b_simd v0.5.11 (latest: v1.0.2) [INFO] [stderr] Adding console v0.7.7 (latest: v0.15.8) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding dirs v1.0.5 (latest: v5.0.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding libssh2-sys v0.2.23 (latest: v0.3.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding redox_users v0.3.5 (latest: v0.4.6) [INFO] [stderr] Adding rust-argon2 v0.8.3 (latest: v2.1.0) [INFO] [stderr] Adding ssh2 v0.3.3 (latest: v0.9.4) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 88e99626853ea9f54dfc73fb16c897d368a749f4d563ff3561fc30248fa08a4c [INFO] running `Command { std: "docker" "start" "-a" "88e99626853ea9f54dfc73fb16c897d368a749f4d563ff3561fc30248fa08a4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "88e99626853ea9f54dfc73fb16c897d368a749f4d563ff3561fc30248fa08a4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88e99626853ea9f54dfc73fb16c897d368a749f4d563ff3561fc30248fa08a4c", kill_on_drop: false }` [INFO] [stdout] 88e99626853ea9f54dfc73fb16c897d368a749f4d563ff3561fc30248fa08a4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8110c2b6878a8166f3fee09889e1b30e378d0df58c7e0773c55fdec1663f1f2a [INFO] running `Command { std: "docker" "start" "-a" "8110c2b6878a8166f3fee09889e1b30e378d0df58c7e0773c55fdec1663f1f2a", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking termios v0.3.3 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking console v0.7.7 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Checking ssh2 v0.3.3 [INFO] [stderr] Checking spurs v0.9.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 287 | remote: A, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | key: P, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | let tcp = TcpStream::connect(&remote)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | let mut sess = Session::new().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | Ok(SshShell { [INFO] [stdout] | ____________^ [INFO] [stdout] 325 | | tcp, [INFO] [stdout] 326 | | username: username.to_owned(), [INFO] [stdout] 327 | | key: key.as_ref().to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 331 | | dry_run_mode: false, [INFO] [stdout] 332 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:377:12 [INFO] [stdout] | [INFO] [stdout] 347 | let tcp = TcpStream::connect(&shell.remote)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | let mut sess = Session::new().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | Ok(SshShell { [INFO] [stdout] | ____________^ [INFO] [stdout] 378 | | tcp, [INFO] [stdout] 379 | | username: shell.username.clone(), [INFO] [stdout] 380 | | key: shell.key.clone(), [INFO] [stdout] ... | [INFO] [stdout] 384 | | dry_run_mode: false, [INFO] [stdout] 385 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:12 [INFO] [stdout] | [INFO] [stdout] 401 | let shell = Self::from_existing(self)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | let thread_handle = std::thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 415 | Ok(SshSpawnHandle { thread_handle }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:324:12 [INFO] [stdout] | [INFO] [stdout] 287 | remote: A, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 288 | key: P, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | let tcp = TcpStream::connect(&remote)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | let mut sess = Session::new().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | Ok(SshShell { [INFO] [stdout] | ____________^ [INFO] [stdout] 325 | | tcp, [INFO] [stdout] 326 | | username: username.to_owned(), [INFO] [stdout] 327 | | key: key.as_ref().to_owned(), [INFO] [stdout] ... | [INFO] [stdout] 331 | | dry_run_mode: false, [INFO] [stdout] 332 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:377:12 [INFO] [stdout] | [INFO] [stdout] 347 | let tcp = TcpStream::connect(&shell.remote)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | let mut sess = Session::new().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 377 | Ok(SshShell { [INFO] [stdout] | ____________^ [INFO] [stdout] 378 | | tcp, [INFO] [stdout] 379 | | username: shell.username.clone(), [INFO] [stdout] 380 | | key: shell.key.clone(), [INFO] [stdout] ... | [INFO] [stdout] 384 | | dry_run_mode: false, [INFO] [stdout] 385 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:12 [INFO] [stdout] | [INFO] [stdout] 401 | let shell = Self::from_existing(self)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | let thread_handle = std::thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 415 | Ok(SshSpawnHandle { thread_handle }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spurs` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spurs` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "8110c2b6878a8166f3fee09889e1b30e378d0df58c7e0773c55fdec1663f1f2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8110c2b6878a8166f3fee09889e1b30e378d0df58c7e0773c55fdec1663f1f2a", kill_on_drop: false }` [INFO] [stdout] 8110c2b6878a8166f3fee09889e1b30e378d0df58c7e0773c55fdec1663f1f2a