[INFO] fetching crate springtime-di 1.0.2... [INFO] checking springtime-di-1.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate springtime-di 1.0.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate springtime-di 1.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate springtime-di 1.0.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate springtime-di 1.0.2 [INFO] tweaked toml for crates.io crate springtime-di 1.0.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate springtime-di 1.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d452e5b42f897df732fe07e8e2ff9c4154211b5327b85a7853a3627f87b7ea9a [INFO] running `Command { std: "docker" "start" "-a" "d452e5b42f897df732fe07e8e2ff9c4154211b5327b85a7853a3627f87b7ea9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d452e5b42f897df732fe07e8e2ff9c4154211b5327b85a7853a3627f87b7ea9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d452e5b42f897df732fe07e8e2ff9c4154211b5327b85a7853a3627f87b7ea9a", kill_on_drop: false }` [INFO] [stdout] d452e5b42f897df732fe07e8e2ff9c4154211b5327b85a7853a3627f87b7ea9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90b7b3dba6fad44a9a1864b0b751c297f93c4328deeacbaccee112e07e913a2c [INFO] running `Command { std: "docker" "start" "-a" "90b7b3dba6fad44a9a1864b0b751c297f93c4328deeacbaccee112e07e913a2c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling either v1.11.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling springtime-di-derive v0.3.1 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling mockall_derive v0.12.1 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking springtime-di v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component_registry.rs:383:12 [INFO] [stdout] | [INFO] [stdout] 366 | let mut definition_map = NamedComponentDefinitionMap::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | let mut enabled_types = FxHashSet::default(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | Ok((definition_map, enabled_types)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factory.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 109 | definition_registry: ComponentDefinitionRegistryPtr, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | scope_factories: FxHashMap, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | scopes: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factory.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 109 | definition_registry: ComponentDefinitionRegistryPtr, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | scope_factories: FxHashMap, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | types_under_construction: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factory.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 177 | Ok(scope [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | .instance(definition) [INFO] [stdout] 179 | | .map(|instance| (instance, definition.cast))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/factory.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 230 | let instance = self.call_constructor(definition)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Ok((instance, definition.cast)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance_provider.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 308 | .and_then(|instances| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | / instances [INFO] [stdout] 310 | | .into_iter() [INFO] [stdout] 311 | | .map(move |(p, cast)| cast_instance(p, cast, type_id)) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance_provider.rs:367:5 [INFO] [stdout] | [INFO] [stdout] 362 | instance: ComponentInstanceAnyPtr, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | / cast(instance) [INFO] [stdout] 368 | | .map_err(|_| ComponentInstanceProviderError::IncompatibleComponent { [INFO] [stdout] 369 | | type_id, [INFO] [stdout] 370 | | type_name: type_name::().to_string(), [INFO] [stdout] 371 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instance_provider.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 372 | .and_then(|p| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 373 | / p.downcast::>() [INFO] [stdout] 374 | | .map(|p| (*p).clone()) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `springtime-di` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "90b7b3dba6fad44a9a1864b0b751c297f93c4328deeacbaccee112e07e913a2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90b7b3dba6fad44a9a1864b0b751c297f93c4328deeacbaccee112e07e913a2c", kill_on_drop: false }` [INFO] [stdout] 90b7b3dba6fad44a9a1864b0b751c297f93c4328deeacbaccee112e07e913a2c