[INFO] fetching crate spotify 0.8.2... [INFO] checking spotify-0.8.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spotify 0.8.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate spotify 0.8.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spotify 0.8.2 [INFO] finished tweaking crates.io crate spotify 0.8.2 [INFO] tweaked toml for crates.io crate spotify 0.8.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate spotify 0.8.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 510f2c63fc05c5fffea6e19775d0f48a727f52cc4d7d457626d8d6e0970e6ad0 [INFO] running `Command { std: "docker" "start" "-a" "510f2c63fc05c5fffea6e19775d0f48a727f52cc4d7d457626d8d6e0970e6ad0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "510f2c63fc05c5fffea6e19775d0f48a727f52cc4d7d457626d8d6e0970e6ad0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "510f2c63fc05c5fffea6e19775d0f48a727f52cc4d7d457626d8d6e0970e6ad0", kill_on_drop: false }` [INFO] [stdout] 510f2c63fc05c5fffea6e19775d0f48a727f52cc4d7d457626d8d6e0970e6ad0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 055b1308950d51a89055efbb801251bb62670c3df914ba5fb9be00a8c571c1a9 [INFO] running `Command { std: "docker" "start" "-a" "055b1308950d51a89055efbb801251bb62670c3df914ba5fb9be00a8c571c1a9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling rustix v0.38.18 [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling pulldown-cmark v0.9.3 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking gimli v0.28.0 [INFO] [stderr] Compiling openssl v0.10.57 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Compiling ryu v1.0.15 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling linux-raw-sys v0.4.10 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling itoa v1.0.9 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Compiling fastrand v2.0.1 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking parking_lot_core v0.6.3 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking http v0.1.21 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling bytecount v0.6.4 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Checking try_from v0.3.2 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking publicsuffix v1.5.6 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Compiling tempfile v3.8.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking hyper v0.12.36 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking hyper-tls v0.3.2 [INFO] [stderr] Checking serde_urlencoded v0.5.5 [INFO] [stderr] Checking cargo-platform v0.1.4 [INFO] [stderr] Checking cookie_store v0.7.0 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking reqwest v0.9.24 [INFO] [stderr] Checking skeptic v0.13.7 [INFO] [stderr] Compiling spotify v0.8.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:23 [INFO] [stdout] | [INFO] [stdout] 229 | pub fn poll(self, f: F) -> JoinHandle<()> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 235 | | let sleep_time = Duration::from_millis(250); [INFO] [stdout] 236 | | let mut last: Option = None; [INFO] [stdout] 237 | | let mut curr: Option; [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:217:15 [INFO] [stdout] | [INFO] [stdout] 196 | let mut resp = match self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | Err(error) => return Err(InternalSpotifyError::ReqwestError(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | Err(error) => return Err(InternalSpotifyError::IOError(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | match json::parse(response.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spotify` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:23 [INFO] [stdout] | [INFO] [stdout] 229 | pub fn poll(self, f: F) -> JoinHandle<()> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 235 | | let sleep_time = Duration::from_millis(250); [INFO] [stdout] 236 | | let mut last: Option = None; [INFO] [stdout] 237 | | let mut curr: Option; [INFO] [stdout] ... | [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connector.rs:217:15 [INFO] [stdout] | [INFO] [stdout] 196 | let mut resp = match self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | Err(error) => return Err(InternalSpotifyError::ReqwestError(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | Err(error) => return Err(InternalSpotifyError::IOError(error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | match json::parse(response.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spotify` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "055b1308950d51a89055efbb801251bb62670c3df914ba5fb9be00a8c571c1a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "055b1308950d51a89055efbb801251bb62670c3df914ba5fb9be00a8c571c1a9", kill_on_drop: false }` [INFO] [stdout] 055b1308950d51a89055efbb801251bb62670c3df914ba5fb9be00a8c571c1a9