[INFO] fetching crate split-csv 0.1.2... [INFO] checking split-csv-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate split-csv 0.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate split-csv 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate split-csv 0.1.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate split-csv 0.1.2 [INFO] tweaked toml for crates.io crate split-csv 0.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate split-csv 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0d408d5a45e2d98c0b5a2b8cf10acf2b6d00aa373993b6cc423c5e1dabfeaa37 [INFO] running `Command { std: "docker" "start" "-a" "0d408d5a45e2d98c0b5a2b8cf10acf2b6d00aa373993b6cc423c5e1dabfeaa37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0d408d5a45e2d98c0b5a2b8cf10acf2b6d00aa373993b6cc423c5e1dabfeaa37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d408d5a45e2d98c0b5a2b8cf10acf2b6d00aa373993b6cc423c5e1dabfeaa37", kill_on_drop: false }` [INFO] [stdout] 0d408d5a45e2d98c0b5a2b8cf10acf2b6d00aa373993b6cc423c5e1dabfeaa37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21127689c25133da9dded4d027f1c933365752429e0c1be9bd691a85831af052 [INFO] running `Command { std: "docker" "start" "-a" "21127689c25133da9dded4d027f1c933365752429e0c1be9bd691a85831af052", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking futures-io v0.3.19 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking fs_extra v1.2.0 [INFO] [stderr] Checking indexed_file v0.1.2 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling futures-macro v0.3.19 [INFO] [stderr] Compiling clap_derive v3.0.1 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking clap v3.0.6 [INFO] [stderr] Checking futures-executor v0.3.19 [INFO] [stderr] Checking futures v0.3.19 [INFO] [stderr] Checking split-csv v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/reader.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn open(path: impl AsRef) -> io::Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let reader = io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | [INFO] [stdout] 15 | Ok(Self { reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/shared.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 19 | fn n(value: BufReader) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Arc::new(Mutex::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/file_manager.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 31 | let file = if let Ok(file_path) = indexed_file::File::open_raw(file_path) { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let f = Box::new(file_path.to_string()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Some(File { [INFO] [stdout] | ______________^ [INFO] [stdout] 41 | | file_path: f, [INFO] [stdout] 42 | | file, [INFO] [stdout] 43 | | file_fs: Box::from(Path::new(file_path)), [INFO] [stdout] 44 | | header_line, [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `split-csv` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/reader.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn open(path: impl AsRef) -> io::Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let reader = io::BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | [INFO] [stdout] 15 | Ok(Self { reader }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/shared.rs:20:18 [INFO] [stdout] | [INFO] [stdout] 19 | fn n(value: BufReader) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Arc::new(Mutex::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> core/file_manager.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 31 | let file = if let Ok(file_path) = indexed_file::File::open_raw(file_path) { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let f = Box::new(file_path.to_string()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Some(File { [INFO] [stdout] | ______________^ [INFO] [stdout] 41 | | file_path: f, [INFO] [stdout] 42 | | file, [INFO] [stdout] 43 | | file_fs: Box::from(Path::new(file_path)), [INFO] [stdout] 44 | | header_line, [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `split-csv` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "21127689c25133da9dded4d027f1c933365752429e0c1be9bd691a85831af052", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21127689c25133da9dded4d027f1c933365752429e0c1be9bd691a85831af052", kill_on_drop: false }` [INFO] [stdout] 21127689c25133da9dded4d027f1c933365752429e0c1be9bd691a85831af052