[INFO] fetching crate spirit-tokio 0.9.2... [INFO] checking spirit-tokio-0.9.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spirit-tokio 0.9.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate spirit-tokio 0.9.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spirit-tokio 0.9.2 [INFO] finished tweaking crates.io crate spirit-tokio 0.9.2 [INFO] tweaked toml for crates.io crate spirit-tokio 0.9.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate spirit-tokio 0.9.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b23b872760c1d7c32d0b76436cc200a49419d1b0852fe0fce9ee6fb80a48049d [INFO] running `Command { std: "docker" "start" "-a" "b23b872760c1d7c32d0b76436cc200a49419d1b0852fe0fce9ee6fb80a48049d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b23b872760c1d7c32d0b76436cc200a49419d1b0852fe0fce9ee6fb80a48049d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b23b872760c1d7c32d0b76436cc200a49419d1b0852fe0fce9ee6fb80a48049d", kill_on_drop: false }` [INFO] [stdout] b23b872760c1d7c32d0b76436cc200a49419d1b0852fe0fce9ee6fb80a48049d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f2bd70fb7d7af4f57b737179dd6ccb5b20c941fb8832f0ab43a9b95bd7412bc [INFO] running `Command { std: "docker" "start" "-a" "4f2bd70fb7d7af4f57b737179dd6ccb5b20c941fb8832f0ab43a9b95bd7412bc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.30 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling libc v0.2.105 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling cc v1.0.71 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling itertools v0.8.2 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling tokio v1.12.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling unindent v0.1.7 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling signal-hook v0.3.10 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking arc-swap v1.4.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking err-context v0.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling tokio-macros v1.5.0 [INFO] [stderr] Compiling structdoc-derive v0.1.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling pin-project-internal v1.0.8 [INFO] [stderr] Checking structdoc v0.1.4 [INFO] [stderr] Checking pin-project v1.0.8 [INFO] [stderr] Checking structopt v0.3.25 [INFO] [stderr] Checking tokio-stream v0.1.7 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking serde_ignored v0.1.2 [INFO] [stderr] Checking serde_path_to_error v0.1.5 [INFO] [stderr] Checking config v0.11.0 [INFO] [stderr] Checking spirit v0.4.21 [INFO] [stderr] Checking spirit-tokio v0.9.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/runtime.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct ShutGuard(Arc>); [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ShutGuard` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/either.rs:516:34 [INFO] [stdout] | [INFO] [stdout] 512 | resource: Fi::Resource, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 516 | self.0.transform((self.2)(resource), self.1, name) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 151 | fn transform(&mut self, r: R, _: &SF, name: &str) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | trace!("Wrapping {} into a future", name); [INFO] [stdout] 153 | Ok((self.0)(r)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:188:51 [INFO] [stdout] | [INFO] [stdout] 187 | let fut = (me.f)(conn, me.cfg); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | tokio::spawn(async move { fut.await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 227 | accept: A, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let f = self.0.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let cfg = cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | Ok(Acceptor { [INFO] [stdout] | ____________^ [INFO] [stdout] 235 | | accept, [INFO] [stdout] 236 | | f, [INFO] [stdout] 237 | | cfg, [INFO] [stdout] 238 | | name, [INFO] [stdout] 239 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:277:12 [INFO] [stdout] | [INFO] [stdout] 270 | accept: A, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let f = (self.0)(&accept, cfg); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | let cfg = cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | Ok(Acceptor { [INFO] [stdout] | ____________^ [INFO] [stdout] 278 | | accept, [INFO] [stdout] 279 | | f, [INFO] [stdout] 280 | | cfg, [INFO] [stdout] 281 | | name, [INFO] [stdout] 282 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/installer.rs:128:27 [INFO] [stdout] | [INFO] [stdout] 104 | fn install(&mut self, fut: F, name: &'static str) -> RemoteDrop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let (request_send, request_recv) = oneshot::channel(); [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let wakeup = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let guard = SendOnDrop(Arc::clone(&wakeup)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let cancellable_future = async move { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | request_drop: Some(request_send), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/installer.rs:130:26 [INFO] [stdout] | [INFO] [stdout] 104 | fn install(&mut self, fut: F, name: &'static str) -> RemoteDrop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let (request_send, request_recv) = oneshot::channel(); [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let wakeup = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let guard = SendOnDrop(Arc::clone(&wakeup)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let cancellable_future = async move { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | _shut_guard: runtime::shut_guard(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let sock = self.create_any(SocketType::STREAM)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | Ok(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:326:12 [INFO] [stdout] | [INFO] [stdout] 325 | let sock = self.create_any(SocketType::DGRAM)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | Ok(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:440:29 [INFO] [stdout] | [INFO] [stdout] 418 | fn configure(&self, stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 419 | let sock: Socket = stream.into_std()?.into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | TcpStream::from_std(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:572:9 [INFO] [stdout] | [INFO] [stdout] 571 | let config = self.tcp_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 572 | / seed.try_clone() // Another copy of the listener [INFO] [stdout] 573 | | // std → tokio socket conversion [INFO] [stdout] 574 | | .and_then(|sock| -> Result { [INFO] [stdout] 575 | | sock.set_nonblocking(true)?; [INFO] [stdout] ... | [INFO] [stdout] 578 | | .with_context(|_| format!("Failed to make socket {}/{:?} asynchronous", name, self)) [INFO] [stdout] 579 | | .map_err(AnyError::from) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:580:18 [INFO] [stdout] | [INFO] [stdout] 571 | let config = self.tcp_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 580 | .map(|listener| ConfiguredListener::new(listener, config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/limits.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 124 | let inner = self.listen.make_resource(seed, name)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let sem = Arc::new(Semaphore::new(limit)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let sem_get = move || { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let pinned = LimitedImpl { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Ok(Limited { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | inner, [INFO] [stdout] 145 | | error_sleep: self.limits.error_sleep(), [INFO] [stdout] 146 | | extra_permit: None, [INFO] [stdout] 147 | | pinned: Box::pin(pinned), [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/limits.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 129 | let sem = Arc::clone(&sem); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | async move { [INFO] [stdout] 131 | / sem.acquire_owned() [INFO] [stdout] 132 | | .await [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:44:79 [INFO] [stdout] | [INFO] [stdout] 44 | #[derive(Copy, Clone, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 67 | let socket = Socket::new(Domain::UNIX, tp, None)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(socket.connect(addr).is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 206 | let sock = self.create_any(SocketType::STREAM)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 216 | let sock = self.create_any(SocketType::DGRAM)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 309 | let config = self.unix_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | / seed.socket [INFO] [stdout] 311 | | .try_clone() // Another copy of the listener [INFO] [stdout] 312 | | // std → tokio socket conversion [INFO] [stdout] 313 | | .and_then(|sock| -> Result { [INFO] [stdout] ... | [INFO] [stdout] 322 | | }) [INFO] [stdout] 323 | | .map_err(AnyError::from) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:324:18 [INFO] [stdout] | [INFO] [stdout] 309 | let config = self.unix_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | .map(|listener| ConfiguredListener::new(listener, config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 33 | fn with_shut_guard R>(g: Option, f: F) -> R { [INFO] [stdout] | -------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | SHUT_GUARD.with(|c| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 35 | | // Install the ShutGuard to thread local storage so others can have a look at it. [INFO] [stdout] 36 | | assert!(c.replace(g).is_none()); [INFO] [stdout] 37 | | struct Guard<'a>(&'a Cell>); [INFO] [stdout] ... | [INFO] [stdout] 46 | | f() [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:202:24 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn from_cfg(mut extractor: E) -> Self [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let extractor = move |_opts: &O, cfg: &C| extractor(cfg); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let finish = |mut builder: Builder| -> Result { Ok(builder.build()?) }; [INFO] [stdout] 202 | Tokio::FromCfg(Box::new(extractor), Box::new(finish)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:202:45 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn from_cfg(mut extractor: E) -> Self [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let extractor = move |_opts: &O, cfg: &C| extractor(cfg); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let finish = |mut builder: Builder| -> Result { Ok(builder.build()?) }; [INFO] [stdout] 202 | Tokio::FromCfg(Box::new(extractor), Box::new(finish)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:201:79 [INFO] [stdout] | [INFO] [stdout] 201 | let finish = |mut builder: Builder| -> Result { Ok(builder.build()?) }; [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 241 | fn apply(mut self, ext: E) -> Result { [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let runtime = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let handle = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | [INFO] [stdout] 261 | let init = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let mut initialized = false; [INFO] [stdout] 263 | let runtime = Arc::clone(&runtime); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let handle = Arc::clone(&handle); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let (terminate_send, terminate_recv) = oneshot::channel::<()>(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let shutdown_guard = Arc::new(Mutex::new(Some(ShutGuard(Arc::new(terminate_send))))); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let shutdown_guard_main = Arc::clone(&shutdown_guard); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let shutdown_guard_drain = Arc::clone(&shutdown_guard); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let around_hooks: Box FnMut(Box) + Send> = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | / ext [INFO] [stdout] 336 | | .config_validator(init) [INFO] [stdout] 337 | | .around_hooks(around_hooks) [INFO] [stdout] 338 | | .on_terminate(move || { [INFO] [stdout] 339 | | trace!("Removing global shutdown guard (others might be present in resources)"); [INFO] [stdout] 340 | | shutdown_guard_drain.lock().unwrap().take(); [INFO] [stdout] 341 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:342:25 [INFO] [stdout] | [INFO] [stdout] 241 | fn apply(mut self, ext: E) -> Result { [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let runtime = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let handle = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | [INFO] [stdout] 261 | let init = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let mut initialized = false; [INFO] [stdout] 263 | let runtime = Arc::clone(&runtime); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let handle = Arc::clone(&handle); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let (terminate_send, terminate_recv) = oneshot::channel::<()>(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let shutdown_guard = Arc::new(Mutex::new(Some(ShutGuard(Arc::new(terminate_send))))); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let shutdown_guard_main = Arc::clone(&shutdown_guard); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let shutdown_guard_drain = Arc::clone(&shutdown_guard); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let around_hooks: Box FnMut(Box) + Send> = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | .run_around(move |spirit, inner| -> Result<(), AnyError> { [INFO] [stdout] | _________________________^ [INFO] [stdout] 343 | | // No need to worry about poisons here, we are going to be called just once [INFO] [stdout] 344 | | let runtime = runtime.lock().unwrap().take().expect("Run even before config"); [INFO] [stdout] 345 | | debug!("Running with tokio runtime"); [INFO] [stdout] ... | [INFO] [stdout] 362 | | result [INFO] [stdout] 363 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:296:20 [INFO] [stdout] | [INFO] [stdout] 241 | fn apply(mut self, ext: E) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let runtime = Arc::clone(&runtime); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let handle = Arc::clone(&handle); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | Ok(Action::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:317:45 [INFO] [stdout] | [INFO] [stdout] 259 | let handle = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | let shutdown_guard = Arc::new(Mutex::new(Some(ShutGuard(Arc::new(terminate_send))))); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Box::new(move |inner| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | let locked = handle [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let shut_guard = shutdown_guard.lock().unwrap().clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | with_shut_guard(shut_guard, || { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 318 | | if let Some(handle) = locked.as_ref() { [INFO] [stdout] 319 | | trace!("Wrapping hooks into tokio handle"); [INFO] [stdout] 320 | | let _guard = handle.enter(); [INFO] [stdout] ... | [INFO] [stdout] 331 | | } [INFO] [stdout] 332 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spirit-tokio` (lib) due to 29 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/runtime.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct ShutGuard(Arc>); [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ShutGuard` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/either.rs:516:34 [INFO] [stdout] | [INFO] [stdout] 512 | resource: Fi::Resource, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 516 | self.0.transform((self.2)(resource), self.1, name) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 151 | fn transform(&mut self, r: R, _: &SF, name: &str) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | trace!("Wrapping {} into a future", name); [INFO] [stdout] 153 | Ok((self.0)(r)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:188:51 [INFO] [stdout] | [INFO] [stdout] 187 | let fut = (me.f)(conn, me.cfg); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | tokio::spawn(async move { fut.await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 227 | accept: A, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let f = self.0.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let cfg = cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | Ok(Acceptor { [INFO] [stdout] | ____________^ [INFO] [stdout] 235 | | accept, [INFO] [stdout] 236 | | f, [INFO] [stdout] 237 | | cfg, [INFO] [stdout] 238 | | name, [INFO] [stdout] 239 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:277:12 [INFO] [stdout] | [INFO] [stdout] 270 | accept: A, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let f = (self.0)(&accept, cfg); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | let cfg = cfg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | Ok(Acceptor { [INFO] [stdout] | ____________^ [INFO] [stdout] 278 | | accept, [INFO] [stdout] 279 | | f, [INFO] [stdout] 280 | | cfg, [INFO] [stdout] 281 | | name, [INFO] [stdout] 282 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/installer.rs:128:27 [INFO] [stdout] | [INFO] [stdout] 104 | fn install(&mut self, fut: F, name: &'static str) -> RemoteDrop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let (request_send, request_recv) = oneshot::channel(); [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let wakeup = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let guard = SendOnDrop(Arc::clone(&wakeup)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let cancellable_future = async move { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | request_drop: Some(request_send), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/installer.rs:130:26 [INFO] [stdout] | [INFO] [stdout] 104 | fn install(&mut self, fut: F, name: &'static str) -> RemoteDrop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let (request_send, request_recv) = oneshot::channel(); [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let wakeup = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let guard = SendOnDrop(Arc::clone(&wakeup)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let cancellable_future = async move { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | _shut_guard: runtime::shut_guard(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 315 | let sock = self.create_any(SocketType::STREAM)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | Ok(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:326:12 [INFO] [stdout] | [INFO] [stdout] 325 | let sock = self.create_any(SocketType::DGRAM)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | Ok(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:440:29 [INFO] [stdout] | [INFO] [stdout] 418 | fn configure(&self, stream: TcpStream) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 419 | let sock: Socket = stream.into_std()?.into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | TcpStream::from_std(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:572:9 [INFO] [stdout] | [INFO] [stdout] 571 | let config = self.tcp_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 572 | / seed.try_clone() // Another copy of the listener [INFO] [stdout] 573 | | // std → tokio socket conversion [INFO] [stdout] 574 | | .and_then(|sock| -> Result { [INFO] [stdout] 575 | | sock.set_nonblocking(true)?; [INFO] [stdout] ... | [INFO] [stdout] 578 | | .with_context(|_| format!("Failed to make socket {}/{:?} asynchronous", name, self)) [INFO] [stdout] 579 | | .map_err(AnyError::from) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/mod.rs:580:18 [INFO] [stdout] | [INFO] [stdout] 571 | let config = self.tcp_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 580 | .map(|listener| ConfiguredListener::new(listener, config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/limits.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 124 | let inner = self.listen.make_resource(seed, name)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let sem = Arc::new(Semaphore::new(limit)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let sem_get = move || { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let pinned = LimitedImpl { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | Ok(Limited { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | inner, [INFO] [stdout] 145 | | error_sleep: self.limits.error_sleep(), [INFO] [stdout] 146 | | extra_permit: None, [INFO] [stdout] 147 | | pinned: Box::pin(pinned), [INFO] [stdout] 148 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/limits.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 129 | let sem = Arc::clone(&sem); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | async move { [INFO] [stdout] 131 | / sem.acquire_owned() [INFO] [stdout] 132 | | .await [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:44:79 [INFO] [stdout] | [INFO] [stdout] 44 | #[derive(Copy, Clone, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 67 | let socket = Socket::new(Domain::UNIX, tp, None)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Ok(socket.connect(addr).is_err()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 206 | let sock = self.create_any(SocketType::STREAM)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Ok(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 216 | let sock = self.create_any(SocketType::DGRAM)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok(sock.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:310:9 [INFO] [stdout] | [INFO] [stdout] 309 | let config = self.unix_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | / seed.socket [INFO] [stdout] 311 | | .try_clone() // Another copy of the listener [INFO] [stdout] 312 | | // std → tokio socket conversion [INFO] [stdout] 313 | | .and_then(|sock| -> Result { [INFO] [stdout] ... | [INFO] [stdout] 322 | | }) [INFO] [stdout] 323 | | .map_err(AnyError::from) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/unix.rs:324:18 [INFO] [stdout] | [INFO] [stdout] 309 | let config = self.unix_config.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | .map(|listener| ConfiguredListener::new(listener, config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 33 | fn with_shut_guard R>(g: Option, f: F) -> R { [INFO] [stdout] | -------------------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | SHUT_GUARD.with(|c| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 35 | | // Install the ShutGuard to thread local storage so others can have a look at it. [INFO] [stdout] 36 | | assert!(c.replace(g).is_none()); [INFO] [stdout] 37 | | struct Guard<'a>(&'a Cell>); [INFO] [stdout] ... | [INFO] [stdout] 46 | | f() [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:202:24 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn from_cfg(mut extractor: E) -> Self [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let extractor = move |_opts: &O, cfg: &C| extractor(cfg); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let finish = |mut builder: Builder| -> Result { Ok(builder.build()?) }; [INFO] [stdout] 202 | Tokio::FromCfg(Box::new(extractor), Box::new(finish)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:202:45 [INFO] [stdout] | [INFO] [stdout] 196 | pub fn from_cfg(mut extractor: E) -> Self [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let extractor = move |_opts: &O, cfg: &C| extractor(cfg); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let finish = |mut builder: Builder| -> Result { Ok(builder.build()?) }; [INFO] [stdout] 202 | Tokio::FromCfg(Box::new(extractor), Box::new(finish)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:201:79 [INFO] [stdout] | [INFO] [stdout] 201 | let finish = |mut builder: Builder| -> Result { Ok(builder.build()?) }; [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 241 | fn apply(mut self, ext: E) -> Result { [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let runtime = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let handle = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | [INFO] [stdout] 261 | let init = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let mut initialized = false; [INFO] [stdout] 263 | let runtime = Arc::clone(&runtime); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let handle = Arc::clone(&handle); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let (terminate_send, terminate_recv) = oneshot::channel::<()>(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let shutdown_guard = Arc::new(Mutex::new(Some(ShutGuard(Arc::new(terminate_send))))); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let shutdown_guard_main = Arc::clone(&shutdown_guard); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let shutdown_guard_drain = Arc::clone(&shutdown_guard); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let around_hooks: Box FnMut(Box) + Send> = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 335 | / ext [INFO] [stdout] 336 | | .config_validator(init) [INFO] [stdout] 337 | | .around_hooks(around_hooks) [INFO] [stdout] 338 | | .on_terminate(move || { [INFO] [stdout] 339 | | trace!("Removing global shutdown guard (others might be present in resources)"); [INFO] [stdout] 340 | | shutdown_guard_drain.lock().unwrap().take(); [INFO] [stdout] 341 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:342:25 [INFO] [stdout] | [INFO] [stdout] 241 | fn apply(mut self, ext: E) -> Result { [INFO] [stdout] | -------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | let runtime = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let handle = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | [INFO] [stdout] 261 | let init = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | let mut initialized = false; [INFO] [stdout] 263 | let runtime = Arc::clone(&runtime); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let handle = Arc::clone(&handle); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let (terminate_send, terminate_recv) = oneshot::channel::<()>(); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 301 | let shutdown_guard = Arc::new(Mutex::new(Some(ShutGuard(Arc::new(terminate_send))))); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let shutdown_guard_main = Arc::clone(&shutdown_guard); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let shutdown_guard_drain = Arc::clone(&shutdown_guard); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let around_hooks: Box FnMut(Box) + Send> = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | .run_around(move |spirit, inner| -> Result<(), AnyError> { [INFO] [stdout] | _________________________^ [INFO] [stdout] 343 | | // No need to worry about poisons here, we are going to be called just once [INFO] [stdout] 344 | | let runtime = runtime.lock().unwrap().take().expect("Run even before config"); [INFO] [stdout] 345 | | debug!("Running with tokio runtime"); [INFO] [stdout] ... | [INFO] [stdout] 362 | | result [INFO] [stdout] 363 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:296:20 [INFO] [stdout] | [INFO] [stdout] 241 | fn apply(mut self, ext: E) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let runtime = Arc::clone(&runtime); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let handle = Arc::clone(&handle); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | Ok(Action::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:317:45 [INFO] [stdout] | [INFO] [stdout] 259 | let handle = Arc::new(Mutex::new(None)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | let shutdown_guard = Arc::new(Mutex::new(Some(ShutGuard(Arc::new(terminate_send))))); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | Box::new(move |inner| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | let locked = handle [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | let shut_guard = shutdown_guard.lock().unwrap().clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | with_shut_guard(shut_guard, || { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 318 | | if let Some(handle) = locked.as_ref() { [INFO] [stdout] 319 | | trace!("Wrapping hooks into tokio handle"); [INFO] [stdout] 320 | | let _guard = handle.enter(); [INFO] [stdout] ... | [INFO] [stdout] 331 | | } [INFO] [stdout] 332 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spirit-tokio` (lib test) due to 29 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4f2bd70fb7d7af4f57b737179dd6ccb5b20c941fb8832f0ab43a9b95bd7412bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f2bd70fb7d7af4f57b737179dd6ccb5b20c941fb8832f0ab43a9b95bd7412bc", kill_on_drop: false }` [INFO] [stdout] 4f2bd70fb7d7af4f57b737179dd6ccb5b20c941fb8832f0ab43a9b95bd7412bc