[INFO] fetching crate spirit-log 0.4.4... [INFO] checking spirit-log-0.4.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spirit-log 0.4.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate spirit-log 0.4.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spirit-log 0.4.4 [INFO] finished tweaking crates.io crate spirit-log 0.4.4 [INFO] tweaked toml for crates.io crate spirit-log 0.4.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate spirit-log 0.4.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 793e225575c7965851e86914461c4f511235e6fff4b292447dc13ce9a9e3a104 [INFO] running `Command { std: "docker" "start" "-a" "793e225575c7965851e86914461c4f511235e6fff4b292447dc13ce9a9e3a104", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "793e225575c7965851e86914461c4f511235e6fff4b292447dc13ce9a9e3a104", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "793e225575c7965851e86914461c4f511235e6fff4b292447dc13ce9a9e3a104", kill_on_drop: false }` [INFO] [stdout] 793e225575c7965851e86914461c4f511235e6fff4b292447dc13ce9a9e3a104 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7cd15c10be6f4618be1b67a9e14df3ec11e5a485edd0104d8c88a7e50af4a9df [INFO] running `Command { std: "docker" "start" "-a" "7cd15c10be6f4618be1b67a9e14df3ec11e5a485edd0104d8c88a7e50af4a9df", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling serde v1.0.127 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling itertools v0.8.2 [INFO] [stderr] Checking gimli v0.25.0 [INFO] [stderr] Compiling unindent v0.1.7 [INFO] [stderr] Checking arc-swap v1.3.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling serde_json v1.0.66 [INFO] [stderr] Checking rustc-demangle v0.1.20 [INFO] [stderr] Checking object v0.26.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking err-context v0.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking log-reroute v0.1.7 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking fern v0.6.0 [INFO] [stderr] Compiling signal-hook v0.3.9 [INFO] [stderr] Compiling backtrace v0.3.61 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking addr2line v0.16.0 [INFO] [stderr] Checking log-panics v2.0.0 [INFO] [stderr] Compiling structopt-derive v0.4.15 [INFO] [stderr] Compiling structdoc-derive v0.1.4 [INFO] [stderr] Checking structdoc v0.1.4 [INFO] [stderr] Checking structopt v0.3.22 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking serde_path_to_error v0.1.4 [INFO] [stderr] Checking serde_ignored v0.1.2 [INFO] [stderr] Checking config v0.10.1 [INFO] [stderr] Checking spirit v0.4.17 [INFO] [stderr] Checking spirit-log v0.4.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:237:30 [INFO] [stdout] | [INFO] [stdout] 237 | parse(try_from_str = spirit::utils::key_val), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:33 [INFO] [stdout] | [INFO] [stdout] 344 | .map(|name| (*name, Field::new(Documentation::leaf_empty(), ""))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:364:30 [INFO] [stdout] | [INFO] [stdout] 364 | #[derive(Clone, Copy, Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:395:30 [INFO] [stdout] | [INFO] [stdout] 395 | #[derive(Clone, Copy, Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:685:5 [INFO] [stdout] | [INFO] [stdout] 680 | fn create<'a, I>(logging: I) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 685 | / logging [INFO] [stdout] 686 | | .into_iter() [INFO] [stdout] 687 | | .map(Logger::create) [INFO] [stdout] 688 | | .fold_ok(Dispatch::new(), Dispatch::chain) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:918:22 [INFO] [stdout] | [INFO] [stdout] 915 | fn init>(&mut self, builder: B, _name: &str) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 918 | builder.with(Cfg::init_extension()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:930:22 [INFO] [stdout] | [INFO] [stdout] 927 | fn init>(&mut self, builder: B, _name: &str) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 930 | builder.with(Cfg::init_extension()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spirit-log` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:237:30 [INFO] [stdout] | [INFO] [stdout] 237 | parse(try_from_str = spirit::utils::key_val), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:33 [INFO] [stdout] | [INFO] [stdout] 344 | .map(|name| (*name, Field::new(Documentation::leaf_empty(), ""))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:364:30 [INFO] [stdout] | [INFO] [stdout] 364 | #[derive(Clone, Copy, Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:395:30 [INFO] [stdout] | [INFO] [stdout] 395 | #[derive(Clone, Copy, Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:685:5 [INFO] [stdout] | [INFO] [stdout] 680 | fn create<'a, I>(logging: I) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 685 | / logging [INFO] [stdout] 686 | | .into_iter() [INFO] [stdout] 687 | | .map(Logger::create) [INFO] [stdout] 688 | | .fold_ok(Dispatch::new(), Dispatch::chain) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:918:22 [INFO] [stdout] | [INFO] [stdout] 915 | fn init>(&mut self, builder: B, _name: &str) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 918 | builder.with(Cfg::init_extension()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:930:22 [INFO] [stdout] | [INFO] [stdout] 927 | fn init>(&mut self, builder: B, _name: &str) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 930 | builder.with(Cfg::init_extension()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spirit-log` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "7cd15c10be6f4618be1b67a9e14df3ec11e5a485edd0104d8c88a7e50af4a9df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7cd15c10be6f4618be1b67a9e14df3ec11e5a485edd0104d8c88a7e50af4a9df", kill_on_drop: false }` [INFO] [stdout] 7cd15c10be6f4618be1b67a9e14df3ec11e5a485edd0104d8c88a7e50af4a9df