[INFO] fetching crate spinoff 0.8.0... [INFO] checking spinoff-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spinoff 0.8.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate spinoff 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spinoff 0.8.0 [INFO] finished tweaking crates.io crate spinoff 0.8.0 [INFO] tweaked toml for crates.io crate spinoff 0.8.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate spinoff 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8094c5e3e4822a151538b26b93a4c03af7d96cf35b8e6a7e59aafaac566616e0 [INFO] running `Command { std: "docker" "start" "-a" "8094c5e3e4822a151538b26b93a4c03af7d96cf35b8e6a7e59aafaac566616e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8094c5e3e4822a151538b26b93a4c03af7d96cf35b8e6a7e59aafaac566616e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8094c5e3e4822a151538b26b93a4c03af7d96cf35b8e6a7e59aafaac566616e0", kill_on_drop: false }` [INFO] [stdout] 8094c5e3e4822a151538b26b93a4c03af7d96cf35b8e6a7e59aafaac566616e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b430c54087aaddaedf7bc75bf542d5411662edf12331d7e5ad385dec1a6e1d72 [INFO] running `Command { std: "docker" "start" "-a" "b430c54087aaddaedf7bc75bf542d5411662edf12331d7e5ad385dec1a6e1d72", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling paste v1.0.11 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking spinoff v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `grow_vertical` [INFO] [stdout] --> src/spinners.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | #[cfg(feature = $name)] [INFO] [stdout] | ^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"grow_verticle"` [INFO] [stdout] ... [INFO] [stdout] 154 | / spinner_frames!( [INFO] [stdout] 155 | | "grow_vertical", [INFO] [stdout] 156 | | ["▁", "▃", "▄", "▅", "▆", "▇", "▆", "▅", "▄", "▃"], [INFO] [stdout] 157 | | 120 [INFO] [stdout] 158 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `aesthetic`, `all`, `arc`, `arrow`, `arrow2`, `arrow3`, `balloon`, `balloon2`, `beta_wave`, `binary`, `blue_pulse`, `bounce`, `bouncing_ball`, `bouncing_bar`, `box_bounce`, `box_bounce2`, `christmas`, `circle`, `circle_halves`, `circle_quarters`, `clock`, `cute`, `default`, `dots`, `dots10`, `dots11`, `dots12`, `dots2`, `dots3`, `dots4`, `dots5`, `dots6`, `dots7`, `dots8`, and `dots8bit` and 51 more [INFO] [stdout] = help: consider adding `grow_vertical` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `spinner_frames` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `grow_vertical` [INFO] [stdout] --> src/spinners.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | #[cfg(feature = $name)] [INFO] [stdout] | ^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"grow_verticle"` [INFO] [stdout] ... [INFO] [stdout] 154 | / spinner_frames!( [INFO] [stdout] 155 | | "grow_vertical", [INFO] [stdout] 156 | | ["▁", "▃", "▄", "▅", "▆", "▇", "▆", "▅", "▄", "▃"], [INFO] [stdout] 157 | | 120 [INFO] [stdout] 158 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `aesthetic`, `all`, `arc`, `arrow`, `arrow2`, `arrow3`, `balloon`, `balloon2`, `beta_wave`, `binary`, `blue_pulse`, `bounce`, `bouncing_ball`, `bouncing_bar`, `box_bounce`, `box_bounce2`, `christmas`, `circle`, `circle_halves`, `circle_quarters`, `clock`, `cute`, `default`, `dots`, `dots10`, `dots11`, `dots12`, `dots2`, `dots3`, `dots4`, `dots5`, `dots6`, `dots7`, `dots8`, and `dots8bit` and 51 more [INFO] [stdout] = help: consider adding `grow_vertical` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `spinner_frames` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `grow_vertical` [INFO] [stdout] --> src/spinners.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | #[cfg(feature = $name)] [INFO] [stdout] | ^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"grow_verticle"` [INFO] [stdout] ... [INFO] [stdout] 154 | / spinner_frames!( [INFO] [stdout] 155 | | "grow_vertical", [INFO] [stdout] 156 | | ["▁", "▃", "▄", "▅", "▆", "▇", "▆", "▅", "▄", "▃"], [INFO] [stdout] 157 | | 120 [INFO] [stdout] 158 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `aesthetic`, `all`, `arc`, `arrow`, `arrow2`, `arrow3`, `balloon`, `balloon2`, `beta_wave`, `binary`, `blue_pulse`, `bounce`, `bouncing_ball`, `bouncing_bar`, `box_bounce`, `box_bounce2`, `christmas`, `circle`, `circle_halves`, `circle_quarters`, `clock`, `cute`, `default`, `dots`, `dots10`, `dots11`, `dots12`, `dots2`, `dots3`, `dots4`, `dots5`, `dots6`, `dots7`, `dots8`, and `dots8bit` and 51 more [INFO] [stdout] = help: consider adding `grow_vertical` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `spinner_frames` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `grow_vertical` [INFO] [stdout] --> src/spinners.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | #[cfg(feature = $name)] [INFO] [stdout] | ^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"grow_verticle"` [INFO] [stdout] ... [INFO] [stdout] 154 | / spinner_frames!( [INFO] [stdout] 155 | | "grow_vertical", [INFO] [stdout] 156 | | ["▁", "▃", "▄", "▅", "▆", "▇", "▆", "▅", "▄", "▃"], [INFO] [stdout] 157 | | 120 [INFO] [stdout] 158 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `aesthetic`, `all`, `arc`, `arrow`, `arrow2`, `arrow3`, `balloon`, `balloon2`, `beta_wave`, `binary`, `blue_pulse`, `bounce`, `bouncing_ball`, `bouncing_bar`, `box_bounce`, `box_bounce2`, `christmas`, `circle`, `circle_halves`, `circle_quarters`, `clock`, `cute`, `default`, `dots`, `dots10`, `dots11`, `dots12`, `dots2`, `dots3`, `dots4`, `dots5`, `dots6`, `dots7`, `dots8`, and `dots8bit` and 51 more [INFO] [stdout] = help: consider adding `grow_vertical` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `spinner_frames` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `grow_vertical` [INFO] [stdout] --> src/spinners.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | #[cfg(feature = $name)] [INFO] [stdout] | ^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"grow_verticle"` [INFO] [stdout] ... [INFO] [stdout] 154 | / spinner_frames!( [INFO] [stdout] 155 | | "grow_vertical", [INFO] [stdout] 156 | | ["▁", "▃", "▄", "▅", "▆", "▇", "▆", "▅", "▄", "▃"], [INFO] [stdout] 157 | | 120 [INFO] [stdout] 158 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `aesthetic`, `all`, `arc`, `arrow`, `arrow2`, `arrow3`, `balloon`, `balloon2`, `beta_wave`, `binary`, `blue_pulse`, `bounce`, `bouncing_ball`, `bouncing_bar`, `box_bounce`, `box_bounce2`, `christmas`, `circle`, `circle_halves`, `circle_quarters`, `clock`, `cute`, `default`, `dots`, `dots10`, `dots11`, `dots12`, `dots2`, `dots3`, `dots4`, `dots5`, `dots6`, `dots7`, `dots8`, and `dots8bit` and 51 more [INFO] [stdout] = help: consider adding `grow_vertical` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `spinner_frames` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `grow_vertical` [INFO] [stdout] --> src/spinners.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | #[cfg(feature = $name)] [INFO] [stdout] | ^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"grow_verticle"` [INFO] [stdout] ... [INFO] [stdout] 154 | / spinner_frames!( [INFO] [stdout] 155 | | "grow_vertical", [INFO] [stdout] 156 | | ["▁", "▃", "▄", "▅", "▆", "▇", "▆", "▅", "▄", "▃"], [INFO] [stdout] 157 | | 120 [INFO] [stdout] 158 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `aesthetic`, `all`, `arc`, `arrow`, `arrow2`, `arrow3`, `balloon`, `balloon2`, `beta_wave`, `binary`, `blue_pulse`, `bounce`, `bouncing_ball`, `bouncing_bar`, `box_bounce`, `box_bounce2`, `christmas`, `circle`, `circle_halves`, `circle_quarters`, `clock`, `cute`, `default`, `dots`, `dots10`, `dots11`, `dots12`, `dots2`, `dots3`, `dots4`, `dots5`, `dots6`, `dots7`, `dots8`, and `dots8bit` and 51 more [INFO] [stdout] = help: consider adding `grow_vertical` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the macro `spinner_frames` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:221:28 [INFO] [stdout] | [INFO] [stdout] 174 | pub fn new_with_stream(spinner_type: S, msg: T, color: U, stream: Streams) -> Self [INFO] [stdout] | --------------- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let still_spinning = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let handle = thread::spawn({ [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | // Clone the atomic bool so that we can use it in the thread and return the original one later. [INFO] [stdout] 188 | let still_spinning = Arc::clone(&still_spinning); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | thread_handle: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:221:28 [INFO] [stdout] | [INFO] [stdout] 174 | pub fn new_with_stream(spinner_type: S, msg: T, color: U, stream: Streams) -> Self [INFO] [stdout] | --------------- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let still_spinning = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let handle = thread::spawn({ [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | // Clone the atomic bool so that we can use it in the thread and return the original one later. [INFO] [stdout] 188 | let still_spinning = Arc::clone(&still_spinning); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | thread_handle: Some(handle), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spinoff` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `spinoff` (lib) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b430c54087aaddaedf7bc75bf542d5411662edf12331d7e5ad385dec1a6e1d72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b430c54087aaddaedf7bc75bf542d5411662edf12331d7e5ad385dec1a6e1d72", kill_on_drop: false }` [INFO] [stdout] b430c54087aaddaedf7bc75bf542d5411662edf12331d7e5ad385dec1a6e1d72