[INFO] fetching crate spinning 0.1.0... [INFO] checking spinning-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spinning 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate spinning 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spinning 0.1.0 [INFO] finished tweaking crates.io crate spinning 0.1.0 [INFO] tweaked toml for crates.io crate spinning 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 691e4542d715977ec47454e0a4958c63a0beaff987a5749b4a1a6a30b361fec0 [INFO] running `Command { std: "docker" "start" "-a" "691e4542d715977ec47454e0a4958c63a0beaff987a5749b4a1a6a30b361fec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "691e4542d715977ec47454e0a4958c63a0beaff987a5749b4a1a6a30b361fec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "691e4542d715977ec47454e0a4958c63a0beaff987a5749b4a1a6a30b361fec0", kill_on_drop: false }` [INFO] [stdout] 691e4542d715977ec47454e0a4958c63a0beaff987a5749b4a1a6a30b361fec0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 697de707dbaab8680d81eb0a7b0a97955e076226b5a00af33f69049bbd757761 [INFO] running `Command { std: "docker" "start" "-a" "697de707dbaab8680d81eb0a7b0a97955e076226b5a00af33f69049bbd757761", kill_on_drop: false }` [INFO] [stderr] Checking spinning v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:165:21 [INFO] [stdout] | [INFO] [stdout] 165 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:189:21 [INFO] [stdout] | [INFO] [stdout] 189 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 300 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:165:21 [INFO] [stdout] | [INFO] [stdout] 165 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:189:21 [INFO] [stdout] | [INFO] [stdout] 189 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:252:21 [INFO] [stdout] | [INFO] [stdout] 252 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 300 | atomic::spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:593:19 [INFO] [stdout] | [INFO] [stdout] 591 | pub const fn new(f: F) -> Lazy { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 592 | Lazy { [INFO] [stdout] 593 | once: Once::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:594:19 [INFO] [stdout] | [INFO] [stdout] 591 | pub const fn new(f: F) -> Lazy { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 594 | init: Cell::new(Some(f)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:614:38 [INFO] [stdout] | [INFO] [stdout] 614 | this.once.call_once(|| match this.init.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:679:31 [INFO] [stdout] | [INFO] [stdout] 678 | let data = Arc::clone(&data); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 679 | thread::spawn(move || { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 680 | | let mut write_guard = data.write(); [INFO] [stdout] 681 | | write_guard.push(index); [INFO] [stdout] 682 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:822:31 [INFO] [stdout] | [INFO] [stdout] 819 | let once = Arc::clone(&once); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 820 | let main_thread = main_thread.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 821 | [INFO] [stdout] 822 | thread::spawn(move || { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 823 | | once.call_once(|| value); [INFO] [stdout] 824 | | main_thread.unpark(); [INFO] [stdout] 825 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spinning` (lib test) due to 6 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:593:19 [INFO] [stdout] | [INFO] [stdout] 591 | pub const fn new(f: F) -> Lazy { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 592 | Lazy { [INFO] [stdout] 593 | once: Once::new(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:594:19 [INFO] [stdout] | [INFO] [stdout] 591 | pub const fn new(f: F) -> Lazy { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 594 | init: Cell::new(Some(f)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:614:38 [INFO] [stdout] | [INFO] [stdout] 614 | this.once.call_once(|| match this.init.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spinning` (lib) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "697de707dbaab8680d81eb0a7b0a97955e076226b5a00af33f69049bbd757761", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "697de707dbaab8680d81eb0a7b0a97955e076226b5a00af33f69049bbd757761", kill_on_drop: false }` [INFO] [stdout] 697de707dbaab8680d81eb0a7b0a97955e076226b5a00af33f69049bbd757761