[INFO] fetching crate spinel 0.1.0... [INFO] checking spinel-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spinel 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate spinel 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spinel 0.1.0 [INFO] finished tweaking crates.io crate spinel 0.1.0 [INFO] tweaked toml for crates.io crate spinel 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae9a4662675af666dc0b91ab3c462155c6d14fd3eed917b1a14379e5a3e8e634 [INFO] running `Command { std: "docker" "start" "-a" "ae9a4662675af666dc0b91ab3c462155c6d14fd3eed917b1a14379e5a3e8e634", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae9a4662675af666dc0b91ab3c462155c6d14fd3eed917b1a14379e5a3e8e634", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae9a4662675af666dc0b91ab3c462155c6d14fd3eed917b1a14379e5a3e8e634", kill_on_drop: false }` [INFO] [stdout] ae9a4662675af666dc0b91ab3c462155c6d14fd3eed917b1a14379e5a3e8e634 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e2934b6b193a08396410e249c4298f19a7b94e35fd7cc39cb44888ba7cfcebc [INFO] running `Command { std: "docker" "start" "-a" "4e2934b6b193a08396410e249c4298f19a7b94e35fd7cc39cb44888ba7cfcebc", kill_on_drop: false }` [INFO] [stderr] Compiling crc16 v0.4.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking spinel v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | #[cfg_attr(feature = "thiserror", derive(thiserror::Error))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | #[cfg_attr(feature = "thiserror", error("Invalid header: {0}"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | #[cfg_attr(feature = "thiserror", error("Incorrect HDLC checksum: {0}"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:9:16 [INFO] [stdout] | [INFO] [stdout] 9 | #[cfg_attr(feature = "thiserror", error("Incorrect starting delimiter: {0}"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | #[cfg_attr(feature = "thiserror", error("Incorrect ending delimiter: {0}"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:13:16 [INFO] [stdout] | [INFO] [stdout] 13 | #[cfg_attr(feature = "thiserror", error("Unknown command: {0}"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:15:16 [INFO] [stdout] | [INFO] [stdout] 15 | #[cfg_attr(feature = "thiserror", error("Unknown property: {0}"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | feature = "thiserror", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `thiserror` [INFO] [stdout] --> src/error.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 22 | #[cfg_attr(feature = "thiserror", error("Incorrect packet length: {0}"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `std` [INFO] [stdout] = help: consider adding `thiserror` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/command.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 118 | fn try_from(cmd: Command) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let id = cmd.id(); [INFO] [stdout] 120 | let mut bytes = BytesMut::with_capacity(PackedU32::packed_len(id)); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | cmd.encode(&mut bytes)?; [INFO] [stdout] 122 | Ok(bytes.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec/frame/hdlc.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 117 | let bytes = bytes.clone().split_off(1); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let mut packet = BytesMut::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let end_frame_data = packet.split_off(pkt_len - 2); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let frozen = packet.freeze(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | let spinel_frame = Frame::decode(&frozen)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | [INFO] [stdout] 161 | Ok(Self { spinel_frame }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spinel` (lib) due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4e2934b6b193a08396410e249c4298f19a7b94e35fd7cc39cb44888ba7cfcebc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e2934b6b193a08396410e249c4298f19a7b94e35fd7cc39cb44888ba7cfcebc", kill_on_drop: false }` [INFO] [stdout] 4e2934b6b193a08396410e249c4298f19a7b94e35fd7cc39cb44888ba7cfcebc