[INFO] fetching crate spatial 1.0.1... [INFO] checking spatial-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spatial 1.0.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate spatial 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spatial 1.0.1 [INFO] finished tweaking crates.io crate spatial 1.0.1 [INFO] tweaked toml for crates.io crate spatial 1.0.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bc2d90d3c898dfd5d1bea1d7e5fb8950eaaa772ada022a71a5b969f33759e47d [INFO] running `Command { std: "docker" "start" "-a" "bc2d90d3c898dfd5d1bea1d7e5fb8950eaaa772ada022a71a5b969f33759e47d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bc2d90d3c898dfd5d1bea1d7e5fb8950eaaa772ada022a71a5b969f33759e47d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc2d90d3c898dfd5d1bea1d7e5fb8950eaaa772ada022a71a5b969f33759e47d", kill_on_drop: false }` [INFO] [stdout] bc2d90d3c898dfd5d1bea1d7e5fb8950eaaa772ada022a71a5b969f33759e47d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7261d2400aea7f2642b469a7298043090a919802881be7cf0fa3ca27078c3473 [INFO] running `Command { std: "docker" "start" "-a" "7261d2400aea7f2642b469a7298043090a919802881be7cf0fa3ca27078c3473", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking spatial v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::tree::xmbr::node::XTreeNode` [INFO] [stdout] --> src/tree/xmbr/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use crate::tree::xmbr::node::XTreeNode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `super_node_size` is never read [INFO] [stdout] --> src/tree/xmbr/node.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 25 | Leaves { [INFO] [stdout] | ------ field in this variant [INFO] [stdout] 26 | mbr: Rect, [INFO] [stdout] 27 | super_node_size: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XTreeNode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Level` is never constructed [INFO] [stdout] --> src/tree/xmbr/node.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub enum XTreeNode { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 16 | /// Contains only other levels [INFO] [stdout] 17 | Level { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XTreeNode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_super` is never used [INFO] [stdout] --> src/tree/xmbr/node.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 32 | / impl XTreeNode [INFO] [stdout] 33 | | where [INFO] [stdout] 34 | | LG: MbrLeafGeometry, [INFO] [stdout] | |________________________________- method in this implementation [INFO] [stdout] 35 | { [INFO] [stdout] 36 | pub fn is_super(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mbr/index/r.rs:63:38 [INFO] [stdout] | [INFO] [stdout] 63 | .max_by_key(|&(j, _, _)| j.try_into().ok().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mbr/index/r.rs:114:47 [INFO] [stdout] | [INFO] [stdout] 114 | .max_by_key(|&(separation, _, _)| separation.try_into().ok().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mbr/index/rstar.rs:182:34 [INFO] [stdout] | [INFO] [stdout] 182 | children.sort_by_key(|a| a.distance_from_mbr_center(mbr).try_into().ok().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mbr/index/rstar.rs:256:46 [INFO] [stdout] | [INFO] [stdout] 256 | children.sort_by_key(|child| child.min_for_axis(axis).try_into().ok().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mbr/index/rstar.rs:258:46 [INFO] [stdout] | [INFO] [stdout] 258 | children.sort_by_key(|child| child.max_for_axis(axis).try_into().ok().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mbr/index/rstar.rs:302:40 [INFO] [stdout] | [INFO] [stdout] 302 | .min_by_key(|&(margin, _)| margin.try_into().ok().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mbr/index/rstar.rs:307:42 [INFO] [stdout] | [INFO] [stdout] 307 | children.sort_by_key(|child| child.min_for_axis(s_axis).try_into().ok().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/mbr/index/rstar.rs:309:42 [INFO] [stdout] | [INFO] [stdout] 309 | children.sort_by_key(|child| child.max_for_axis(s_axis).try_into().ok().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spatial` (lib) due to 9 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7261d2400aea7f2642b469a7298043090a919802881be7cf0fa3ca27078c3473", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7261d2400aea7f2642b469a7298043090a919802881be7cf0fa3ca27078c3473", kill_on_drop: false }` [INFO] [stdout] 7261d2400aea7f2642b469a7298043090a919802881be7cf0fa3ca27078c3473