[INFO] fetching crate spaniel 0.1.0... [INFO] checking spaniel-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spaniel 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate spaniel 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spaniel 0.1.0 [INFO] finished tweaking crates.io crate spaniel 0.1.0 [INFO] tweaked toml for crates.io crate spaniel 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2e44e3c6cf79b0f38a1e456d1655041d02b4a2f4abb6d70ef0df3ca98613968 [INFO] running `Command { std: "docker" "start" "-a" "a2e44e3c6cf79b0f38a1e456d1655041d02b4a2f4abb6d70ef0df3ca98613968", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2e44e3c6cf79b0f38a1e456d1655041d02b4a2f4abb6d70ef0df3ca98613968", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2e44e3c6cf79b0f38a1e456d1655041d02b4a2f4abb6d70ef0df3ca98613968", kill_on_drop: false }` [INFO] [stdout] a2e44e3c6cf79b0f38a1e456d1655041d02b4a2f4abb6d70ef0df3ca98613968 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30c9231ada462088f9ee5dac30afbb8eead720fa5db00f919e99a8105651a90a [INFO] running `Command { std: "docker" "start" "-a" "30c9231ada462088f9ee5dac30afbb8eead720fa5db00f919e99a8105651a90a", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking spaniel v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:127:58 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn buffer_data(&mut self, data: Bytes) -> Result<(usize), WriteError> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 127 - pub fn buffer_data(&mut self, data: Bytes) -> Result<(usize), WriteError> { [INFO] [stdout] 127 + pub fn buffer_data(&mut self, data: Bytes) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:251:60 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn buffer_frame(&mut self, frame: Frame) -> Result<(usize), WriteError> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 251 - pub fn buffer_frame(&mut self, frame: Frame) -> Result<(usize), WriteError> { [INFO] [stdout] 251 + pub fn buffer_frame(&mut self, frame: Frame) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:260:62 [INFO] [stdout] | [INFO] [stdout] 260 | pub fn buffer_and_flush(&mut self, frame: Frame) -> Poll<(usize), WriteError> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 260 - pub fn buffer_and_flush(&mut self, frame: Frame) -> Poll<(usize), WriteError> { [INFO] [stdout] 260 + pub fn buffer_and_flush(&mut self, frame: Frame) -> Poll { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:127:58 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn buffer_data(&mut self, data: Bytes) -> Result<(usize), WriteError> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 127 - pub fn buffer_data(&mut self, data: Bytes) -> Result<(usize), WriteError> { [INFO] [stdout] 127 + pub fn buffer_data(&mut self, data: Bytes) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:251:60 [INFO] [stdout] | [INFO] [stdout] 251 | pub fn buffer_frame(&mut self, frame: Frame) -> Result<(usize), WriteError> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 251 - pub fn buffer_frame(&mut self, frame: Frame) -> Result<(usize), WriteError> { [INFO] [stdout] 251 + pub fn buffer_frame(&mut self, frame: Frame) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/protocol/codec/writer.rs:260:62 [INFO] [stdout] | [INFO] [stdout] 260 | pub fn buffer_and_flush(&mut self, frame: Frame) -> Poll<(usize), WriteError> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 260 - pub fn buffer_and_flush(&mut self, frame: Frame) -> Poll<(usize), WriteError> { [INFO] [stdout] 260 + pub fn buffer_and_flush(&mut self, frame: Frame) -> Poll { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `tokio_io::codec::length_delimited`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::Framed`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:11:47 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::Framed`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | inner: Framed, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::Builder`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:32:38 [INFO] [stdout] | [INFO] [stdout] 32 | inner: length_delimited::Builder::new() [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `tokio_io::codec::length_delimited`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio_io::codec::length_delimited; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::FramedRead`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | src: length_delimited::FramedRead, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::Builder`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | let src = length_delimited::Builder::new() [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `tokio_io::codec::length_delimited`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:11:22 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::Framed`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:11:47 [INFO] [stdout] | [INFO] [stdout] 11 | use tokio_io::codec::length_delimited::{self, Framed}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::Framed`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | inner: Framed, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::Builder`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/mod.rs:32:38 [INFO] [stdout] | [INFO] [stdout] 32 | inner: length_delimited::Builder::new() [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated module `tokio_io::codec::length_delimited`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | use tokio_io::codec::length_delimited; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::FramedRead`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | src: length_delimited::FramedRead, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `tokio_io::length_delimited::Builder`: Moved to tokio-codec [INFO] [stdout] --> src/protocol/codec/reader.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | let src = length_delimited::Builder::new() [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/protocol/codec/writer.rs:60:44 [INFO] [stdout] | [INFO] [stdout] 60 | write!(f, "writer error: {}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/protocol/codec/writer.rs:60:44 [INFO] [stdout] | [INFO] [stdout] 60 | write!(f, "writer error: {}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol/codec/writer.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | let mut buf = self.current.as_mut().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/protocol/frames.rs:305:28 [INFO] [stdout] | [INFO] [stdout] 305 | fn decode_from(src: &mut B) -> Result { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst` [INFO] [stdout] --> src/protocol/frames.rs:309:38 [INFO] [stdout] | [INFO] [stdout] 309 | fn encode_into(&self, dst: &mut B) -> Result<(), ()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dst` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/protocol/codec/writer.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | let mut buf = self.current.as_mut().unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/connection.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 61 | pub struct ConnectionContext { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | id: ConnectionId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `ConnectionContext` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `notify_all` is never used [INFO] [stdout] --> src/connection.rs:195:8 [INFO] [stdout] | [INFO] [stdout] 89 | impl ConnectionContext { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 195 | fn notify_all(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CreditBased` is never constructed [INFO] [stdout] --> src/flow_control.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum FlowControlStrategy { [INFO] [stdout] | ------------------- variant in this enum [INFO] [stdout] 7 | Disabled, [INFO] [stdout] 8 | CreditBased(FlowControlRatio), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FlowControlStrategy` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `push_front` is never used [INFO] [stdout] --> src/protocol/codec/buffer.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl OutboundBuffer { [INFO] [stdout] | ---------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn push_front(&mut self, value: B) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Error` is never constructed [INFO] [stdout] --> src/protocol/codec/writer.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 71 | pub enum WriteState { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 72 | Error, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_watermarks` and `write_and_flush` are never used [INFO] [stdout] --> src/protocol/codec/writer.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 106 | impl Writer { [INFO] [stdout] | ----------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 119 | pub fn set_watermarks(&mut self, high: usize, low: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 220 | pub fn write_and_flush(&mut self, data: Bytes) -> Poll<(), std::io::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:96:24 [INFO] [stdout] | [INFO] [stdout] 91 | let (tx, rx) = mpsc::channel(1024); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | conn_task: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:97:30 [INFO] [stdout] | [INFO] [stdout] 91 | let (tx, rx) = mpsc::channel(1024); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | new_stream_task: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 91 | let (tx, rx) = mpsc::channel(1024); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | stream_states: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:99:29 [INFO] [stdout] | [INFO] [stdout] 91 | let (tx, rx) = mpsc::channel(1024); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | stream_senders: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 132 | let (tx, rx) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let state = StreamState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(AsyncHandle::Ready) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 156 | fn on_data(&mut self, data: frames::Data) -> Result, ConnectionError> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(AsyncHandle::Ready) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:301:17 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn new(rx: I, tx: O) -> Self { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | IoHandle { [INFO] [stdout] 301 | rx: FrameReader::new(rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:302:17 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn new(rx: I, tx: O) -> Self { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | tx: Arc::new(Mutex::new(FrameWriter::new(tx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:324:27 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn with_io(reader: I, writer: O, id: u32) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let ctx = ConnectionContext::new(id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let ctx = Arc::new(Mutex::new(ctx)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let handle = IoHandle::new(reader, writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | head_of_line: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/mod.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(conn: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self { [INFO] [stdout] 32 | inner: length_delimited::Builder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 33 | | .big_endian() [INFO] [stdout] 34 | | .length_adjustment(-4) [INFO] [stdout] 35 | | .length_field_offset(0) [INFO] [stdout] 36 | | .length_field_length(4) [INFO] [stdout] 37 | | .max_frame_length(::std::u32::MAX as usize) [INFO] [stdout] 38 | | .new_framed(conn), [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/mod.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 51 | let frame = match try_ready!(self.inner.poll().map_err(|_err| { [INFO] [stdout] | _____________-----_________- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | // TODO err [INFO] [stdout] 53 | | () [INFO] [stdout] 54 | | })) { [INFO] [stdout] | |___________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Some(buf) => Some(Frame::decode_from(buf).expect("deserialization")), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Async::Ready(frame)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/writer.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(dst: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | buffer: OutboundBuffer::with_capacity(INIT_BUF_CAPACITY), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/writer.rs:111:22 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(dst: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | current: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/writer.rs:114:27 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(dst: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | waiting_task: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/writer.rs:239:21 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn new(dst: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | FrameWriter { [INFO] [stdout] 239 | writer: Writer::new(dst), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/frames.rs:285:12 [INFO] [stdout] | [INFO] [stdout] 279 | let payload = src.collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | let data_frame = Data { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | Ok(Frame::Data(data_frame)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 161 | let mut ctx = self.ctx.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let stream = StreamRef { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Ok(Async::Ready(Some(stream))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 188 | let mut ctx = self.ctx.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | me.data.poll().map_err(|why| { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 234 | let stream = StreamRef { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok(Async::Ready(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `src` [INFO] [stdout] --> src/protocol/frames.rs:305:28 [INFO] [stdout] | [INFO] [stdout] 305 | fn decode_from(src: &mut B) -> Result { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_src` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `dst` [INFO] [stdout] --> src/protocol/frames.rs:309:38 [INFO] [stdout] | [INFO] [stdout] 309 | fn encode_into(&self, dst: &mut B) -> Result<(), ()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_dst` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spaniel` (lib) due to 20 previous errors; 20 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/connection.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 61 | pub struct ConnectionContext { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | id: ConnectionId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `ConnectionContext` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `notify_all` is never used [INFO] [stdout] --> src/connection.rs:195:8 [INFO] [stdout] | [INFO] [stdout] 89 | impl ConnectionContext { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 195 | fn notify_all(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CreditBased` is never constructed [INFO] [stdout] --> src/flow_control.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum FlowControlStrategy { [INFO] [stdout] | ------------------- variant in this enum [INFO] [stdout] 7 | Disabled, [INFO] [stdout] 8 | CreditBased(FlowControlRatio), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FlowControlStrategy` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `push_front` is never used [INFO] [stdout] --> src/protocol/codec/buffer.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl OutboundBuffer { [INFO] [stdout] | ---------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn push_front(&mut self, value: B) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Error` is never constructed [INFO] [stdout] --> src/protocol/codec/writer.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 71 | pub enum WriteState { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 72 | Error, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `set_watermarks` and `write_and_flush` are never used [INFO] [stdout] --> src/protocol/codec/writer.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 106 | impl Writer { [INFO] [stdout] | ----------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 119 | pub fn set_watermarks(&mut self, high: usize, low: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 220 | pub fn write_and_flush(&mut self, data: Bytes) -> Poll<(), std::io::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:96:24 [INFO] [stdout] | [INFO] [stdout] 91 | let (tx, rx) = mpsc::channel(1024); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | conn_task: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:97:30 [INFO] [stdout] | [INFO] [stdout] 91 | let (tx, rx) = mpsc::channel(1024); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | new_stream_task: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 91 | let (tx, rx) = mpsc::channel(1024); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | stream_states: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:99:29 [INFO] [stdout] | [INFO] [stdout] 91 | let (tx, rx) = mpsc::channel(1024); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | stream_senders: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 132 | let (tx, rx) = mpsc::channel(1); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let state = StreamState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(AsyncHandle::Ready) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 156 | fn on_data(&mut self, data: frames::Data) -> Result, ConnectionError> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(AsyncHandle::Ready) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:301:17 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn new(rx: I, tx: O) -> Self { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 300 | IoHandle { [INFO] [stdout] 301 | rx: FrameReader::new(rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:302:17 [INFO] [stdout] | [INFO] [stdout] 299 | pub fn new(rx: I, tx: O) -> Self { [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | tx: Arc::new(Mutex::new(FrameWriter::new(tx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:324:27 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn with_io(reader: I, writer: O, id: u32) -> Self { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let ctx = ConnectionContext::new(id); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let ctx = Arc::new(Mutex::new(ctx)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | let handle = IoHandle::new(reader, writer); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | head_of_line: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/mod.rs:32:20 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(conn: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self { [INFO] [stdout] 32 | inner: length_delimited::Builder::new() [INFO] [stdout] | ____________________^ [INFO] [stdout] 33 | | .big_endian() [INFO] [stdout] 34 | | .length_adjustment(-4) [INFO] [stdout] 35 | | .length_field_offset(0) [INFO] [stdout] 36 | | .length_field_length(4) [INFO] [stdout] 37 | | .max_frame_length(::std::u32::MAX as usize) [INFO] [stdout] 38 | | .new_framed(conn), [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/mod.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 51 | let frame = match try_ready!(self.inner.poll().map_err(|_err| { [INFO] [stdout] | _____________-----_________- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | | // TODO err [INFO] [stdout] 53 | | () [INFO] [stdout] 54 | | })) { [INFO] [stdout] | |___________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Some(buf) => Some(Frame::decode_from(buf).expect("deserialization")), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Async::Ready(frame)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/writer.rs:110:21 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(dst: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | buffer: OutboundBuffer::with_capacity(INIT_BUF_CAPACITY), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/writer.rs:111:22 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(dst: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | current: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/writer.rs:114:27 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new(dst: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | waiting_task: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/codec/writer.rs:239:21 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn new(dst: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | FrameWriter { [INFO] [stdout] 239 | writer: Writer::new(dst), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/frames.rs:285:12 [INFO] [stdout] | [INFO] [stdout] 279 | let payload = src.collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | let data_frame = Data { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 285 | Ok(Frame::Data(data_frame)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 161 | let mut ctx = self.ctx.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let stream = StreamRef { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Ok(Async::Ready(Some(stream))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 188 | let mut ctx = self.ctx.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | me.data.poll().map_err(|why| { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 234 | let stream = StreamRef { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | Ok(Async::Ready(stream)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spaniel` (lib test) due to 20 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "30c9231ada462088f9ee5dac30afbb8eead720fa5db00f919e99a8105651a90a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30c9231ada462088f9ee5dac30afbb8eead720fa5db00f919e99a8105651a90a", kill_on_drop: false }` [INFO] [stdout] 30c9231ada462088f9ee5dac30afbb8eead720fa5db00f919e99a8105651a90a