[INFO] fetching crate spacetimedb-durability 0.11.0... [INFO] checking spacetimedb-durability-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spacetimedb-durability 0.11.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate spacetimedb-durability 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spacetimedb-durability 0.11.0 [INFO] finished tweaking crates.io crate spacetimedb-durability 0.11.0 [INFO] tweaked toml for crates.io crate spacetimedb-durability 0.11.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 84 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5a63242f466918e1bd790bfcb39957efaf2c5cddbe6f5360f9a7c6cd07f3433 [INFO] running `Command { std: "docker" "start" "-a" "f5a63242f466918e1bd790bfcb39957efaf2c5cddbe6f5360f9a7c6cd07f3433", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5a63242f466918e1bd790bfcb39957efaf2c5cddbe6f5360f9a7c6cd07f3433", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5a63242f466918e1bd790bfcb39957efaf2c5cddbe6f5360f9a7c6cd07f3433", kill_on_drop: false }` [INFO] [stdout] f5a63242f466918e1bd790bfcb39957efaf2c5cddbe6f5360f9a7c6cd07f3433 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4e5e88aa9e6c9593b079449b34dacdfe259f297226f9c720447ddfa07f8264d [INFO] running `Command { std: "docker" "start" "-a" "a4e5e88aa9e6c9593b079449b34dacdfe259f297226f9c720447ddfa07f8264d", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling nohash-hasher v0.2.0 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling spacetimedb-primitives v0.11.0 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking second-stack v0.3.5 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking decorum v0.3.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling spacetimedb-bindings-macro v0.11.0 [INFO] [stderr] Compiling enum-as-inner v0.6.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking spacetimedb-sats v0.11.0 [INFO] [stderr] Checking spacetimedb-commitlog v0.11.0 [INFO] [stderr] Checking spacetimedb-durability v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/imp/local.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn open(root: impl Into, rt: tokio::runtime::Handle, opts: Options) -> io::Result { [INFO] [stdout] | ------------------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let clog = Arc::new(Commitlog::open(root, opts.commitlog)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let (queue, rx) = mpsc::unbounded_channel(); [INFO] [stdout] | ----- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let queue_depth = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let offset = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let persister_task = rt.spawn( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | clog, [INFO] [stdout] 128 | | durable_offset: offset, [INFO] [stdout] 129 | | queue, [INFO] [stdout] 130 | | queue_depth, [INFO] [stdout] 131 | | persister_task, [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spacetimedb-durability` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/imp/local.rs:126:12 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn open(root: impl Into, rt: tokio::runtime::Handle, opts: Options) -> io::Result { [INFO] [stdout] | ------------------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let clog = Arc::new(Commitlog::open(root, opts.commitlog)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let (queue, rx) = mpsc::unbounded_channel(); [INFO] [stdout] | ----- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let queue_depth = Arc::new(AtomicU64::new(0)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let offset = { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let persister_task = rt.spawn( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 127 | | clog, [INFO] [stdout] 128 | | durable_offset: offset, [INFO] [stdout] 129 | | queue, [INFO] [stdout] 130 | | queue_depth, [INFO] [stdout] 131 | | persister_task, [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spacetimedb-durability` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "a4e5e88aa9e6c9593b079449b34dacdfe259f297226f9c720447ddfa07f8264d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4e5e88aa9e6c9593b079449b34dacdfe259f297226f9c720447ddfa07f8264d", kill_on_drop: false }` [INFO] [stdout] a4e5e88aa9e6c9593b079449b34dacdfe259f297226f9c720447ddfa07f8264d