[INFO] fetching crate spacetimedb-commitlog 0.11.0... [INFO] checking spacetimedb-commitlog-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate spacetimedb-commitlog 0.11.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate spacetimedb-commitlog 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate spacetimedb-commitlog 0.11.0 [INFO] finished tweaking crates.io crate spacetimedb-commitlog 0.11.0 [INFO] tweaked toml for crates.io crate spacetimedb-commitlog 0.11.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 94 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding proptest-derive v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea577d11107da8df04f1276943a0a1a13a906899b1973e703f2c130def69297b [INFO] running `Command { std: "docker" "start" "-a" "ea577d11107da8df04f1276943a0a1a13a906899b1973e703f2c130def69297b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea577d11107da8df04f1276943a0a1a13a906899b1973e703f2c130def69297b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea577d11107da8df04f1276943a0a1a13a906899b1973e703f2c130def69297b", kill_on_drop: false }` [INFO] [stdout] ea577d11107da8df04f1276943a0a1a13a906899b1973e703f2c130def69297b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54281a08b9d83be9d6b2d806b6f2d88a6407bd2cd3192d25ab14eca534d433ba [INFO] running `Command { std: "docker" "start" "-a" "54281a08b9d83be9d6b2d806b6f2d88a6407bd2cd3192d25ab14eca534d433ba", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling nohash-hasher v0.2.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Compiling spacetimedb-primitives v0.11.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Compiling enum-as-inner v0.6.0 [INFO] [stderr] Compiling spacetimedb-bindings-macro v0.11.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking decorum v0.3.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking second-stack v0.3.5 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking spacetimedb-sats v0.11.0 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking spacetimedb-commitlog v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn open(root: impl Into, opts: Options) -> io::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | let inner = commitlog::Generic::open(repo::Fs::new(root), opts)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | [INFO] [stdout] 82 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | inner: RwLock::new(inner), [INFO] [stdout] 84 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 198 | pub fn reset(self) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let inner = self.inner.into_inner().unwrap().reset()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | inner: RwLock::new(inner), [INFO] [stdout] 202 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 216 | pub fn reset_to(self, offset: u64) -> io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | let inner = self.inner.into_inner().unwrap().reset_to(offset)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 219 | | inner: RwLock::new(inner), [INFO] [stdout] 220 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:367:9 [INFO] [stdout] | [INFO] [stdout] 362 | pub fn fold_transactions_from(&self, offset: u64, de: D) -> Result<(), D::Error> [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 367 | self.inner.read().unwrap().fold_transactions_from(offset, de) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commit.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn extract(reader: R) -> io::Result> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | Commit::decode(reader).map(|maybe_commit| maybe_commit.map(Self::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn open(repo: R, opts: Options) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let head = if let Some(last) = tail.pop() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | repo, [INFO] [stdout] 65 | | head, [INFO] [stdout] 66 | | tail, [INFO] [stdout] ... | [INFO] [stdout] 69 | | panicked: false, [INFO] [stdout] 70 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:179:20 [INFO] [stdout] | [INFO] [stdout] 173 | let segments = Segments { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | inner: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:182:25 [INFO] [stdout] | [INFO] [stdout] 173 | let segments = Segments { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | last_error: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:198:20 [INFO] [stdout] | [INFO] [stdout] 186 | pub fn reset(mut self) -> io::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Self::open(self.repo.clone(), self.opts) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:243:20 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn reset_to(mut self, offset: u64) -> io::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | Self::open(self.repo.clone(), self.opts) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:291:36 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn fold_transactions_from(&self, offset: u64, decoder: D) -> Result<(), D::Error> [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | fold_transactions_internal(self.commits_from(offset).with_log_format_version(), decoder, offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:316:8 [INFO] [stdout] | [INFO] [stdout] 305 | pub fn commits_from(repo: R, max_log_format_version: u8, offset: u64) -> io::Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | let segments = Segments { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Ok(Commits { [INFO] [stdout] | ________^ [INFO] [stdout] 317 | | inner: None, [INFO] [stdout] 318 | | segments, [INFO] [stdout] 319 | | last_commit: CommitInfo::Initial { next_offset }, [INFO] [stdout] 320 | | last_error: None, [INFO] [stdout] 321 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 325 | repo: R, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | commits_from(repo, max_log_format_version, offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:337:51 [INFO] [stdout] | [INFO] [stdout] 337 | .map(|commits| transactions_from_internal(commits.with_log_format_version(), offset, de)) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:347:32 [INFO] [stdout] | [INFO] [stdout] 340 | pub fn fold_transactions_from(repo: R, max_log_format_version: u8, offset: u64, de: D) -> Result<(), D::Error> [INFO] [stdout] | ------- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | let commits = commits_from(repo, max_log_format_version, offset)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | fold_transactions_internal(commits.with_log_format_version(), de, offset) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 351 | commits: CommitsWithVersion, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | / commits [INFO] [stdout] 362 | | .map(|x| x.map_err(Into::into)) [INFO] [stdout] 363 | | .map_ok(move |(version, commit)| commit.into_transactions(version, de)) [INFO] [stdout] 364 | | .flatten_ok() [INFO] [stdout] 365 | | .flatten_ok() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:544:37 [INFO] [stdout] | [INFO] [stdout] 544 | .unwrap_or_else(|e| io::Error::new(io::ErrorKind::InvalidData, e).into()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commitlog.rs:581:26 [INFO] [stdout] | [INFO] [stdout] 581 | |e| Some(Err(e.into())), [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/mod.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 65 | let mut storage = repo.create_segment(offset)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(Writer { [INFO] [stdout] | ________^ [INFO] [stdout] 74 | | commit: Commit { [INFO] [stdout] 75 | | min_tx_offset: offset, [INFO] [stdout] 76 | | n: 0, [INFO] [stdout] ... | [INFO] [stdout] 84 | | max_records_in_commit: opts.max_records_in_commit, [INFO] [stdout] 85 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo/mod.rs:126:8 [INFO] [stdout] | [INFO] [stdout] 108 | let mut storage = repo.open_segment(offset)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | Err(error::SegmentMetadata::InvalidCommit { sofar, source }) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Err(error::SegmentMetadata::Io(e)) => return Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Ok(Ok(Writer { [INFO] [stdout] | ________^ [INFO] [stdout] 127 | | commit: Commit { [INFO] [stdout] 128 | | min_tx_offset: tx_range.end, [INFO] [stdout] 129 | | n: 0, [INFO] [stdout] ... | [INFO] [stdout] 137 | | max_records_in_commit: opts.max_records_in_commit, [INFO] [stdout] 138 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn new(max_log_format_version: u8, min_tx_offset: u64, mut inner: R) -> io::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 201 | | header, [INFO] [stdout] 202 | | min_tx_offset, [INFO] [stdout] 203 | | inner, [INFO] [stdout] 204 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/segment.rs:212:21 [INFO] [stdout] | [INFO] [stdout] 209 | pub fn commits(self) -> Commits { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | reader: io::BufReader::new(self.inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payload/txdata.rs:174:12 [INFO] [stdout] | [INFO] [stdout] 149 | let inputs = flags [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let outputs = flags [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | let mutations = flags [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 175 | | inputs, [INFO] [stdout] 176 | | outputs, [INFO] [stdout] 177 | | mutations, [INFO] [stdout] 178 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payload/txdata.rs:284:12 [INFO] [stdout] | [INFO] [stdout] 276 | let reducer_name = { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | let reducer_args = reader.get_slice(len as usize - /* slen */ 1 - slen as usize)?.into(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | [INFO] [stdout] 284 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 285 | | reducer_name, [INFO] [stdout] 286 | | reducer_args, [INFO] [stdout] 287 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payload/txdata.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 311 | let reducer_output = { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Ok(Self { reducer_output }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/payload/txdata.rs:447:12 [INFO] [stdout] | [INFO] [stdout] 404 | let mut inserts = Vec::with_capacity(n); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | let mut deletes = Vec::with_capacity(n); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 448 | | inserts: inserts.into(), [INFO] [stdout] 449 | | deletes: deletes.into(), [INFO] [stdout] 450 | | truncates: truncates.into(), [INFO] [stdout] 451 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 26 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spacetimedb-commitlog` (lib) due to 27 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "54281a08b9d83be9d6b2d806b6f2d88a6407bd2cd3192d25ab14eca534d433ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54281a08b9d83be9d6b2d806b6f2d88a6407bd2cd3192d25ab14eca534d433ba", kill_on_drop: false }` [INFO] [stdout] 54281a08b9d83be9d6b2d806b6f2d88a6407bd2cd3192d25ab14eca534d433ba