[INFO] fetching crate soyal_client 0.1.8... [INFO] checking soyal_client-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate soyal_client 0.1.8 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate soyal_client 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate soyal_client 0.1.8 [INFO] finished tweaking crates.io crate soyal_client 0.1.8 [INFO] tweaked toml for crates.io crate soyal_client 0.1.8 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4362dc940e2371a39d23162f182a721cd2a597da0e69e2f358e4cf19ca452487 [INFO] running `Command { std: "docker" "start" "-a" "4362dc940e2371a39d23162f182a721cd2a597da0e69e2f358e4cf19ca452487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4362dc940e2371a39d23162f182a721cd2a597da0e69e2f358e4cf19ca452487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4362dc940e2371a39d23162f182a721cd2a597da0e69e2f358e4cf19ca452487", kill_on_drop: false }` [INFO] [stdout] 4362dc940e2371a39d23162f182a721cd2a597da0e69e2f358e4cf19ca452487 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 770d50f6d21280f19c53371823c37bf217ad936aa34ffa3596a75130ee380dcf [INFO] running `Command { std: "docker" "start" "-a" "770d50f6d21280f19c53371823c37bf217ad936aa34ffa3596a75130ee380dcf", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking macaddr v1.0.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking soyal_client v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:570:12 [INFO] [stdout] | [INFO] [stdout] 560 | let firmware_version = semver::Version::new(firmware_major as u64, firmware_minor as u64, 0); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | Ok(RelayStatusResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 571 | | destination_id: parts.destination_id, [INFO] [stdout] 572 | | command: parts.command, [INFO] [stdout] 573 | | source, [INFO] [stdout] ... | [INFO] [stdout] 580 | | wiegand_port_arming, [INFO] [stdout] 581 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:601:12 [INFO] [stdout] | [INFO] [stdout] 599 | let clock = ClockData::decode(&data[1..])?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 600 | [INFO] [stdout] 601 | Ok(RealTimeClockResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 602 | | destination_id: parts.destination_id, [INFO] [stdout] 603 | | command: parts.command, [INFO] [stdout] 604 | | source, [INFO] [stdout] 605 | | clock, [INFO] [stdout] 606 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structs.rs:999:12 [INFO] [stdout] | [INFO] [stdout] 994 | let firmware_version = semver::Version::new(firmware_major as u64, firmware_minor as u64, 0); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 999 | Ok(ClockData { [INFO] [stdout] | ____________^ [INFO] [stdout] 1000 | | time, [INFO] [stdout] 1001 | | firmware_version, [INFO] [stdout] 1002 | | firmware_identify_code, [INFO] [stdout] 1003 | | controller_type, [INFO] [stdout] 1004 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `soyal_client` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:570:12 [INFO] [stdout] | [INFO] [stdout] 560 | let firmware_version = semver::Version::new(firmware_major as u64, firmware_minor as u64, 0); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 570 | Ok(RelayStatusResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 571 | | destination_id: parts.destination_id, [INFO] [stdout] 572 | | command: parts.command, [INFO] [stdout] 573 | | source, [INFO] [stdout] ... | [INFO] [stdout] 580 | | wiegand_port_arming, [INFO] [stdout] 581 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response.rs:601:12 [INFO] [stdout] | [INFO] [stdout] 599 | let clock = ClockData::decode(&data[1..])?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 600 | [INFO] [stdout] 601 | Ok(RealTimeClockResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 602 | | destination_id: parts.destination_id, [INFO] [stdout] 603 | | command: parts.command, [INFO] [stdout] 604 | | source, [INFO] [stdout] 605 | | clock, [INFO] [stdout] 606 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/structs.rs:999:12 [INFO] [stdout] | [INFO] [stdout] 994 | let firmware_version = semver::Version::new(firmware_major as u64, firmware_minor as u64, 0); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 999 | Ok(ClockData { [INFO] [stdout] | ____________^ [INFO] [stdout] 1000 | | time, [INFO] [stdout] 1001 | | firmware_version, [INFO] [stdout] 1002 | | firmware_identify_code, [INFO] [stdout] 1003 | | controller_type, [INFO] [stdout] 1004 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `soyal_client` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "770d50f6d21280f19c53371823c37bf217ad936aa34ffa3596a75130ee380dcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "770d50f6d21280f19c53371823c37bf217ad936aa34ffa3596a75130ee380dcf", kill_on_drop: false }` [INFO] [stdout] 770d50f6d21280f19c53371823c37bf217ad936aa34ffa3596a75130ee380dcf