[INFO] fetching crate sounding-analysis 0.17.3... [INFO] checking sounding-analysis-0.17.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sounding-analysis 0.17.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sounding-analysis 0.17.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sounding-analysis 0.17.3 [INFO] finished tweaking crates.io crate sounding-analysis 0.17.3 [INFO] tweaked toml for crates.io crate sounding-analysis 0.17.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 87 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding strum v0.20.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.20.1 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29aa33ee399b4d0effb4e6acdd65f267a70a36d4e31f40a4d3b56b6c7f41e1fc [INFO] running `Command { std: "docker" "start" "-a" "29aa33ee399b4d0effb4e6acdd65f267a70a36d4e31f40a4d3b56b6c7f41e1fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29aa33ee399b4d0effb4e6acdd65f267a70a36d4e31f40a4d3b56b6c7f41e1fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29aa33ee399b4d0effb4e6acdd65f267a70a36d4e31f40a4d3b56b6c7f41e1fc", kill_on_drop: false }` [INFO] [stdout] 29aa33ee399b4d0effb4e6acdd65f267a70a36d4e31f40a4d3b56b6c7f41e1fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43bf391cf8bf14b2ade066954e2d92ac7e567b9e110a6025203c8706abbef27a [INFO] running `Command { std: "docker" "start" "-a" "43bf391cf8bf14b2ade066954e2d92ac7e567b9e110a6025203c8706abbef27a", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking optional v0.5.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking strum v0.20.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking metfor v0.9.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Compiling strum_macros v0.20.1 [INFO] [stderr] Checking sounding-analysis v0.17.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/experimental/fire.rs:115:8 [INFO] [stdout] | [INFO] [stdout] 112 | let (_starting_parcel, parcels_iter) = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(parcels_iter [INFO] [stdout] | ________^ [INFO] [stdout] 116 | | .filter_map(|(_, pcl)| analyze_plume_parcel(pcl, snd).ok()) [INFO] [stdout] 117 | | .skip_while(|anal| anal.el_height.is_none()) [INFO] [stdout] 118 | | .take_while(|anal| anal.el_height.is_some()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/experimental/fire.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 133 | let (starting_parcel, parcel_iter) = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let anal_iter = parcel_iter [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok((starting_parcel, anal_iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/experimental/fire.rs:674:8 [INFO] [stdout] | [INFO] [stdout] 542 | let parcel_calc_t = create_parcel_calc_t(parcel, pcl_lcl)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 543 | let level_type_mapping = create_level_type_mapping(pcl_lcl); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | let iter = izip!(snd_pressure, hgt, env_t, env_dp) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 674 | Ok((parcel, iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 165 | fn lapse_rate(snd: &Sounding, v_profile: I) -> Vec> [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | / izip!(z_profile, v_profile) [INFO] [stdout] 174 | | .scan((None, None), |prev_pair, (&z, v)| { [INFO] [stdout] 175 | | let &mut (ref mut prev_z, ref mut prev_v) = prev_pair; [INFO] [stdout] ... | [INFO] [stdout] 193 | | Some(lapse_rate) [INFO] [stdout] 194 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sounding-analysis` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/experimental/fire.rs:115:8 [INFO] [stdout] | [INFO] [stdout] 112 | let (_starting_parcel, parcels_iter) = [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(parcels_iter [INFO] [stdout] | ________^ [INFO] [stdout] 116 | | .filter_map(|(_, pcl)| analyze_plume_parcel(pcl, snd).ok()) [INFO] [stdout] 117 | | .skip_while(|anal| anal.el_height.is_none()) [INFO] [stdout] 118 | | .take_while(|anal| anal.el_height.is_some()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/experimental/fire.rs:172:8 [INFO] [stdout] | [INFO] [stdout] 133 | let (starting_parcel, parcel_iter) = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let anal_iter = parcel_iter [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok((starting_parcel, anal_iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/experimental/fire.rs:674:8 [INFO] [stdout] | [INFO] [stdout] 542 | let parcel_calc_t = create_parcel_calc_t(parcel, pcl_lcl)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 543 | let level_type_mapping = create_level_type_mapping(pcl_lcl); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | let iter = izip!(snd_pressure, hgt, env_t, env_dp) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 674 | Ok((parcel, iter)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/profile.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 165 | fn lapse_rate(snd: &Sounding, v_profile: I) -> Vec> [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | / izip!(z_profile, v_profile) [INFO] [stdout] 174 | | .scan((None, None), |prev_pair, (&z, v)| { [INFO] [stdout] 175 | | let &mut (ref mut prev_z, ref mut prev_v) = prev_pair; [INFO] [stdout] ... | [INFO] [stdout] 193 | | Some(lapse_rate) [INFO] [stdout] 194 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sounding-analysis` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "43bf391cf8bf14b2ade066954e2d92ac7e567b9e110a6025203c8706abbef27a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43bf391cf8bf14b2ade066954e2d92ac7e567b9e110a6025203c8706abbef27a", kill_on_drop: false }` [INFO] [stdout] 43bf391cf8bf14b2ade066954e2d92ac7e567b9e110a6025203c8706abbef27a