[INFO] fetching crate soralog 0.1.1... [INFO] checking soralog-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate soralog 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate soralog 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate soralog 0.1.1 [INFO] finished tweaking crates.io crate soralog 0.1.1 [INFO] tweaked toml for crates.io crate soralog 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate soralog 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c92fc2f5f93f26b5b8f516a32c3789e94bc28964b4d19d4239a92c60b34bd497 [INFO] running `Command { std: "docker" "start" "-a" "c92fc2f5f93f26b5b8f516a32c3789e94bc28964b4d19d4239a92c60b34bd497", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c92fc2f5f93f26b5b8f516a32c3789e94bc28964b4d19d4239a92c60b34bd497", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c92fc2f5f93f26b5b8f516a32c3789e94bc28964b4d19d4239a92c60b34bd497", kill_on_drop: false }` [INFO] [stdout] c92fc2f5f93f26b5b8f516a32c3789e94bc28964b4d19d4239a92c60b34bd497 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d79431f540edbe5d257b73f038a06ebd48b8e7a7ceda110e34e556f34407cd8c [INFO] running `Command { std: "docker" "start" "-a" "d79431f540edbe5d257b73f038a06ebd48b8e7a7ceda110e34e556f34407cd8c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking orfail v1.1.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking soralog v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: can't reference `Self` constructor from outer item [INFO] [stdout] --> src/message.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 8 | impl Message { [INFO] [stdout] | ------------ the inner item doesn't inherit generics from this impl, so `Self` is invalid to reference [INFO] [stdout] ... [INFO] [stdout] 76 | Self(message) [INFO] [stdout] | ^^^^ help: replace `Self` with the actual type: `Message` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #124186 [INFO] [stdout] = note: `#[warn(self_constructor_from_outer_item)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can't reference `Self` constructor from outer item [INFO] [stdout] --> src/message.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 8 | impl Message { [INFO] [stdout] | ------------ the inner item doesn't inherit generics from this impl, so `Self` is invalid to reference [INFO] [stdout] ... [INFO] [stdout] 76 | Self(message) [INFO] [stdout] | ^^^^ help: replace `Self` with the actual type: `Message` [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #124186 [INFO] [stdout] = note: `#[warn(self_constructor_from_outer_item)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command_cat.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 73 | .map(move |result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | / result [INFO] [stdout] 75 | | .or_fail_with(|e| format!("Failed to read JSON from {:?}: {}", path.display(), e)) [INFO] [stdout] | |__________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_stream.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | let stdin = stdin.lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | / serde_json::Deserializer::from_reader(stdin) [INFO] [stdout] 11 | | .into_iter::() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_stream.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn output_item_pp(item: T) -> orfail::Result<()> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | output_items_pp(std::iter::once(Ok(item))).or_fail() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `soralog` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command_cat.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 73 | .map(move |result| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | / result [INFO] [stdout] 75 | | .or_fail_with(|e| format!("Failed to read JSON from {:?}: {}", path.display(), e)) [INFO] [stdout] | |__________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_stream.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | let stdin = stdin.lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | / serde_json::Deserializer::from_reader(stdin) [INFO] [stdout] 11 | | .into_iter::() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_stream.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn output_item_pp(item: T) -> orfail::Result<()> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | output_items_pp(std::iter::once(Ok(item))).or_fail() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `soralog` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d79431f540edbe5d257b73f038a06ebd48b8e7a7ceda110e34e556f34407cd8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d79431f540edbe5d257b73f038a06ebd48b8e7a7ceda110e34e556f34407cd8c", kill_on_drop: false }` [INFO] [stdout] d79431f540edbe5d257b73f038a06ebd48b8e7a7ceda110e34e556f34407cd8c