[INFO] fetching crate sonic_client 0.1.2... [INFO] checking sonic_client-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sonic_client 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate sonic_client 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sonic_client 0.1.2 [INFO] finished tweaking crates.io crate sonic_client 0.1.2 [INFO] tweaked toml for crates.io crate sonic_client 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 35e341d111ee57fd984dfca56e695f769f39dc00bd7c6a0aa6ed96e19f8d79f2 [INFO] running `Command { std: "docker" "start" "-a" "35e341d111ee57fd984dfca56e695f769f39dc00bd7c6a0aa6ed96e19f8d79f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "35e341d111ee57fd984dfca56e695f769f39dc00bd7c6a0aa6ed96e19f8d79f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "35e341d111ee57fd984dfca56e695f769f39dc00bd7c6a0aa6ed96e19f8d79f2", kill_on_drop: false }` [INFO] [stdout] 35e341d111ee57fd984dfca56e695f769f39dc00bd7c6a0aa6ed96e19f8d79f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06a85a44f814ae80e3b8b85bb21c01e0e2955c1495ec28c93e241e5119e50578 [INFO] running `Command { std: "docker" "start" "-a" "06a85a44f814ae80e3b8b85bb21c01e0e2955c1495ec28c93e241e5119e50578", kill_on_drop: false }` [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking sonic_client v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/control.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sync_channel` [INFO] [stdout] --> src/control.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::mpsc::{sync_channel, Receiver, SyncSender}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/ingest.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sync_channel` [INFO] [stdout] --> src/ingest.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::mpsc::{sync_channel, Receiver, SyncSender}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/control.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sync_channel` [INFO] [stdout] --> src/control.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::mpsc::{sync_channel, Receiver, SyncSender}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/control.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/control.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/ingest.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sync_channel` [INFO] [stdout] --> src/ingest.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::mpsc::{sync_channel, Receiver, SyncSender}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/ingest.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 218 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/ingest.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/search.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/search.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `host` and `port` are never read [INFO] [stdout] --> src/control.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct ControlChan { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 12 | host: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | port: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `host` and `port` are never read [INFO] [stdout] --> src/ingest.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct IngestChan { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 12 | host: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | port: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `host` and `port` are never read [INFO] [stdout] --> src/search.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct SearchChan { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 29 | host: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 30 | port: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/control.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 29 | host: host.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/control.rs:31:31 [INFO] [stdout] | [INFO] [stdout] 31 | password: password.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/control.rs:55:23 [INFO] [stdout] | [INFO] [stdout] 53 | let conn = self.conn.try_clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let tasks = Arc::clone(&self.tasks); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 56 | | let poll = mio::Poll::new().unwrap(); [INFO] [stdout] 57 | | poll.register(&conn, CLIENT, Ready::readable(), PollOpt::edge()) [INFO] [stdout] 58 | | .unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/control.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 113 | let (task, (sender, receiver)) = Task::new(msg.clone()); [INFO] [stdout] | ---- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let conn = self.conn.try_clone()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut writer = BufWriter::new(conn); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | writer.write_all(msg.as_bytes())?; [INFO] [stdout] 121 | Ok((sender.clone(), receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ingest.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 29 | host: host.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ingest.rs:31:31 [INFO] [stdout] | [INFO] [stdout] 31 | password: password.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ingest.rs:55:23 [INFO] [stdout] | [INFO] [stdout] 53 | let conn = self.conn.try_clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let tasks = Arc::clone(&self.tasks); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 56 | | let poll = mio::Poll::new().unwrap(); [INFO] [stdout] 57 | | poll.register(&conn, CLIENT, Ready::readable(), PollOpt::edge()) [INFO] [stdout] 58 | | .unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ingest.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 113 | let (task, (sender, receiver)) = Task::new(msg.clone()); [INFO] [stdout] | ---- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let conn = self.conn.try_clone()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut writer = BufWriter::new(conn); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | writer.write_all(msg.as_bytes())?; [INFO] [stdout] 121 | Ok((sender.clone(), receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 17 | let (sender, receiver) = sync_channel::(2); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ( [INFO] [stdout] 19 | / Task { [INFO] [stdout] 20 | | msg: msg, [INFO] [stdout] 21 | | sender: sender.clone(), [INFO] [stdout] 22 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 17 | let (sender, receiver) = sync_channel::(2); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | (sender, receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/search.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 47 | host: host.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/search.rs:49:31 [INFO] [stdout] | [INFO] [stdout] 49 | password: password.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 72 | let conn = self.conn.try_clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let tasks = Arc::clone(&self.tasks); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let search_ids = Arc::clone(&self.search_ids); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 76 | | let poll = mio::Poll::new().unwrap(); [INFO] [stdout] 77 | | poll.register(&conn, CLIENT, Ready::readable(), PollOpt::edge()) [INFO] [stdout] 78 | | .unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 142 | | } [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 150 | let (task, (sender, receiver)) = Task::new(msg.clone()); [INFO] [stdout] | ---- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let conn = self.conn.try_clone()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let mut writer = BufWriter::new(conn); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | writer.write_all(msg.as_bytes())?; [INFO] [stdout] 158 | Ok((sender.clone(), receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sonic_client` (lib test) due to 9 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `host` and `port` are never read [INFO] [stdout] --> src/control.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct ControlChan { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 12 | host: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | port: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `host` and `port` are never read [INFO] [stdout] --> src/ingest.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct IngestChan { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 12 | host: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | port: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `host` and `port` are never read [INFO] [stdout] --> src/search.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct SearchChan { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 29 | host: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 30 | port: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/control.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 29 | host: host.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/control.rs:31:31 [INFO] [stdout] | [INFO] [stdout] 31 | password: password.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/control.rs:55:23 [INFO] [stdout] | [INFO] [stdout] 53 | let conn = self.conn.try_clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let tasks = Arc::clone(&self.tasks); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 56 | | let poll = mio::Poll::new().unwrap(); [INFO] [stdout] 57 | | poll.register(&conn, CLIENT, Ready::readable(), PollOpt::edge()) [INFO] [stdout] 58 | | .unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/control.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 113 | let (task, (sender, receiver)) = Task::new(msg.clone()); [INFO] [stdout] | ---- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let conn = self.conn.try_clone()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut writer = BufWriter::new(conn); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | writer.write_all(msg.as_bytes())?; [INFO] [stdout] 121 | Ok((sender.clone(), receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ingest.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 29 | host: host.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/ingest.rs:31:31 [INFO] [stdout] | [INFO] [stdout] 31 | password: password.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ingest.rs:55:23 [INFO] [stdout] | [INFO] [stdout] 53 | let conn = self.conn.try_clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | let tasks = Arc::clone(&self.tasks); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 56 | | let poll = mio::Poll::new().unwrap(); [INFO] [stdout] 57 | | poll.register(&conn, CLIENT, Ready::readable(), PollOpt::edge()) [INFO] [stdout] 58 | | .unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ingest.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 113 | let (task, (sender, receiver)) = Task::new(msg.clone()); [INFO] [stdout] | ---- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let conn = self.conn.try_clone()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let mut writer = BufWriter::new(conn); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | writer.write_all(msg.as_bytes())?; [INFO] [stdout] 121 | Ok((sender.clone(), receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 17 | let (sender, receiver) = sync_channel::(2); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ( [INFO] [stdout] 19 | / Task { [INFO] [stdout] 20 | | msg: msg, [INFO] [stdout] 21 | | sender: sender.clone(), [INFO] [stdout] 22 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 17 | let (sender, receiver) = sync_channel::(2); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | (sender, receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/search.rs:47:23 [INFO] [stdout] | [INFO] [stdout] 47 | host: host.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/search.rs:49:31 [INFO] [stdout] | [INFO] [stdout] 49 | password: password.clone().into(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 72 | let conn = self.conn.try_clone().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let tasks = Arc::clone(&self.tasks); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let search_ids = Arc::clone(&self.search_ids); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 76 | | let poll = mio::Poll::new().unwrap(); [INFO] [stdout] 77 | | poll.register(&conn, CLIENT, Ready::readable(), PollOpt::edge()) [INFO] [stdout] 78 | | .unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 142 | | } [INFO] [stdout] 143 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 150 | let (task, (sender, receiver)) = Task::new(msg.clone()); [INFO] [stdout] | ---- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let conn = self.conn.try_clone()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | let mut writer = BufWriter::new(conn); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | writer.write_all(msg.as_bytes())?; [INFO] [stdout] 158 | Ok((sender.clone(), receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sonic_client` (lib) due to 9 previous errors; 19 warnings emitted [INFO] running `Command { std: "docker" "inspect" "06a85a44f814ae80e3b8b85bb21c01e0e2955c1495ec28c93e241e5119e50578", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06a85a44f814ae80e3b8b85bb21c01e0e2955c1495ec28c93e241e5119e50578", kill_on_drop: false }` [INFO] [stdout] 06a85a44f814ae80e3b8b85bb21c01e0e2955c1495ec28c93e241e5119e50578