[INFO] fetching crate solve_lib 0.0.1... [INFO] checking solve_lib-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate solve_lib 0.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate solve_lib 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate solve_lib 0.0.1 [INFO] finished tweaking crates.io crate solve_lib 0.0.1 [INFO] tweaked toml for crates.io crate solve_lib 0.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d632f6bf7abce345cb1b2b303e328ec4c3a1bf6e64fa7c530cea0549c2a9d89 [INFO] running `Command { std: "docker" "start" "-a" "8d632f6bf7abce345cb1b2b303e328ec4c3a1bf6e64fa7c530cea0549c2a9d89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d632f6bf7abce345cb1b2b303e328ec4c3a1bf6e64fa7c530cea0549c2a9d89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d632f6bf7abce345cb1b2b303e328ec4c3a1bf6e64fa7c530cea0549c2a9d89", kill_on_drop: false }` [INFO] [stdout] 8d632f6bf7abce345cb1b2b303e328ec4c3a1bf6e64fa7c530cea0549c2a9d89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3aa0fcf2fdc3ac8373025ae20d81c5949b3cec59374f3e524b74552df2fc638c [INFO] running `Command { std: "docker" "start" "-a" "3aa0fcf2fdc3ac8373025ae20d81c5949b3cec59374f3e524b74552df2fc638c", kill_on_drop: false }` [INFO] [stderr] Checking solve_lib v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 74 | let (i, term) = parse_factor(i)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let (i, _) = space0(i)?; [INFO] [stdout] 76 | let (i, expressions) = many0(pair( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 82 | | i, [INFO] [stdout] 83 | | fold_binary_operator(term, expressions) [INFO] [stdout] 84 | | .expect("verified binary operators (multiply and divide)"), [INFO] [stdout] 85 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 89 | let (i, term) = parse_term(i)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (i, _) = space0(i)?; [INFO] [stdout] 91 | let (i, expressions) = many0(pair( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | i, [INFO] [stdout] 98 | | fold_binary_operator(term, expressions) [INFO] [stdout] 99 | | .expect("verified binary operators (add and subtract)"), [INFO] [stdout] 100 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mappers.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn fold_binary_operator(left: Expr, right_ops: Vec<(&str, Expr)>) -> Result { [INFO] [stdout] | ---------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | / right_ops [INFO] [stdout] 9 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 74 | let (i, term) = parse_factor(i)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let (i, _) = space0(i)?; [INFO] [stdout] 76 | let (i, expressions) = many0(pair( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 82 | | i, [INFO] [stdout] 83 | | fold_binary_operator(term, expressions) [INFO] [stdout] 84 | | .expect("verified binary operators (multiply and divide)"), [INFO] [stdout] 85 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mappers.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn map_binary_operator(operator: &str, left: Expr, right: Expr) -> Result { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(match operator { [INFO] [stdout] | ________^ [INFO] [stdout] 17 | | ADD_OPERATOR => Expr::Add(Box::new(left), Box::new(right)), [INFO] [stdout] 18 | | SUBTRACT_OPERATOR => Expr::Sub(Box::new(left), Box::new(right)), [INFO] [stdout] 19 | | MULTIPLY_OPERATOR => Expr::Mul(Box::new(left), Box::new(right)), [INFO] [stdout] ... | [INFO] [stdout] 22 | | _ => return Err(()), [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mappers.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn map_unary_operator(operator: &str, value: Expr) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(match operator { [INFO] [stdout] | ________^ [INFO] [stdout] 28 | | UNARY_MINUS_OPERATOR => Expr::Neg(Box::new(value)), [INFO] [stdout] 29 | | UNARY_PLUS_OPERATOR => Expr::Pos(Box::new(value)), [INFO] [stdout] 30 | | _ => return Err(()), [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 89 | let (i, term) = parse_term(i)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (i, _) = space0(i)?; [INFO] [stdout] 91 | let (i, expressions) = many0(pair( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | i, [INFO] [stdout] 98 | | fold_binary_operator(term, expressions) [INFO] [stdout] 99 | | .expect("verified binary operators (add and subtract)"), [INFO] [stdout] 100 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mappers.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn fold_binary_operator(left: Expr, right_ops: Vec<(&str, Expr)>) -> Result { [INFO] [stdout] | ---------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | / right_ops [INFO] [stdout] 9 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mappers.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn map_binary_operator(operator: &str, left: Expr, right: Expr) -> Result { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(match operator { [INFO] [stdout] | ________^ [INFO] [stdout] 17 | | ADD_OPERATOR => Expr::Add(Box::new(left), Box::new(right)), [INFO] [stdout] 18 | | SUBTRACT_OPERATOR => Expr::Sub(Box::new(left), Box::new(right)), [INFO] [stdout] 19 | | MULTIPLY_OPERATOR => Expr::Mul(Box::new(left), Box::new(right)), [INFO] [stdout] ... | [INFO] [stdout] 22 | | _ => return Err(()), [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mappers.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn map_unary_operator(operator: &str, value: Expr) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(match operator { [INFO] [stdout] | ________^ [INFO] [stdout] 28 | | UNARY_MINUS_OPERATOR => Expr::Neg(Box::new(value)), [INFO] [stdout] 29 | | UNARY_PLUS_OPERATOR => Expr::Pos(Box::new(value)), [INFO] [stdout] 30 | | _ => return Err(()), [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solve_lib` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `solve_lib` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "3aa0fcf2fdc3ac8373025ae20d81c5949b3cec59374f3e524b74552df2fc638c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3aa0fcf2fdc3ac8373025ae20d81c5949b3cec59374f3e524b74552df2fc638c", kill_on_drop: false }` [INFO] [stdout] 3aa0fcf2fdc3ac8373025ae20d81c5949b3cec59374f3e524b74552df2fc638c