[INFO] fetching crate solstice 0.1.22... [INFO] checking solstice-0.1.22 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate solstice 0.1.22 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate solstice 0.1.22 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate solstice 0.1.22 [INFO] finished tweaking crates.io crate solstice 0.1.22 [INFO] tweaked toml for crates.io crate solstice 0.1.22 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 155 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding calloop v0.6.5 (latest: v0.14.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cocoa v0.23.0 (latest: v0.26.0) [INFO] [stderr] Adding cocoa v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding cocoa-foundation v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding core-foundation v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding core-foundation-sys v0.7.0 (latest: v0.8.7) [INFO] [stderr] Adding core-graphics v0.19.2 (latest: v0.24.0) [INFO] [stderr] Adding core-graphics v0.22.3 (latest: v0.24.0) [INFO] [stderr] Adding core-graphics-types v0.1.3 (latest: v0.2.0) [INFO] [stderr] Adding darling v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.10.2 (latest: v0.20.10) [INFO] [stderr] Adding dlib v0.4.2 (latest: v0.5.2) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding glow v0.8.1 (latest: v0.14.0) [INFO] [stderr] Adding glutin v0.26.0 (latest: v0.32.0) [INFO] [stderr] Adding glutin_egl_sys v0.1.6 (latest: v0.7.0) [INFO] [stderr] Adding glutin_gles2_sys v0.1.5 (latest: v0.6.0) [INFO] [stderr] Adding glutin_glx_sys v0.1.8 (latest: v0.6.0) [INFO] [stderr] Adding glutin_wgl_sys v0.1.5 (latest: v0.6.0) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding libloading v0.6.7 (latest: v0.8.5) [INFO] [stderr] Adding malloc_buf v0.0.6 (latest: v1.0.0) [INFO] [stderr] Adding memmap2 v0.1.0 (latest: v0.9.4) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding ndarray v0.15.6 (latest: v0.16.1) [INFO] [stderr] Adding ndk v0.2.1 (latest: v0.9.0) [INFO] [stderr] Adding ndk-glue v0.2.1 (latest: v0.7.0) [INFO] [stderr] Adding ndk-macro v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding ndk-sys v0.2.2 (latest: v0.6.0+11769913) [INFO] [stderr] Adding nix v0.18.0 (latest: v0.29.0) [INFO] [stderr] Adding nix v0.20.0 (latest: v0.29.0) [INFO] [stderr] Adding num_enum v0.4.3 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.4.3 (latest: v0.7.3) [INFO] [stderr] Adding owned_ttf_parser v0.15.2 (latest: v0.24.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding proc-macro-crate v0.1.5 (latest: v3.2.0) [INFO] [stderr] Adding raw-window-handle v0.3.4 (latest: v0.6.2) [INFO] [stderr] Adding raw-window-handle v0.4.3 (latest: v0.6.2) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding slotmap v0.4.3 (latest: v1.0.7) [INFO] [stderr] Adding smithay-client-toolkit v0.12.3 (latest: v0.19.2) [INFO] [stderr] Adding strsim v0.9.3 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding ttf-parser v0.15.2 (latest: v0.24.1) [INFO] [stderr] Adding wayland-client v0.28.6 (latest: v0.31.5) [INFO] [stderr] Adding wayland-commons v0.28.6 (latest: v0.29.5) [INFO] [stderr] Adding wayland-cursor v0.28.6 (latest: v0.31.5) [INFO] [stderr] Adding wayland-egl v0.28.6 (latest: v0.32.3) [INFO] [stderr] Adding wayland-protocols v0.28.6 (latest: v0.32.3) [INFO] [stderr] Adding wayland-scanner v0.28.6 (latest: v0.31.4) [INFO] [stderr] Adding wayland-sys v0.28.6 (latest: v0.31.4) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding winit v0.24.0 (latest: v0.30.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c7ad2aa63cefff37d1bd06a39576dffaee32c2129f60b4d152ce56fa58b717f [INFO] running `Command { std: "docker" "start" "-a" "1c7ad2aa63cefff37d1bd06a39576dffaee32c2129f60b4d152ce56fa58b717f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c7ad2aa63cefff37d1bd06a39576dffaee32c2129f60b4d152ce56fa58b717f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c7ad2aa63cefff37d1bd06a39576dffaee32c2129f60b4d152ce56fa58b717f", kill_on_drop: false }` [INFO] [stdout] 1c7ad2aa63cefff37d1bd06a39576dffaee32c2129f60b4d152ce56fa58b717f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad6a2cd2d9ef49abfa0813b0c1cf0ffdd83431f4c84f4c82216d33a2529634dc [INFO] running `Command { std: "docker" "start" "-a" "ad6a2cd2d9ef49abfa0813b0c1cf0ffdd83431f4c84f4c82216d33a2529634dc", kill_on_drop: false }` [INFO] [stderr] Compiling xml-rs v0.8.21 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking glow v0.8.1 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Checking owned_ttf_parser v0.15.2 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking solstice v0.1.22 (/opt/rustwide/workdir) [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking wayland-egl v0.28.6 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn with_shape(inner: T, shape: S) -> Self [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | memory_map: ndarray::Array::default(shape), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:135:29 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn with_shape(inner: T, shape: S) -> Self [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | modified_range: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 149 | pub fn from_vec(inner: T, vec: Vec) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | memory_map: vec.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 200 | let memory_map = ndarray::Array1::from(vec![0u8; inner.size()]); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | inner, [INFO] [stdout] 203 | | memory_map, [INFO] [stdout] 204 | | modified_range: None, [INFO] [stdout] 205 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 192 | let memory_map = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | MappedBuffer::with_shape(inner.vbo.clone(), [size * std::mem::size_of::()]); [INFO] [stdout] 194 | Ok(Self { inner, memory_map }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:339:12 [INFO] [stdout] | [INFO] [stdout] 337 | let vbo = MappedBuffer::with_shape(inner.mesh.vbo.clone(), inner.mesh.vbo.size()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let ibo = MappedBuffer::with_shape(inner.ibo.clone(), inner.ibo.size()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | Ok(Self { inner, vbo, ibo }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mesh.rs:364:12 [INFO] [stdout] | [INFO] [stdout] 345 | indices: Vec, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | let vbo = MappedBuffer::from_vec(inner.mesh.vbo.clone(), unsafe { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 356 | let ibo = MappedBuffer::from_vec(inner.ibo.clone(), unsafe { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | Ok(Self { inner, vbo, ibo }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quad_batch.rs:22:23 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn map(&self, f: F) -> Quad [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | vertices: [ [INFO] [stdout] | _______________________^ [INFO] [stdout] 23 | | f(self.vertices[0]), [INFO] [stdout] 24 | | f(self.vertices[1]), [INFO] [stdout] 25 | | f(self.vertices[2]), [INFO] [stdout] 26 | | f(self.vertices[3]), [INFO] [stdout] 27 | | ], [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/quad_batch.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 90 | let mut mesh = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | mesh, [INFO] [stdout] 96 | | count: 0, [INFO] [stdout] 97 | | capacity, [INFO] [stdout] 98 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solstice` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ad6a2cd2d9ef49abfa0813b0c1cf0ffdd83431f4c84f4c82216d33a2529634dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad6a2cd2d9ef49abfa0813b0c1cf0ffdd83431f4c84f4c82216d33a2529634dc", kill_on_drop: false }` [INFO] [stdout] ad6a2cd2d9ef49abfa0813b0c1cf0ffdd83431f4c84f4c82216d33a2529634dc