[INFO] fetching crate solar-s3 0.1.1... [INFO] checking solar-s3-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate solar-s3 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate solar-s3 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate solar-s3 0.1.1 [INFO] finished tweaking crates.io crate solar-s3 0.1.1 [INFO] tweaked toml for crates.io crate solar-s3 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 140 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding byte-unit v4.0.19 (latest: v5.1.4) [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashlink v0.8.4 (latest: v0.9.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding libsqlite3-sys v0.25.2 (latest: v0.30.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mockall v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.11.4 (latest: v0.13.0) [INFO] [stderr] Adding predicates v2.1.5 (latest: v3.1.2) [INFO] [stderr] Adding rusqlite v0.28.0 (latest: v0.32.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sysinfo v0.27.8 (latest: v0.31.4) [INFO] [stderr] Adding termtree v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0cc1357faa7ceb4716c21dc98077cd8e89b19ba80b94fbe100153936297e333e [INFO] running `Command { std: "docker" "start" "-a" "0cc1357faa7ceb4716c21dc98077cd8e89b19ba80b94fbe100153936297e333e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0cc1357faa7ceb4716c21dc98077cd8e89b19ba80b94fbe100153936297e333e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cc1357faa7ceb4716c21dc98077cd8e89b19ba80b94fbe100153936297e333e", kill_on_drop: false }` [INFO] [stdout] 0cc1357faa7ceb4716c21dc98077cd8e89b19ba80b94fbe100153936297e333e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 29bce5d7996585cc8d921a8be32ef50b7ad10c307a6aca24cda57df8859a1be9 [INFO] running `Command { std: "docker" "start" "-a" "29bce5d7996585cc8d921a8be32ef50b7ad10c307a6aca24cda57df8859a1be9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libsqlite3-sys v0.25.2 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking sysinfo v0.27.8 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling uuid-macro-internal v1.10.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling mocktopus_macros v0.7.11 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking mocktopus v0.8.0 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rusqlite v0.28.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking byte-unit v4.0.19 [INFO] [stderr] Checking solar-s3 v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/store.rs:34:107 [INFO] [stdout] | [INFO] [stdout] 34 | async fn create(path: impl AsRef, available_space: u64, logging: Option) -> Result { [INFO] [stdout] | _____________________----------------------________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | | let disk_space: u64 = Space::get_disc(); [INFO] [stdout] 36 | | let free_size: i128 = disk_space as i128 - available_space as i128; [INFO] [stdout] 37 | | if free_size <= 0 { [INFO] [stdout] ... | [INFO] [stdout] 56 | | return Ok(store); [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/store.rs:59:60 [INFO] [stdout] | [INFO] [stdout] 59 | async fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ___________________----------------------___________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | | let path = Path::new(path.as_ref()).join("storage.json"); [INFO] [stdout] 61 | | let file = fs::read(&path).await?; [INFO] [stdout] 62 | | let json_str = str::from_utf8(&file).unwrap(); [INFO] [stdout] 63 | | let storage: Store = serde_json::from_str(json_str)?; [INFO] [stdout] 64 | | return Ok(storage); [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solar-s3` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/store.rs:34:107 [INFO] [stdout] | [INFO] [stdout] 34 | async fn create(path: impl AsRef, available_space: u64, logging: Option) -> Result { [INFO] [stdout] | _____________________----------------------________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | | let disk_space: u64 = Space::get_disc(); [INFO] [stdout] 36 | | let free_size: i128 = disk_space as i128 - available_space as i128; [INFO] [stdout] 37 | | if free_size <= 0 { [INFO] [stdout] ... | [INFO] [stdout] 56 | | return Ok(store); [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/store.rs:59:60 [INFO] [stdout] | [INFO] [stdout] 59 | async fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ___________________----------------------___________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | | let path = Path::new(path.as_ref()).join("storage.json"); [INFO] [stdout] 61 | | let file = fs::read(&path).await?; [INFO] [stdout] 62 | | let json_str = str::from_utf8(&file).unwrap(); [INFO] [stdout] 63 | | let storage: Store = serde_json::from_str(json_str)?; [INFO] [stdout] 64 | | return Ok(storage); [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solar-s3` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "29bce5d7996585cc8d921a8be32ef50b7ad10c307a6aca24cda57df8859a1be9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29bce5d7996585cc8d921a8be32ef50b7ad10c307a6aca24cda57df8859a1be9", kill_on_drop: false }` [INFO] [stdout] 29bce5d7996585cc8d921a8be32ef50b7ad10c307a6aca24cda57df8859a1be9