[INFO] fetching crate solana_libra_logger 0.0.1-sol5... [INFO] checking solana_libra_logger-0.0.1-sol5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate solana_libra_logger 0.0.1-sol5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate solana_libra_logger 0.0.1-sol5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate solana_libra_logger 0.0.1-sol5 [INFO] finished tweaking crates.io crate solana_libra_logger 0.0.1-sol5 [INFO] tweaked toml for crates.io crate solana_libra_logger 0.0.1-sol5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 103 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_pcg v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding thread-id v3.3.0 (latest: v4.2.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3cfe36af6a75659bfa49accbfd28c4732df58124fe9a22dac644025237f37ac5 [INFO] running `Command { std: "docker" "start" "-a" "3cfe36af6a75659bfa49accbfd28c4732df58124fe9a22dac644025237f37ac5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3cfe36af6a75659bfa49accbfd28c4732df58124fe9a22dac644025237f37ac5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3cfe36af6a75659bfa49accbfd28c4732df58124fe9a22dac644025237f37ac5", kill_on_drop: false }` [INFO] [stdout] 3cfe36af6a75659bfa49accbfd28c4732df58124fe9a22dac644025237f37ac5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b0ffffb12fc9fb8df4ec2b25ebd832fcd6d1ad35b76f901d0d837f6a861298b [INFO] running `Command { std: "docker" "start" "-a" "1b0ffffb12fc9fb8df4ec2b25ebd832fcd6d1ad35b76f901d0d837f6a861298b", kill_on_drop: false }` [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Compiling slog-async v2.8.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking rand_pcg v0.2.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking slog-scope v4.4.0 [INFO] [stderr] Checking slog-stdlog v4.1.1 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking slog-term v2.9.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking slog-envlogger v2.2.0 [INFO] [stderr] Checking solana_libra_logger v0.0.1-sol5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 95 | let drain = GlogFormat::new(TermDecorator::new().build(), ErrorCategorizer).fuse(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let envlogger = create_env_logger_with_level(drain, FilterLevel::Debug); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Logger::root(Mutex::new(envlogger).fuse(), o!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_logger.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 31 | let mut builder = LogBuilder::new(drain); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let envlogger = builder.build(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | Logger::root(Mutex::new(envlogger).fuse(), o!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solana_libra_logger` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `i` and `s` are never read [INFO] [stdout] --> src/security.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 172 | struct SampleData { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 173 | i: u8, [INFO] [stdout] | ^ [INFO] [stdout] 174 | s: Vec, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `SampleData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 95 | let drain = GlogFormat::new(TermDecorator::new().build(), ErrorCategorizer).fuse(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let envlogger = create_env_logger_with_level(drain, FilterLevel::Debug); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Logger::root(Mutex::new(envlogger).fuse(), o!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_logger.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 31 | let mut builder = LogBuilder::new(drain); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let envlogger = builder.build(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | Logger::root(Mutex::new(envlogger).fuse(), o!()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solana_libra_logger` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "1b0ffffb12fc9fb8df4ec2b25ebd832fcd6d1ad35b76f901d0d837f6a861298b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b0ffffb12fc9fb8df4ec2b25ebd832fcd6d1ad35b76f901d0d837f6a861298b", kill_on_drop: false }` [INFO] [stdout] 1b0ffffb12fc9fb8df4ec2b25ebd832fcd6d1ad35b76f901d0d837f6a861298b