[INFO] fetching crate solana-sdk-macro 1.18.23... [INFO] checking solana-sdk-macro-1.18.23 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate solana-sdk-macro 1.18.23 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate solana-sdk-macro 1.18.23 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate solana-sdk-macro 1.18.23 [INFO] finished tweaking crates.io crate solana-sdk-macro 1.18.23 [INFO] tweaked toml for crates.io crate solana-sdk-macro 1.18.23 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding bs58 v0.4.0 (latest: v0.5.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d18f3d6f41ae12bb59179a9c3fdb8984e3cfe5b9b1b0f162d4c920091444671d [INFO] running `Command { std: "docker" "start" "-a" "d18f3d6f41ae12bb59179a9c3fdb8984e3cfe5b9b1b0f162d4c920091444671d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d18f3d6f41ae12bb59179a9c3fdb8984e3cfe5b9b1b0f162d4c920091444671d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d18f3d6f41ae12bb59179a9c3fdb8984e3cfe5b9b1b0f162d4c920091444671d", kill_on_drop: false }` [INFO] [stdout] d18f3d6f41ae12bb59179a9c3fdb8984e3cfe5b9b1b0f162d4c920091444671d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 08133f29da6c8d6d45fafc652da639b14013d7f82a47e1b65034ff8fe67359b1 [INFO] running `Command { std: "docker" "start" "-a" "08133f29da6c8d6d45fafc652da639b14013d7f82a47e1b65034ff8fe67359b1", kill_on_drop: false }` [INFO] [stderr] Checking bs58 v0.4.0 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking solana-sdk-macro v1.18.23 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 318 | let pubkey_type = quote! { [INFO] [stdout] | _____________-----------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | | ::solana_sdk::pubkey::Pubkey [INFO] [stdout] 320 | | }; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | [INFO] [stdout] 322 | let method = input.parse()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | let _comma: Token![,] = input.parse()?; [INFO] [stdout] 324 | let (num, pubkeys) = if input.peek(syn::LitStr) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let id_literal: LitStr = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | let pubkey_strings; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | bracketed!(pubkey_strings in input); [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | let punctuated: Punctuated = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | Punctuated::parse_terminated(&pubkey_strings)?; [INFO] [stdout] 332 | let mut pubkeys: Punctuated = Punctuated::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | (pubkeys.len(), quote! {#pubkeys}) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | } else { [INFO] [stdout] 338 | let stream: proc_macro2::TokenStream = input.parse()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | Ok(Pubkeys { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 343 | | method, [INFO] [stdout] 344 | | num, [INFO] [stdout] 345 | | pubkeys, [INFO] [stdout] 346 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:387:5 [INFO] [stdout] | [INFO] [stdout] 386 | pub fn wasm_bindgen_stub(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | / match parse_macro_input!(item as syn::Item) { [INFO] [stdout] 388 | | syn::Item::Struct(mut item_struct) => { [INFO] [stdout] 389 | | if let syn::Fields::Named(fields) = &mut item_struct.fields { [INFO] [stdout] 390 | | // Strip out any `#[wasm_bindgen]` added to struct fields. This is custom [INFO] [stdout] ... | [INFO] [stdout] 406 | | } [INFO] [stdout] 407 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:5 [INFO] [stdout] | [INFO] [stdout] 414 | pub fn derive_clone_zeroed(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | / match parse_macro_input!(input as syn::Item) { [INFO] [stdout] 416 | | syn::Item::Struct(item_struct) => { [INFO] [stdout] 417 | | let clone_statements = match item_struct.fields { [INFO] [stdout] 418 | | syn::Fields::Named(ref fields) => fields.named.iter().map(|f| { [INFO] [stdout] ... | [INFO] [stdout] 446 | | _ => unimplemented!(), [INFO] [stdout] 447 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solana-sdk-macro` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 318 | let pubkey_type = quote! { [INFO] [stdout] | _____________-----------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | | ::solana_sdk::pubkey::Pubkey [INFO] [stdout] 320 | | }; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | [INFO] [stdout] 322 | let method = input.parse()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | let _comma: Token![,] = input.parse()?; [INFO] [stdout] 324 | let (num, pubkeys) = if input.peek(syn::LitStr) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let id_literal: LitStr = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | let pubkey_strings; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | bracketed!(pubkey_strings in input); [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | let punctuated: Punctuated = [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 331 | Punctuated::parse_terminated(&pubkey_strings)?; [INFO] [stdout] 332 | let mut pubkeys: Punctuated = Punctuated::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | (pubkeys.len(), quote! {#pubkeys}) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | } else { [INFO] [stdout] 338 | let stream: proc_macro2::TokenStream = input.parse()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | Ok(Pubkeys { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] | |____________| [INFO] [stdout] 343 | | method, [INFO] [stdout] 344 | | num, [INFO] [stdout] 345 | | pubkeys, [INFO] [stdout] 346 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:387:5 [INFO] [stdout] | [INFO] [stdout] 386 | pub fn wasm_bindgen_stub(_attr: TokenStream, item: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | / match parse_macro_input!(item as syn::Item) { [INFO] [stdout] 388 | | syn::Item::Struct(mut item_struct) => { [INFO] [stdout] 389 | | if let syn::Fields::Named(fields) = &mut item_struct.fields { [INFO] [stdout] 390 | | // Strip out any `#[wasm_bindgen]` added to struct fields. This is custom [INFO] [stdout] ... | [INFO] [stdout] 406 | | } [INFO] [stdout] 407 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:5 [INFO] [stdout] | [INFO] [stdout] 414 | pub fn derive_clone_zeroed(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 415 | / match parse_macro_input!(input as syn::Item) { [INFO] [stdout] 416 | | syn::Item::Struct(item_struct) => { [INFO] [stdout] 417 | | let clone_statements = match item_struct.fields { [INFO] [stdout] 418 | | syn::Fields::Named(ref fields) => fields.named.iter().map(|f| { [INFO] [stdout] ... | [INFO] [stdout] 446 | | _ => unimplemented!(), [INFO] [stdout] 447 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solana-sdk-macro` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "08133f29da6c8d6d45fafc652da639b14013d7f82a47e1b65034ff8fe67359b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08133f29da6c8d6d45fafc652da639b14013d7f82a47e1b65034ff8fe67359b1", kill_on_drop: false }` [INFO] [stdout] 08133f29da6c8d6d45fafc652da639b14013d7f82a47e1b65034ff8fe67359b1