[INFO] fetching crate socksv5_future 0.2.5... [INFO] checking socksv5_future-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate socksv5_future 0.2.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate socksv5_future 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate socksv5_future 0.2.5 [INFO] finished tweaking crates.io crate socksv5_future 0.2.5 [INFO] tweaked toml for crates.io crate socksv5_future 0.2.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (latest: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (latest: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (latest: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding parking_lot v0.9.0 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.6.3 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding scoped-tls v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding slab v0.3.0 (latest: v0.4.9) [INFO] [stderr] Adding smallvec v0.6.14 (latest: v1.13.2) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] [stderr] Adding tokio-timer v0.1.2 (latest: v0.2.13) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 578979ebe01f288f86b934d55f1f9612229cff152e3992b83170beb0647cc9ef [INFO] running `Command { std: "docker" "start" "-a" "578979ebe01f288f86b934d55f1f9612229cff152e3992b83170beb0647cc9ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "578979ebe01f288f86b934d55f1f9612229cff152e3992b83170beb0647cc9ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "578979ebe01f288f86b934d55f1f9612229cff152e3992b83170beb0647cc9ef", kill_on_drop: false }` [INFO] [stdout] 578979ebe01f288f86b934d55f1f9612229cff152e3992b83170beb0647cc9ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 155148da90b80d98ee43c2eb29fc0628325bf5f1ef38f13cafcb56075d3122a0 [INFO] running `Command { std: "docker" "start" "-a" "155148da90b80d98ee43c2eb29fc0628325bf5f1ef38f13cafcb56075d3122a0", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tokio-core v0.1.18 [INFO] [stderr] Checking socksv5_future v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/socks_fut.rs:206:48 [INFO] [stdout] | [INFO] [stdout] 206 | return Ok(Async::Ready(((stream,sr)))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - return Ok(Async::Ready(((stream,sr)))); [INFO] [stdout] 206 + return Ok(Async::Ready((stream,sr))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/socks_fut.rs:206:48 [INFO] [stdout] | [INFO] [stdout] 206 | return Ok(Async::Ready(((stream,sr)))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 206 - return Ok(Async::Ready(((stream,sr)))); [INFO] [stdout] 206 + return Ok(Async::Ready((stream,sr))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socks_fut.rs:126:16 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn socks_handshake(stream: TcpStream) -> SocksHandshake { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | state: ServerState::WaitClientAuthentication( [INFO] [stdout] | ________________^ [INFO] [stdout] 127 | | read_exact(stream,vec!(0u8;2)) [INFO] [stdout] 128 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socks_fut.rs:136:16 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn socks_connect_handshake(stream: TcpStream,request: SocksRequestResponse) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | state: ClientState::WaitSentAuthentication( [INFO] [stdout] | ________________^ [INFO] [stdout] 137 | | write_all(stream,vec![v5::VERSION,1u8,v5::METH_NO_AUTH]) [INFO] [stdout] 138 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `socksv5_future` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socks_fut.rs:126:16 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn socks_handshake(stream: TcpStream) -> SocksHandshake { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | state: ServerState::WaitClientAuthentication( [INFO] [stdout] | ________________^ [INFO] [stdout] 127 | | read_exact(stream,vec!(0u8;2)) [INFO] [stdout] 128 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socks_fut.rs:136:16 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn socks_connect_handshake(stream: TcpStream,request: SocksRequestResponse) [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | state: ClientState::WaitSentAuthentication( [INFO] [stdout] | ________________^ [INFO] [stdout] 137 | | write_all(stream,vec![v5::VERSION,1u8,v5::METH_NO_AUTH]) [INFO] [stdout] 138 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `socksv5_future` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "155148da90b80d98ee43c2eb29fc0628325bf5f1ef38f13cafcb56075d3122a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "155148da90b80d98ee43c2eb29fc0628325bf5f1ef38f13cafcb56075d3122a0", kill_on_drop: false }` [INFO] [stdout] 155148da90b80d98ee43c2eb29fc0628325bf5f1ef38f13cafcb56075d3122a0