[INFO] fetching crate socket 0.0.7... [INFO] checking socket-0.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate socket 0.0.7 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate socket 0.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate socket 0.0.7 [INFO] finished tweaking crates.io crate socket 0.0.7 [INFO] tweaked toml for crates.io crate socket 0.0.7 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0d5476844d3066f584aef300d7e869417ce357ef65309d666f022963fd6d7913 [INFO] running `Command { std: "docker" "start" "-a" "0d5476844d3066f584aef300d7e869417ce357ef65309d666f022963fd6d7913", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0d5476844d3066f584aef300d7e869417ce357ef65309d666f022963fd6d7913", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d5476844d3066f584aef300d7e869417ce357ef65309d666f022963fd6d7913", kill_on_drop: false }` [INFO] [stdout] 0d5476844d3066f584aef300d7e869417ce357ef65309d666f022963fd6d7913 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6e442897b4b64ca691737e8efda8a57321215e82fcdcae7b81ae30dcf585e3b1 [INFO] running `Command { std: "docker" "start" "-a" "6e442897b4b64ca691737e8efda8a57321215e82fcdcae7b81ae30dcf585e3b1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking socket v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:95:62 [INFO] [stdout] | [INFO] [stdout] 95 | let addresses: Vec = FromIterator::from_iter(try!(address.to_socket_addrs())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:113:32 [INFO] [stdout] | [INFO] [stdout] 113 | Ok(socketaddr_to_sockaddr(&try!(tosocketaddrs_to_socketaddr(address)))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:140:18 [INFO] [stdout] | [INFO] [stdout] 140 | let sa = try!(tosocketaddrs_to_sockaddr(address)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:157:18 [INFO] [stdout] | [INFO] [stdout] 157 | let sa = try!(tosocketaddrs_to_sockaddr(address)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:179:39 [INFO] [stdout] | [INFO] [stdout] 179 | let (socket_addr, received) = try!(self.recvfrom_into(&mut a[..], flags)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:204:24 [INFO] [stdout] | [INFO] [stdout] 204 | let received = try!(self.recv_into(&mut a[..], flags)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:218:23 [INFO] [stdout] | [INFO] [stdout] 218 | let address = try!(tosocketaddrs_to_sockaddr(toaddress)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/lib.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | let value = unsafe { $fun($($x,)*) }; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 81 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] 82 | let mut fds: [c_int; 2] = mem::zeroed(); [INFO] [stdout] 83 | _try!(c_socketpair, domain as c_int, type_ as c_int, protocol as c_int, &mut fds as *mut [c_int]); [INFO] [stdout] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] = note: this warning originates in the macro `_try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:95:62 [INFO] [stdout] | [INFO] [stdout] 95 | let addresses: Vec = FromIterator::from_iter(try!(address.to_socket_addrs())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:113:32 [INFO] [stdout] | [INFO] [stdout] 113 | Ok(socketaddr_to_sockaddr(&try!(tosocketaddrs_to_socketaddr(address)))) [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:140:18 [INFO] [stdout] | [INFO] [stdout] 140 | let sa = try!(tosocketaddrs_to_sockaddr(address)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:157:18 [INFO] [stdout] | [INFO] [stdout] 157 | let sa = try!(tosocketaddrs_to_sockaddr(address)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:179:39 [INFO] [stdout] | [INFO] [stdout] 179 | let (socket_addr, received) = try!(self.recvfrom_into(&mut a[..], flags)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:204:24 [INFO] [stdout] | [INFO] [stdout] 204 | let received = try!(self.recv_into(&mut a[..], flags)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib.rs:218:23 [INFO] [stdout] | [INFO] [stdout] 218 | let address = try!(tosocketaddrs_to_sockaddr(toaddress)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/lib.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` block uses type `[i32]`, which is not FFI-safe [INFO] [stdout] --> src/lib.rs:49:71 [INFO] [stdout] | [INFO] [stdout] 49 | fn c_socketpair(domain: c_int, type_: c_int, protocol: c_int, sv: *mut [c_int]) -> c_int; [INFO] [stdout] | ^^^^^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider using a raw pointer instead [INFO] [stdout] = note: slices have no C equivalent [INFO] [stdout] = note: `#[warn(improper_ctypes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 179 | let (socket_addr, received) = try!(self.recvfrom_into(&mut a[..], flags)); [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok((socket_addr, a.into_boxed_slice())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 204 | let received = try!(self.recv_into(&mut a[..], flags)); [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(a.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `socket` (lib) due to 3 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/lib.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | let value = unsafe { $fun($($x,)*) }; [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] ... [INFO] [stdout] 81 | unsafe { [INFO] [stdout] | ------ because it's nested under this `unsafe` block [INFO] [stdout] 82 | let mut fds: [c_int; 2] = mem::zeroed(); [INFO] [stdout] 83 | _try!(c_socketpair, domain as c_int, type_ as c_int, protocol as c_int, &mut fds as *mut [c_int]); [INFO] [stdout] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_unsafe)]` on by default [INFO] [stdout] = note: this warning originates in the macro `_try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `unsafe` block [INFO] [stdout] --> src/lib.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | unsafe { [INFO] [stdout] | ^^^^^^ unnecessary `unsafe` block [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` block uses type `[i32]`, which is not FFI-safe [INFO] [stdout] --> src/lib.rs:49:71 [INFO] [stdout] | [INFO] [stdout] 49 | fn c_socketpair(domain: c_int, type_: c_int, protocol: c_int, sv: *mut [c_int]) -> c_int; [INFO] [stdout] | ^^^^^^^^^^^^ not FFI-safe [INFO] [stdout] | [INFO] [stdout] = help: consider using a raw pointer instead [INFO] [stdout] = note: slices have no C equivalent [INFO] [stdout] = note: `#[warn(improper_ctypes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 179 | let (socket_addr, received) = try!(self.recvfrom_into(&mut a[..], flags)); [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok((socket_addr, a.into_boxed_slice())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 204 | let received = try!(self.recv_into(&mut a[..], flags)); [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(a.into_boxed_slice()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 370 | thread.join(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 370 | let _ = thread.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | thread.join(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 384 | let _ = thread.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `socket` (lib test) due to 3 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6e442897b4b64ca691737e8efda8a57321215e82fcdcae7b81ae30dcf585e3b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e442897b4b64ca691737e8efda8a57321215e82fcdcae7b81ae30dcf585e3b1", kill_on_drop: false }` [INFO] [stdout] 6e442897b4b64ca691737e8efda8a57321215e82fcdcae7b81ae30dcf585e3b1