[INFO] fetching crate snphost 0.4.0... [INFO] checking snphost-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate snphost 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate snphost 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate snphost 0.4.0 [INFO] finished tweaking crates.io crate snphost 0.4.0 [INFO] tweaked toml for crates.io crate snphost 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate snphost 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4bb87b0169842cbc421269980ae1a67b1da9f49c8b0d8e7d19e2da9105e80ff [INFO] running `Command { std: "docker" "start" "-a" "f4bb87b0169842cbc421269980ae1a67b1da9f49c8b0d8e7d19e2da9105e80ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4bb87b0169842cbc421269980ae1a67b1da9f49c8b0d8e7d19e2da9105e80ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4bb87b0169842cbc421269980ae1a67b1da9f49c8b0d8e7d19e2da9105e80ff", kill_on_drop: false }` [INFO] [stdout] f4bb87b0169842cbc421269980ae1a67b1da9f49c8b0d8e7d19e2da9105e80ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d12a5a0e533c684f2cfd5dc5b082a6f5392d3ae38acbf2443b4dfd374b8fdc7 [INFO] running `Command { std: "docker" "start" "-a" "8d12a5a0e533c684f2cfd5dc5b082a6f5392d3ae38acbf2443b4dfd374b8fdc7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling sev v3.2.0 [INFO] [stderr] Compiling curl v0.4.46 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking codicon v3.0.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking bitfield v0.15.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling snphost v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking iocuddle v0.1.1 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking msru v0.2.0 [INFO] [stderr] Checking colorful v0.2.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling curl-sys v0.4.72+curl-8.6.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking serde_bytes v0.11.14 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde-big-array v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cert/fetch/ca.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 28 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | file.write_all(bytes) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cert/fetch/ca.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 64 | let mut handle = Easy::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut transfer = handle.transfer(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Chain { [INFO] [stdout] | ________^ [INFO] [stdout] 80 | | ask: Certificate::from_pem(&buf[..2325])?, [INFO] [stdout] 81 | | ark: Certificate::from_pem(&buf[2325..])?, [INFO] [stdout] 82 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cert/fetch/crl.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 36 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | file.write_all(&bytes) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cert/fetch/vcek.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 54 | let mut handle = Easy::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let mut transfer = handle.transfer(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(Certificate::from_der(buf.as_slice())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 61 | let mut fw = firmware()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | / fw.snp_set_config(config) [INFO] [stdout] 63 | | .map_err(|e| anyhow::anyhow!(format!("{:?}", e))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 71 | let mut fw = firmware()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | / fw.snp_set_config(Config::default()) [INFO] [stdout] 75 | | .map_err(|e| anyhow::anyhow!(format!("{:?}", e))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snphost` (bin "snphost" test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cert/fetch/ca.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 28 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | file.write_all(bytes) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cert/fetch/ca.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 64 | let mut handle = Easy::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut transfer = handle.transfer(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Ok(Chain { [INFO] [stdout] | ________^ [INFO] [stdout] 80 | | ask: Certificate::from_pem(&buf[..2325])?, [INFO] [stdout] 81 | | ark: Certificate::from_pem(&buf[2325..])?, [INFO] [stdout] 82 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cert/fetch/crl.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 36 | let mut file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | file.write_all(&bytes) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cert/fetch/vcek.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 54 | let mut handle = Easy::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let mut transfer = handle.transfer(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(Certificate::from_der(buf.as_slice())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 61 | let mut fw = firmware()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | / fw.snp_set_config(config) [INFO] [stdout] 63 | | .map_err(|e| anyhow::anyhow!(format!("{:?}", e))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 71 | let mut fw = firmware()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | / fw.snp_set_config(Config::default()) [INFO] [stdout] 75 | | .map_err(|e| anyhow::anyhow!(format!("{:?}", e))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snphost` (bin "snphost") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "8d12a5a0e533c684f2cfd5dc5b082a6f5392d3ae38acbf2443b4dfd374b8fdc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d12a5a0e533c684f2cfd5dc5b082a6f5392d3ae38acbf2443b4dfd374b8fdc7", kill_on_drop: false }` [INFO] [stdout] 8d12a5a0e533c684f2cfd5dc5b082a6f5392d3ae38acbf2443b4dfd374b8fdc7