[INFO] fetching crate snowstorm 0.4.0... [INFO] checking snowstorm-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate snowstorm 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate snowstorm 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate snowstorm 0.4.0 [INFO] finished tweaking crates.io crate snowstorm 0.4.0 [INFO] tweaked toml for crates.io crate snowstorm 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate snowstorm 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10f33e6cbabbecdd871f7a42d9380427d2d8b3595dd4cd267446e0ff5d24d8b3 [INFO] running `Command { std: "docker" "start" "-a" "10f33e6cbabbecdd871f7a42d9380427d2d8b3595dd4cd267446e0ff5d24d8b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10f33e6cbabbecdd871f7a42d9380427d2d8b3595dd4cd267446e0ff5d24d8b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10f33e6cbabbecdd871f7a42d9380427d2d8b3595dd4cd267446e0ff5d24d8b3", kill_on_drop: false }` [INFO] [stdout] 10f33e6cbabbecdd871f7a42d9380427d2d8b3595dd4cd267446e0ff5d24d8b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24299e3bde560da84b32a5b94adf179c6ec161d97061b8932f9ca1cfaa5e8e02 [INFO] running `Command { std: "docker" "start" "-a" "24299e3bde560da84b32a5b94adf179c6ec161d97061b8932f9ca1cfaa5e8e02", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.90 [INFO] [stderr] Compiling semver v1.0.7 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Compiling snow v0.9.0 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking polyval v0.5.3 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking ctr v0.8.0 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking chacha20 v0.8.1 [INFO] [stderr] Checking ghash v0.4.4 [INFO] [stderr] Checking poly1305 v0.7.2 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking curve25519-dalek v4.0.0-pre.2 [INFO] [stderr] Checking chacha20poly1305 v0.9.0 [INFO] [stderr] Checking blake2 v0.10.4 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking aes-gcm v0.9.4 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stderr] Checking snowstorm v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/echo.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/echo.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 58 | let client_key = client_key.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let server_key = server_key.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | tokio::spawn(async move { [INFO] [stdout] 61 | / server(&server_key.private, &client_key.public) [INFO] [stdout] 62 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/echo.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 54 | let server_key = Arc::new(Builder::new(PATTERN.parse()?).generate_keypair().unwrap()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let client_key = Arc::new(Builder::new(PATTERN.parse()?).generate_keypair().unwrap()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | / client(&server_key.private, &client_key.public) [INFO] [stdout] 71 | | .await [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snowstorm` (example "echo") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `TestChannel` is never constructed [INFO] [stdout] --> src/socket.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 276 | struct TestChannel { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 411 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snowstorm` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/stress.rs:33:39 [INFO] [stdout] | [INFO] [stdout] 28 | let a = TcpStream::connect(addr).await.unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let r = Builder::new(p.parse().unwrap()).build_responder().unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let h = tokio::spawn(async move { NoiseStream::handshake(a, r).await.unwrap() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snowstorm` (bench "stress") due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "24299e3bde560da84b32a5b94adf179c6ec161d97061b8932f9ca1cfaa5e8e02", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24299e3bde560da84b32a5b94adf179c6ec161d97061b8932f9ca1cfaa5e8e02", kill_on_drop: false }` [INFO] [stdout] 24299e3bde560da84b32a5b94adf179c6ec161d97061b8932f9ca1cfaa5e8e02