[INFO] fetching crate snowflakes 0.1.2... [INFO] checking snowflakes-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate snowflakes 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate snowflakes 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate snowflakes 0.1.2 [INFO] finished tweaking crates.io crate snowflakes 0.1.2 [INFO] tweaked toml for crates.io crate snowflakes 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate snowflakes 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50a6fd0f73f42de183408b1a8dcf2fe6af03397b504cc6012f6f3eb76929ebb8 [INFO] running `Command { std: "docker" "start" "-a" "50a6fd0f73f42de183408b1a8dcf2fe6af03397b504cc6012f6f3eb76929ebb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50a6fd0f73f42de183408b1a8dcf2fe6af03397b504cc6012f6f3eb76929ebb8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50a6fd0f73f42de183408b1a8dcf2fe6af03397b504cc6012f6f3eb76929ebb8", kill_on_drop: false }` [INFO] [stdout] 50a6fd0f73f42de183408b1a8dcf2fe6af03397b504cc6012f6f3eb76929ebb8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 848910eb9fbf834643aba86e65228326afe69d588062903ec132b5e8c7092665 [INFO] running `Command { std: "docker" "start" "-a" "848910eb9fbf834643aba86e65228326afe69d588062903ec132b5e8c7092665", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling libc v0.2.127 [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling semver v1.0.13 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Compiling tokio v1.20.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking futures-io v0.3.19 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling anyhow v1.0.51 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling snow v0.9.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking tracing v0.1.35 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking polyval v0.5.3 [INFO] [stderr] Checking poly1305 v0.7.2 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking chacha20 v0.8.2 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking ctr v0.8.0 [INFO] [stderr] Checking ghash v0.4.4 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking curve25519-dalek v4.0.0-pre.2 [INFO] [stderr] Checking blake2 v0.10.4 [INFO] [stderr] Checking chacha20poly1305 v0.9.1 [INFO] [stderr] Checking aes-gcm v0.9.4 [INFO] [stderr] Compiling futures-macro v0.3.19 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling clap_derive v3.2.15 [INFO] [stderr] Checking clap v3.2.16 [INFO] [stderr] Checking futures-executor v0.3.19 [INFO] [stderr] Checking futures v0.3.19 [INFO] [stderr] Checking tokio-util v0.7.3 [INFO] [stderr] Checking snowflakes v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn into_snow_framed(self) -> Result, snow::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let Self { frame, handshake } = self; [INFO] [stdout] | ----- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(SnowFramed { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | frame, [INFO] [stdout] 58 | | transport: handshake.into_transport_mode()?, [INFO] [stdout] 59 | | current_item: None, [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:91:31 [INFO] [stdout] | [INFO] [stdout] 77 | fn start_send(self: Pin<&mut Self>, item: Bytes) -> Result<(), Self::Error> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | this.frame.start_send(crypto_item.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 111 | let encrypted_msg = match ready!(this.frame.poll_next(cx)) { [INFO] [stdout] | ------------- -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Some(Ok(x)) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Some(Err(e)) => return Poll::Ready(Some(Err(e))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Poll::Ready(Some(Ok(item))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:226:21 [INFO] [stdout] | [INFO] [stdout] 191 | let encrypted_msg = match ready!(this.frame.as_mut().poll_next(cx)) { [INFO] [stdout] | ------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | Some(Ok(x)) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | Some(Err(e)) => return Poll::Ready(Err(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snowflakes` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn into_snow_framed(self) -> Result, snow::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let Self { frame, handshake } = self; [INFO] [stdout] | ----- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Ok(SnowFramed { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | frame, [INFO] [stdout] 58 | | transport: handshake.into_transport_mode()?, [INFO] [stdout] 59 | | current_item: None, [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:91:31 [INFO] [stdout] | [INFO] [stdout] 77 | fn start_send(self: Pin<&mut Self>, item: Bytes) -> Result<(), Self::Error> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | this.frame.start_send(crypto_item.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 111 | let encrypted_msg = match ready!(this.frame.poll_next(cx)) { [INFO] [stdout] | ------------- -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Some(Ok(x)) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Some(Err(e)) => return Poll::Ready(Some(Err(e))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | Poll::Ready(Some(Ok(item))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:226:21 [INFO] [stdout] | [INFO] [stdout] 191 | let encrypted_msg = match ready!(this.frame.as_mut().poll_next(cx)) { [INFO] [stdout] | ------------- ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | Some(Ok(x)) => x, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | Some(Err(e)) => return Poll::Ready(Err(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | Poll::Ready(Ok(())) [INFO] [stdout] | ^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snowflakes` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "848910eb9fbf834643aba86e65228326afe69d588062903ec132b5e8c7092665", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "848910eb9fbf834643aba86e65228326afe69d588062903ec132b5e8c7092665", kill_on_drop: false }` [INFO] [stdout] 848910eb9fbf834643aba86e65228326afe69d588062903ec132b5e8c7092665