[INFO] fetching crate snipgrep 0.1.0... [INFO] checking snipgrep-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate snipgrep 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate snipgrep 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate snipgrep 0.1.0 [INFO] finished tweaking crates.io crate snipgrep 0.1.0 [INFO] tweaked toml for crates.io crate snipgrep 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate snipgrep 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9c47f773632bd1d88894da42a9e1c604a2c0fa457922081862f520bd9f191dc [INFO] running `Command { std: "docker" "start" "-a" "a9c47f773632bd1d88894da42a9e1c604a2c0fa457922081862f520bd9f191dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9c47f773632bd1d88894da42a9e1c604a2c0fa457922081862f520bd9f191dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9c47f773632bd1d88894da42a9e1c604a2c0fa457922081862f520bd9f191dc", kill_on_drop: false }` [INFO] [stdout] a9c47f773632bd1d88894da42a9e1c604a2c0fa457922081862f520bd9f191dc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f7065813118bff489145ac93b3501209d19eb803e16e1f97669bc6cfaecbc20 [INFO] running `Command { std: "docker" "start" "-a" "7f7065813118bff489145ac93b3501209d19eb803e16e1f97669bc6cfaecbc20", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking mac v0.1.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking futf v0.1.5 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tendril v0.4.3 [INFO] [stderr] Checking dtoa-short v0.3.4 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking servo_arc v0.3.0 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking papergrid v0.11.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Compiling getrandom v0.2.12 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking snapbox-macros v0.3.8 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking winnow v0.6.5 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking os_pipe v1.1.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.2 [INFO] [stderr] Compiling selectors v0.25.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling markup5ever v0.11.0 [INFO] [stderr] Checking snapbox v0.5.8 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Compiling html5ever v0.26.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling tabled_derive v0.7.0 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking tabled v0.15.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking cssparser v0.31.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking pest v2.7.10 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking humantime-serde v1.1.1 [INFO] [stderr] Checking insta v1.36.1 [INFO] [stderr] Checking toml_edit v0.22.7 [INFO] [stderr] Checking tree-fs v0.1.0 [INFO] [stderr] Checking scraper v0.19.0 [INFO] [stderr] Checking trycmd v0.15.0 [INFO] [stderr] Checking snipgrep v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/processor.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 71 | let span = tracing::info_span!("parse_file", path = %path.display()); [INFO] [stdout] | ---- --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let _guard = span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | match ParseFile::new(&input).parse() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 105 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | rx.into_iter().collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:110:26 [INFO] [stdout] | [INFO] [stdout] 105 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let tx = tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Box::new(move |result| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 111 | | result.map_or_else( [INFO] [stdout] 112 | | |err| { [INFO] [stdout] 113 | | tracing::error!(err = %err,"dir entry error "); [INFO] [stdout] ... | [INFO] [stdout] 126 | | ignore::WalkState::Continue [INFO] [stdout] 127 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snipgrep` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/processor.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 71 | let span = tracing::info_span!("parse_file", path = %path.display()); [INFO] [stdout] | ---- --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let _guard = span.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | match ParseFile::new(&input).parse() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 105 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | rx.into_iter().collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:110:26 [INFO] [stdout] | [INFO] [stdout] 105 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let tx = tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | Box::new(move |result| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 111 | | result.map_or_else( [INFO] [stdout] 112 | | |err| { [INFO] [stdout] 113 | | tracing::error!(err = %err,"dir entry error "); [INFO] [stdout] ... | [INFO] [stdout] 126 | | ignore::WalkState::Continue [INFO] [stdout] 127 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snipgrep` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "7f7065813118bff489145ac93b3501209d19eb803e16e1f97669bc6cfaecbc20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f7065813118bff489145ac93b3501209d19eb803e16e1f97669bc6cfaecbc20", kill_on_drop: false }` [INFO] [stdout] 7f7065813118bff489145ac93b3501209d19eb803e16e1f97669bc6cfaecbc20