[INFO] fetching crate snarc 0.1.0... [INFO] checking snarc-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate snarc 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate snarc 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate snarc 0.1.0 [INFO] finished tweaking crates.io crate snarc 0.1.0 [INFO] tweaked toml for crates.io crate snarc 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 14d249660ffc8da1a03f4402aadc8f4f7586c698348386fca599c561cfad30ee [INFO] running `Command { std: "docker" "start" "-a" "14d249660ffc8da1a03f4402aadc8f4f7586c698348386fca599c561cfad30ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "14d249660ffc8da1a03f4402aadc8f4f7586c698348386fca599c561cfad30ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14d249660ffc8da1a03f4402aadc8f4f7586c698348386fca599c561cfad30ee", kill_on_drop: false }` [INFO] [stdout] 14d249660ffc8da1a03f4402aadc8f4f7586c698348386fca599c561cfad30ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ade00284aeab6f653692a547a7469a90ee322a6605cd1dd5c3592b31344133c [INFO] running `Command { std: "docker" "start" "-a" "0ade00284aeab6f653692a547a7469a90ee322a6605cd1dd5c3592b31344133c", kill_on_drop: false }` [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking snarc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default.rs:42:31 [INFO] [stdout] | [INFO] [stdout] 41 | fn new_ptr(value: T) -> *mut Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Box::leak(Box::new(Self { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 43 | | count: std::cell::Cell::new(0), [INFO] [stdout] 44 | | value, [INFO] [stdout] 45 | | })) [INFO] [stdout] | |______________________^ [INFO] [stdout] ... [INFO] [stdout] 436 | crate::snarc!(Snarc, Narc, SnarcRef, "expectation"); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `crate::snarc` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default.rs:139:24 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn enter(&mut self, f: F) -> R [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let _guard = $crate::scopeguard::guard((), |_| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | f(&self.inner().value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 436 | crate::snarc!(Snarc, Narc, SnarcRef, "expectation"); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::snarc` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default.rs:151:21 [INFO] [stdout] | [INFO] [stdout] 150 | fn from(snarc: $send) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | snarc.into_unsend().into_erased() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 436 | crate::snarc!(Snarc, Narc, SnarcRef, "expectation"); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::snarc` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default.rs:271:21 [INFO] [stdout] | [INFO] [stdout] 267 | pub fn into_erased(self) -> ErasedNarc [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | self.into_send().into_erased().into_unsend() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 436 | crate::snarc!(Snarc, Narc, SnarcRef, "expectation"); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::snarc` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default.rs:299:21 [INFO] [stdout] | [INFO] [stdout] 298 | fn from(narc: $unsend) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | narc.into_send().into_erased() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 436 | crate::snarc!(Snarc, Narc, SnarcRef, "expectation"); [INFO] [stdout] | --------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::snarc` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:261:29 [INFO] [stdout] | [INFO] [stdout] 255 | let mut snarc = Snarc::new(5); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | [INFO] [stdout] 257 | let snarc_ref = snarc.new_ref(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | snarc.enter(|v| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 262 | | assert_eq!(*v, 5); [INFO] [stdout] 263 | | assert_eq!(snarc_ref.get(), Some(&5)); [INFO] [stdout] ... | [INFO] [stdout] 266 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/default.rs:438:5 [INFO] [stdout] | [INFO] [stdout] 438 | crate::tests::tests!(Snarc, Narc, SnarcRef); [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::tests::tests` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:277:29 [INFO] [stdout] | [INFO] [stdout] 271 | let mut snarc = Snarc::new(5); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let snarc_ref = snarc.new_ref(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | snarc.enter(|v| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 278 | | assert_eq!(*v, 5); [INFO] [stdout] 279 | | assert_eq!(snarc_ref.get(), Some(&5)); [INFO] [stdout] 280 | | assert_eq!(SnarcRef::clone(&snarc_ref).get(), Some(&5)); [INFO] [stdout] 281 | | [INFO] [stdout] 282 | | drop(snarc_ref); [INFO] [stdout] 283 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] ::: src/default.rs:438:5 [INFO] [stdout] | [INFO] [stdout] 438 | crate::tests::tests!(Snarc, Narc, SnarcRef); [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `crate::tests::tests` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snarc` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "0ade00284aeab6f653692a547a7469a90ee322a6605cd1dd5c3592b31344133c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ade00284aeab6f653692a547a7469a90ee322a6605cd1dd5c3592b31344133c", kill_on_drop: false }` [INFO] [stdout] 0ade00284aeab6f653692a547a7469a90ee322a6605cd1dd5c3592b31344133c