[INFO] fetching crate snapper-box 0.0.4... [INFO] checking snapper-box-0.0.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate snapper-box 0.0.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate snapper-box 0.0.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate snapper-box 0.0.4 [INFO] finished tweaking crates.io crate snapper-box 0.0.4 [INFO] tweaked toml for crates.io crate snapper-box 0.0.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate snapper-box 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d913d6cb7eeb55f32220685c8aa717ed6243a0ffc5f6fd5aabaf71b14ed376e [INFO] running `Command { std: "docker" "start" "-a" "9d913d6cb7eeb55f32220685c8aa717ed6243a0ffc5f6fd5aabaf71b14ed376e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d913d6cb7eeb55f32220685c8aa717ed6243a0ffc5f6fd5aabaf71b14ed376e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d913d6cb7eeb55f32220685c8aa717ed6243a0ffc5f6fd5aabaf71b14ed376e", kill_on_drop: false }` [INFO] [stdout] 9d913d6cb7eeb55f32220685c8aa717ed6243a0ffc5f6fd5aabaf71b14ed376e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 206b26a3b197148a473d81f4aa477230202ba7d7a62bb5648126ea188956f44b [INFO] running `Command { std: "docker" "start" "-a" "206b26a3b197148a473d81f4aa477230202ba7d7a62bb5648126ea188956f44b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.107 [INFO] [stderr] Compiling proc-macro2 v1.0.32 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.81 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling semver v1.0.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling serde_json v1.0.69 [INFO] [stderr] Compiling zstd-safe v4.1.1+zstd.1.5.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking base64ct v1.0.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking password-hash v0.3.2 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Compiling cc v1.0.71 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling zstd-sys v1.6.1+zstd.1.5.0 [INFO] [stderr] Compiling blake3 v1.2.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking blake2 v0.9.2 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking proptest v1.0.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling zeroize_derive v1.2.2 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling tracing-attributes v0.1.18 [INFO] [stderr] Checking zeroize v1.4.3 [INFO] [stderr] Checking argon2 v0.3.1 [INFO] [stderr] Checking chacha20 v0.8.1 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking serde_bytes v0.11.5 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking redacted v0.1.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stderr] Checking zstd v0.9.0+zstd.1.5.0 [INFO] [stderr] Checking snapper-box v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:39 [INFO] [stdout] | [INFO] [stdout] 95 | #[instrument(skip(path, password), err)] [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | pub fn init( [INFO] [stdout] 97 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | password: impl AsRef<[u8]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 102 | | let path = path.as_ref(); [INFO] [stdout] 103 | | info!(?path, "Creating CryptoBox"); [INFO] [stdout] 104 | | let password = password.as_ref(); [INFO] [stdout] ... | [INFO] [stdout] 174 | | }) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 97 | path: impl AsRef, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | password: impl AsRef<[u8]>, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let root_key = Arc::new(RootKey::random()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let mut key_file = File::create(&root_key_path).context(RootKeyIO { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let mut root_namespace = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | Ok(CryptoBox { [INFO] [stdout] | ____________^ [INFO] [stdout] 168 | | path: path.to_path_buf(), [INFO] [stdout] 169 | | root_key, [INFO] [stdout] 170 | | root_namespace, [INFO] [stdout] ... | [INFO] [stdout] 173 | | max_cache_entries, [INFO] [stdout] 174 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:39 [INFO] [stdout] | [INFO] [stdout] 198 | #[instrument(skip(path, password), err)] [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | pub fn open( [INFO] [stdout] 200 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | password: impl AsRef<[u8]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 203 | | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 204 | | let password = password.as_ref(); [INFO] [stdout] 205 | | info!(?path, "Opening CryptoBox"); [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] 274 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:298:84 [INFO] [stdout] | [INFO] [stdout] 297 | #[instrument(skip(self), err)] [INFO] [stdout] | ------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | pub fn create_namespace(&mut self, name: String) -> Result<(), CryptoBoxError> { [INFO] [stdout] | ____________________________________________________________________________________^ [INFO] [stdout] 299 | | if self.namespace_exists(&name) { [INFO] [stdout] 300 | | Ok(()) [INFO] [stdout] 301 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 332 | | } [INFO] [stdout] 333 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:351:5 [INFO] [stdout] | [INFO] [stdout] 346 | #[instrument(skip(self, key, namespace), err)] [INFO] [stdout] | ---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | / { [INFO] [stdout] 352 | | if let Some((_, lsm)) = self.namespaces.get_mut(namespace) { [INFO] [stdout] 353 | | // Try to get the item from the lsm [INFO] [stdout] 354 | | lsm.get(key).context(Fetch) [INFO] [stdout] ... | [INFO] [stdout] 359 | | } [INFO] [stdout] 360 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:376:5 [INFO] [stdout] | [INFO] [stdout] 371 | #[instrument(skip(self, key), err)] [INFO] [stdout] | ----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | / { [INFO] [stdout] 377 | | self.root_namespace.get(key).context(Fetch) [INFO] [stdout] 378 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:402:5 [INFO] [stdout] | [INFO] [stdout] 392 | #[instrument(skip(self, key, value, namespace), err)] [INFO] [stdout] | ----------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 402 | / { [INFO] [stdout] 403 | | if let Some((_, lsm)) = self.namespaces.get_mut(namespace) { [INFO] [stdout] 404 | | // Store the key in the lsmfile [INFO] [stdout] 405 | | lsm.insert(key, value).context(Store) [INFO] [stdout] ... | [INFO] [stdout] 410 | | } [INFO] [stdout] 411 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:428:5 [INFO] [stdout] | [INFO] [stdout] 423 | #[instrument(skip(self, key, value), err)] [INFO] [stdout] | ------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | / { [INFO] [stdout] 429 | | self.root_namespace.insert(key, value).context(Store) [INFO] [stdout] 430 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:448:5 [INFO] [stdout] | [INFO] [stdout] 443 | #[instrument(skip(self, key, namespace), err)] [INFO] [stdout] | ---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | / { [INFO] [stdout] 449 | | let res = self.get::(key, namespace)?; [INFO] [stdout] 450 | | Ok(res.is_some()) [INFO] [stdout] 451 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/key.rs:316:15 [INFO] [stdout] | [INFO] [stdout] 299 | let mut argon_output = Zeroizing::new([0_u8; 64]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | let mut hmac_key = Zeroizing::new([0_u8; 32]); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | let mut data = Zeroizing::new(self.payload.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | match serde_cbor::from_slice(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entries.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snapper-box` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:39 [INFO] [stdout] | [INFO] [stdout] 95 | #[instrument(skip(path, password), err)] [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | pub fn init( [INFO] [stdout] 97 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | password: impl AsRef<[u8]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 102 | | let path = path.as_ref(); [INFO] [stdout] 103 | | info!(?path, "Creating CryptoBox"); [INFO] [stdout] 104 | | let password = password.as_ref(); [INFO] [stdout] ... | [INFO] [stdout] 174 | | }) [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 97 | path: impl AsRef, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | password: impl AsRef<[u8]>, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let root_key = Arc::new(RootKey::random()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let mut key_file = File::create(&root_key_path).context(RootKeyIO { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let mut root_namespace = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | Ok(CryptoBox { [INFO] [stdout] | ____________^ [INFO] [stdout] 168 | | path: path.to_path_buf(), [INFO] [stdout] 169 | | root_key, [INFO] [stdout] 170 | | root_namespace, [INFO] [stdout] ... | [INFO] [stdout] 173 | | max_cache_entries, [INFO] [stdout] 174 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:202:39 [INFO] [stdout] | [INFO] [stdout] 198 | #[instrument(skip(path, password), err)] [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | pub fn open( [INFO] [stdout] 200 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | password: impl AsRef<[u8]>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | ) -> Result { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 203 | | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 204 | | let password = password.as_ref(); [INFO] [stdout] 205 | | info!(?path, "Opening CryptoBox"); [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] 274 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:298:84 [INFO] [stdout] | [INFO] [stdout] 297 | #[instrument(skip(self), err)] [INFO] [stdout] | ------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | pub fn create_namespace(&mut self, name: String) -> Result<(), CryptoBoxError> { [INFO] [stdout] | ____________________________________________________________________________________^ [INFO] [stdout] 299 | | if self.namespace_exists(&name) { [INFO] [stdout] 300 | | Ok(()) [INFO] [stdout] 301 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 332 | | } [INFO] [stdout] 333 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:351:5 [INFO] [stdout] | [INFO] [stdout] 346 | #[instrument(skip(self, key, namespace), err)] [INFO] [stdout] | ---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | / { [INFO] [stdout] 352 | | if let Some((_, lsm)) = self.namespaces.get_mut(namespace) { [INFO] [stdout] 353 | | // Try to get the item from the lsm [INFO] [stdout] 354 | | lsm.get(key).context(Fetch) [INFO] [stdout] ... | [INFO] [stdout] 359 | | } [INFO] [stdout] 360 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:376:5 [INFO] [stdout] | [INFO] [stdout] 371 | #[instrument(skip(self, key), err)] [INFO] [stdout] | ----------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | / { [INFO] [stdout] 377 | | self.root_namespace.get(key).context(Fetch) [INFO] [stdout] 378 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:402:5 [INFO] [stdout] | [INFO] [stdout] 392 | #[instrument(skip(self, key, value, namespace), err)] [INFO] [stdout] | ----------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 402 | / { [INFO] [stdout] 403 | | if let Some((_, lsm)) = self.namespaces.get_mut(namespace) { [INFO] [stdout] 404 | | // Store the key in the lsmfile [INFO] [stdout] 405 | | lsm.insert(key, value).context(Store) [INFO] [stdout] ... | [INFO] [stdout] 410 | | } [INFO] [stdout] 411 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:428:5 [INFO] [stdout] | [INFO] [stdout] 423 | #[instrument(skip(self, key, value), err)] [INFO] [stdout] | ------------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | / { [INFO] [stdout] 429 | | self.root_namespace.insert(key, value).context(Store) [INFO] [stdout] 430 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:448:5 [INFO] [stdout] | [INFO] [stdout] 443 | #[instrument(skip(self, key, namespace), err)] [INFO] [stdout] | ---------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 448 | / { [INFO] [stdout] 449 | | let res = self.get::(key, namespace)?; [INFO] [stdout] 450 | | Ok(res.is_some()) [INFO] [stdout] 451 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/key.rs:316:15 [INFO] [stdout] | [INFO] [stdout] 299 | let mut argon_output = Zeroizing::new([0_u8; 64]); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | let mut hmac_key = Zeroizing::new([0_u8; 32]); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | let mut data = Zeroizing::new(self.payload.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | match serde_cbor::from_slice(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entries.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snapper-box` (lib test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "206b26a3b197148a473d81f4aa477230202ba7d7a62bb5648126ea188956f44b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "206b26a3b197148a473d81f4aa477230202ba7d7a62bb5648126ea188956f44b", kill_on_drop: false }` [INFO] [stdout] 206b26a3b197148a473d81f4aa477230202ba7d7a62bb5648126ea188956f44b