[INFO] fetching crate sn_comms 0.8.0... [INFO] checking sn_comms-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sn_comms 0.8.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate sn_comms 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sn_comms 0.8.0 [INFO] finished tweaking crates.io crate sn_comms 0.8.0 [INFO] tweaked toml for crates.io crate sn_comms 0.8.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 247 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding block-padding v0.2.1 (latest: v0.3.3) [INFO] [stderr] Adding blstrs v0.6.2 (latest: v0.7.1) [INFO] [stderr] Adding brotli v3.3.4 (latest: v6.0.0) [INFO] [stderr] Adding brotli-decompressor v2.3.5 (latest: v4.0.1) [INFO] [stderr] Adding bulletproofs v4.0.0 (latest: v5.0.0) [INFO] [stderr] Adding curve25519-dalek v3.2.0 (latest: v4.1.3) [INFO] [stderr] Adding custom_debug v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding custom_debug_derive v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding ff v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding group v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding pairing v0.22.0 (latest: v0.23.0) [INFO] [stderr] Adding pem v1.1.1 (latest: v3.0.4) [INFO] [stderr] Adding proptest v1.0.0 (latest: v1.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding quinn v0.9.4 (latest: v0.11.3) [INFO] [stderr] Adding quinn-proto v0.9.6 (latest: v0.11.6) [INFO] [stderr] Adding quinn-udp v0.3.2 (latest: v0.5.4) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rcgen v0.9.3 (latest: v0.13.1) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustls v0.20.9 (latest: v0.23.12) [INFO] [stderr] Adding self_encryption v0.28.6 (latest: v0.29.2) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding sha3 v0.9.1 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding sn_dbc v12.0.0 (latest: v20.0.0) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.42.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (latest: v0.52.6) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5b857515bc8d85cf91ad4a40d0627157863ec08d85a0824a3e3e7375941c4c2c [INFO] running `Command { std: "docker" "start" "-a" "5b857515bc8d85cf91ad4a40d0627157863ec08d85a0824a3e3e7375941c4c2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5b857515bc8d85cf91ad4a40d0627157863ec08d85a0824a3e3e7375941c4c2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b857515bc8d85cf91ad4a40d0627157863ec08d85a0824a3e3e7375941c4c2c", kill_on_drop: false }` [INFO] [stdout] 5b857515bc8d85cf91ad4a40d0627157863ec08d85a0824a3e3e7375941c4c2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c2c40169011d515d902d6484dad5045ee5cd8e4a3b7f3776f88bbde0638817c [INFO] running `Command { std: "docker" "start" "-a" "8c2c40169011d515d902d6484dad5045ee5cd8e4a3b7f3776f88bbde0638817c", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling clear_on_drop v0.2.5 [INFO] [stderr] Checking hex_fmt v0.3.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling err-derive v0.3.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking subtle-ng v2.5.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking brotli-decompressor v2.3.5 [INFO] [stderr] Checking sha3 v0.9.1 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking pem v1.1.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking brotli v3.3.4 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking uluru v3.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking ff v0.12.1 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rcgen v0.9.3 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.13 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling custom_debug_derive v0.5.1 [INFO] [stderr] Checking data-encoding-macro v0.1.15 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Checking custom_debug v0.5.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking merlin v3.0.0 [INFO] [stderr] Checking curve25519-dalek v3.2.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking group v0.12.1 [INFO] [stderr] Checking proptest v1.0.0 [INFO] [stderr] Checking pairing v0.22.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking blstrs v0.6.2 [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking curve25519-dalek-ng v4.1.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking crdts v7.3.2 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking blsttc v8.0.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking quinn-proto v0.9.6 [INFO] [stderr] Checking xor_name v5.0.0 [INFO] [stderr] Checking bulletproofs v4.0.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking sn_sdkg v3.1.4 [INFO] [stderr] Checking sn_consensus v3.5.2 [INFO] [stderr] Checking sn_dbc v12.0.0 [INFO] [stderr] Checking quinn-udp v0.3.2 [INFO] [stderr] Checking quinn v0.9.4 [INFO] [stderr] Checking self_encryption v0.28.6 [INFO] [stderr] Checking sn_interface v0.22.4 [INFO] [stderr] Checking qp2p v0.36.4 [INFO] [stderr] Checking sn_comms v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:715:23 [INFO] [stdout] | [INFO] [stdout] 715 | let _handle = tokio::task::spawn(async move { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | unused_qualifications, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 715 - let _handle = tokio::task::spawn(async move { [INFO] [stdout] 715 + let _handle = task::spawn(async move { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/lib.rs:732:23 [INFO] [stdout] | [INFO] [stdout] 732 | let _handle = tokio::task::spawn(async move { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 732 - let _handle = tokio::task::spawn(async move { [INFO] [stdout] 732 + let _handle = task::spawn(async move { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:39 [INFO] [stdout] | [INFO] [stdout] 301 | .map(|(node_id, bytes)| { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let link = get_link(msg_id, node_id, &links, comm_events.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | (node_id, (link, bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:15 [INFO] [stdout] | [INFO] [stdout] 338 | fn send(msg_id: MsgId, mut link: NodeLink, bytes: UsrMsgBytes, comm_events: Sender) { [INFO] [stdout] | ---- ----- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | match link.send(msg_id, bytes).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:28 [INFO] [stdout] | [INFO] [stdout] 415 | .map(|pb| (pb, comm_events.clone())) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:433:27 [INFO] [stdout] | [INFO] [stdout] 416 | .map(|((node_id, (link, bytes)), comm_events)| async move { [INFO] [stdout] | ---- ----- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | let link = match link { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | Some(link) => link, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | let node_response_bytes = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 423 | match link.send_with_bi_return_response(bytes, msg_id).await { [INFO] [stdout] 424 | Ok(response_bytes) => response_bytes, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 425 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | (node_id, Ok(node_response_bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:499:5 [INFO] [stdout] | [INFO] [stdout] 496 | let response = DataResponse::NetworkIssue(MsgError::InconsistentStorageNodeResponses); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 497 | let payload = WireMsg::serialize_msg_payload(&response).ok()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 498 | let wire_msg = WireMsg::new_msg(MsgId::new(), payload, kind, dst); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | wire_msg.serialize().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:34:35 [INFO] [stdout] | [INFO] [stdout] 33 | fn from(error: qp2p::SendError) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self::AddressNotReachable(qp2p::RpcError::Send(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_link.rs:54:26 [INFO] [stdout] | [INFO] [stdout] 50 | pub(crate) fn new(node_id: NodeId, endpoint: Endpoint) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | connections: NodeConnections::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sn_comms` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:39 [INFO] [stdout] | [INFO] [stdout] 301 | .map(|(node_id, bytes)| { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 302 | let link = get_link(msg_id, node_id, &links, comm_events.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | (node_id, (link, bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:15 [INFO] [stdout] | [INFO] [stdout] 338 | fn send(msg_id: MsgId, mut link: NodeLink, bytes: UsrMsgBytes, comm_events: Sender) { [INFO] [stdout] | ---- ----- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | match link.send(msg_id, bytes).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:28 [INFO] [stdout] | [INFO] [stdout] 415 | .map(|pb| (pb, comm_events.clone())) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:433:27 [INFO] [stdout] | [INFO] [stdout] 416 | .map(|((node_id, (link, bytes)), comm_events)| async move { [INFO] [stdout] | ---- ----- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | let link = match link { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | Some(link) => link, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 422 | let node_response_bytes = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 423 | match link.send_with_bi_return_response(bytes, msg_id).await { [INFO] [stdout] 424 | Ok(response_bytes) => response_bytes, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 425 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | (node_id, Ok(node_response_bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:499:5 [INFO] [stdout] | [INFO] [stdout] 496 | let response = DataResponse::NetworkIssue(MsgError::InconsistentStorageNodeResponses); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 497 | let payload = WireMsg::serialize_msg_payload(&response).ok()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 498 | let wire_msg = WireMsg::new_msg(MsgId::new(), payload, kind, dst); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | wire_msg.serialize().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:34:35 [INFO] [stdout] | [INFO] [stdout] 33 | fn from(error: qp2p::SendError) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self::AddressNotReachable(qp2p::RpcError::Send(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_link.rs:54:26 [INFO] [stdout] | [INFO] [stdout] 50 | pub(crate) fn new(node_id: NodeId, endpoint: Endpoint) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | connections: NodeConnections::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:696:12 [INFO] [stdout] | [INFO] [stdout] 685 | let src_keypair = Keypair::new_ed25519(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 688 | let query = ClientMsg::Query(query); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 689 | let payload = WireMsg::serialize_msg_payload(&query)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 696 | Ok(WireMsg::new_msg( [INFO] [stdout] | ____________^ [INFO] [stdout] 697 | | MsgId::new(), [INFO] [stdout] 698 | | payload, [INFO] [stdout] 699 | | MsgKind::Client { [INFO] [stdout] ... | [INFO] [stdout] 704 | | dst, [INFO] [stdout] 705 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sn_comms` (lib test) due to 9 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8c2c40169011d515d902d6484dad5045ee5cd8e4a3b7f3776f88bbde0638817c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c2c40169011d515d902d6484dad5045ee5cd8e4a3b7f3776f88bbde0638817c", kill_on_drop: false }` [INFO] [stdout] 8c2c40169011d515d902d6484dad5045ee5cd8e4a3b7f3776f88bbde0638817c