[INFO] fetching crate smtree 0.1.2... [INFO] checking smtree-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate smtree 0.1.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate smtree 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smtree 0.1.2 [INFO] finished tweaking crates.io crate smtree 0.1.2 [INFO] tweaked toml for crates.io crate smtree 0.1.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 103 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding blake2 v0.9.2 (latest: v0.10.6) [INFO] [stderr] Adding blake3 v0.3.8 (latest: v1.5.4) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding block-padding v0.2.1 (latest: v0.3.3) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding crypto-mac v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding sha3 v0.9.1 (latest: v0.10.8) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 470996b5de0f83fa79675342852ddea2b1ffdc060af951b87a8b4e339f812630 [INFO] running `Command { std: "docker" "start" "-a" "470996b5de0f83fa79675342852ddea2b1ffdc060af951b87a8b4e339f812630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "470996b5de0f83fa79675342852ddea2b1ffdc060af951b87a8b4e339f812630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "470996b5de0f83fa79675342852ddea2b1ffdc060af951b87a8b4e339f812630", kill_on_drop: false }` [INFO] [stdout] 470996b5de0f83fa79675342852ddea2b1ffdc060af951b87a8b4e339f812630 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 59960052a8f67b27f8cd8bc9e86c9373a3f40f49b3e66ffb9d6964f61ba668f3 [INFO] running `Command { std: "docker" "start" "-a" "59960052a8f67b27f8cd8bc9e86c9373a3f40f49b3e66ffb9d6964f61ba668f3", kill_on_drop: false }` [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Compiling blake3 v0.3.8 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking blake2 v0.9.2 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking sha3 v0.9.1 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking smtree v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `rand` [INFO] [stdout] --> src/pad_secret.rs:8:7 [INFO] [stdout] | [INFO] [stdout] 8 | #[cfg(feature = "rand")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `rand` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_template.rs:56:26 [INFO] [stdout] | [INFO] [stdout] 53 | let mut hasher = D::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | HashNodeSmt::new(hasher.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_template.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 62 | let mut pre_image = D::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let mut hasher = D::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | HashNodeSmt::new(hasher.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_template.rs:103:26 [INFO] [stdout] | [INFO] [stdout] 100 | let mut pre_image = D::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | HashNodeSmt::new(pre_image.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_template.rs:114:40 [INFO] [stdout] | [INFO] [stdout] 111 | let mut hasher = D::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | *node == HashNodeSmt::::new(hasher.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_template.rs:241:31 [INFO] [stdout] | [INFO] [stdout] 238 | let mut hasher = D::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | HashWiresNodeSmt::new(hasher.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_template.rs:251:31 [INFO] [stdout] | [INFO] [stdout] 247 | let mut hasher = D::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | HashWiresNodeSmt::new(hasher.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_template.rs:324:27 [INFO] [stdout] | [INFO] [stdout] 321 | let mut hasher = D::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | MTreeNodeSmt::new(hasher.finalize().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proof.rs:499:12 [INFO] [stdout] | [INFO] [stdout] 474 | let mut padding_proofs: Vec = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | let merkle_proof = MerkleProof::::deserialize_as_a_unit(bytes, begin); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | let merkle_proof = merkle_proof.unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | // Decode the leaves. [INFO] [stdout] 490 | let mut leaves: Vec = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 499 | Ok(RandomSamplingProof::::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 500 | | index[0], [INFO] [stdout] 501 | | padding_proofs, [INFO] [stdout] 502 | | merkle_proof, [INFO] [stdout] 503 | | leaves, [INFO] [stdout] 504 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:551:80 [INFO] [stdout] | [INFO] [stdout] 551 | .map(|(index, p)| (tree_index_from_u64(self.height, index as u64), p.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smtree` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "59960052a8f67b27f8cd8bc9e86c9373a3f40f49b3e66ffb9d6964f61ba668f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59960052a8f67b27f8cd8bc9e86c9373a3f40f49b3e66ffb9d6964f61ba668f3", kill_on_drop: false }` [INFO] [stdout] 59960052a8f67b27f8cd8bc9e86c9373a3f40f49b3e66ffb9d6964f61ba668f3