[INFO] fetching crate smrec 0.1.4... [INFO] checking smrec-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate smrec 0.1.4 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate smrec 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smrec 0.1.4 [INFO] finished tweaking crates.io crate smrec 0.1.4 [INFO] tweaked toml for crates.io crate smrec 0.1.4 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate smrec 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58a0999628f25ef1eaee7cde164eead0e7610570f39ea65b18b59279bd36f592 [INFO] running `Command { std: "docker" "start" "-a" "58a0999628f25ef1eaee7cde164eead0e7610570f39ea65b18b59279bd36f592", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58a0999628f25ef1eaee7cde164eead0e7610570f39ea65b18b59279bd36f592", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58a0999628f25ef1eaee7cde164eead0e7610570f39ea65b18b59279bd36f592", kill_on_drop: false }` [INFO] [stdout] 58a0999628f25ef1eaee7cde164eead0e7610570f39ea65b18b59279bd36f592 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2be1b19d80cc70bb54edea09fe243f6c7c1efd0050655cd6c5a0a0702d322fe0 [INFO] running `Command { std: "docker" "start" "-a" "2be1b19d80cc70bb54edea09fe243f6c7c1efd0050655cd6c5a0a0702d322fe0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking hashbrown v0.14.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling crossbeam-queue v0.3.8 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking winnow v0.5.16 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking glob-match v0.2.1 [INFO] [stderr] Checking clap_builder v4.4.6 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking crossbeam v0.8.2 [INFO] [stderr] Checking rosc v0.10.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking ctrlc v3.4.1 [INFO] [stderr] Checking midir v0.9.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking clap v4.4.6 [INFO] [stderr] Checking serde v1.0.188 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking toml_edit v0.20.2 [INFO] [stderr] Checking toml v0.8.2 [INFO] [stderr] Checking smrec v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 218 | let mut writers = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(Arc::new(writers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 126 | sender_channel: crossbeam::channel::Sender, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | receiver_channel: crossbeam::channel::Receiver, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let input = MidiInput::new("smrec")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | input, [INFO] [stdout] 146 | | output: if output_config.is_some() { [INFO] [stdout] 147 | | Some(MidiOutput::new("smrec")?) [INFO] [stdout] ... | [INFO] [stdout] 156 | | output_thread: None, [INFO] [stdout] 157 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi.rs:282:27 [INFO] [stdout] | [INFO] [stdout] 274 | let output = MidiOutput::new("smrec")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | >(( [INFO] [stdout] | ___________________________^ [INFO] [stdout] 283 | | port_name.clone(), [INFO] [stdout] 284 | | Arc::new(Mutex::new(output.connect(port, port_name).expect("Could not bind to {port_name}"))), [INFO] [stdout] 285 | | configs.clone(), [INFO] [stdout] 286 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi/parse.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 20 | let star_parser = map(char('*'), |_| 255_u8); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let num_parser = map_res(preceded(multispace0, digit1), str::parse::); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | alt((num_parser, star_parser))(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/osc.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 21 | sender_channel: crossbeam::channel::Sender, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | receiver_channel: crossbeam::channel::Receiver, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let sender_socket = Arc::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let receiver_socket = Arc::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | sender_socket, [INFO] [stdout] 87 | | receiver_socket, [INFO] [stdout] 88 | | sender_channel, [INFO] [stdout] ... | [INFO] [stdout] 91 | | messaging_thread: None, [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 57 | writers_in_stream: Arc>>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Box::new(move |data: &[T], _: &_| { [INFO] [stdout] | ______________^ [INFO] [stdout] 64 | | // TODO: A shared atomic queue will be supplied later on. [INFO] [stdout] 65 | | // There will be no allocations here. [INFO] [stdout] 66 | | // Also no locking. [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smrec` (bin "smrec") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 218 | let mut writers = Vec::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | Ok(Arc::new(writers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 126 | sender_channel: crossbeam::channel::Sender, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | receiver_channel: crossbeam::channel::Receiver, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let input = MidiInput::new("smrec")?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | input, [INFO] [stdout] 146 | | output: if output_config.is_some() { [INFO] [stdout] 147 | | Some(MidiOutput::new("smrec")?) [INFO] [stdout] ... | [INFO] [stdout] 156 | | output_thread: None, [INFO] [stdout] 157 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi.rs:282:27 [INFO] [stdout] | [INFO] [stdout] 274 | let output = MidiOutput::new("smrec")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | >(( [INFO] [stdout] | ___________________________^ [INFO] [stdout] 283 | | port_name.clone(), [INFO] [stdout] 284 | | Arc::new(Mutex::new(output.connect(port, port_name).expect("Could not bind to {port_name}"))), [INFO] [stdout] 285 | | configs.clone(), [INFO] [stdout] 286 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi/parse.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 20 | let star_parser = map(char('*'), |_| 255_u8); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let num_parser = map_res(preceded(multispace0, digit1), str::parse::); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | alt((num_parser, star_parser))(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/osc.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 21 | sender_channel: crossbeam::channel::Sender, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | receiver_channel: crossbeam::channel::Receiver, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let sender_socket = Arc::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let receiver_socket = Arc::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | sender_socket, [INFO] [stdout] 87 | | receiver_socket, [INFO] [stdout] 88 | | sender_channel, [INFO] [stdout] ... | [INFO] [stdout] 91 | | messaging_thread: None, [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 57 | writers_in_stream: Arc>>, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Box::new(move |data: &[T], _: &_| { [INFO] [stdout] | ______________^ [INFO] [stdout] 64 | | // TODO: A shared atomic queue will be supplied later on. [INFO] [stdout] 65 | | // There will be no allocations here. [INFO] [stdout] 66 | | // Also no locking. [INFO] [stdout] ... | [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smrec` (bin "smrec" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "2be1b19d80cc70bb54edea09fe243f6c7c1efd0050655cd6c5a0a0702d322fe0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2be1b19d80cc70bb54edea09fe243f6c7c1efd0050655cd6c5a0a0702d322fe0", kill_on_drop: false }` [INFO] [stdout] 2be1b19d80cc70bb54edea09fe243f6c7c1efd0050655cd6c5a0a0702d322fe0