[INFO] fetching crate smr 0.1.2... [INFO] checking smr-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate smr 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate smr 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smr 0.1.2 [INFO] finished tweaking crates.io crate smr 0.1.2 [INFO] tweaked toml for crates.io crate smr 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 197 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding crossbeam-channel v0.4.4 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (latest: v0.8.20) [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding ipc-channel v0.15.0 (latest: v0.18.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding mio v0.6.23 (latest: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (latest: v0.6.0) [INFO] [stderr] Adding nix v0.22.3 (latest: v0.29.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding phf v0.10.1 (latest: v0.11.2) [INFO] [stderr] Adding phf_generator v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_macros v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding pretty_env_logger v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding procfs v0.10.1 (latest: v0.16.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding ringbuffer v0.8.5 (latest: v0.15.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding strum v0.21.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.21.1 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding syscallz v0.16.2 (latest: v0.17.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 80e481ecb8f02abcf3a3779bbc28afd249f3d30e0f55c61969c37d854be84b85 [INFO] running `Command { std: "docker" "start" "-a" "80e481ecb8f02abcf3a3779bbc28afd249f3d30e0f55c61969c37d854be84b85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "80e481ecb8f02abcf3a3779bbc28afd249f3d30e0f55c61969c37d854be84b85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80e481ecb8f02abcf3a3779bbc28afd249f3d30e0f55c61969c37d854be84b85", kill_on_drop: false }` [INFO] [stdout] 80e481ecb8f02abcf3a3779bbc28afd249f3d30e0f55c61969c37d854be84b85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1fc8a58fff8237c7fea7c4a6041b8d2c9593f3dd8c1d54267768e73e2d2433d0 [INFO] running `Command { std: "docker" "start" "-a" "1fc8a58fff8237c7fea7c4a6041b8d2c9593f3dd8c1d54267768e73e2d2433d0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling seccomp-sys v0.1.3 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling syscallz v0.16.2 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking ringbuffer v0.8.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking nix v0.22.3 [INFO] [stderr] Checking procfs v0.10.1 [INFO] [stderr] Checking prctl v1.0.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking filedescriptor v0.8.2 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Checking phf v0.10.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking ipc-channel v0.15.0 [INFO] [stderr] Checking smr v0.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pm.rs:86:15 [INFO] [stdout] | [INFO] [stdout] 84 | process_init: impl FnOnce(), [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | ) -> PmHandle { [INFO] [stdout] 86 | do_pm_start(move || { [INFO] [stdout] | _______________^ [INFO] [stdout] 87 | | pm_secure_entry_bootstrap(argc, argv, envp); [INFO] [stdout] 88 | | process_init(); [INFO] [stdout] 89 | | }) [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pm.rs:126:38 [INFO] [stdout] | [INFO] [stdout] 113 | let (comp_tx, comp_rx) = ipc::channel()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let pid = spawn_blocking(move || comp_rx.recv().map_err(|_| InitFailed)).await??; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `tokio::sync::RwLockReadGuard` that must be used [INFO] [stdout] --> src/pm.rs:185:7 [INFO] [stdout] | [INFO] [stdout] 185 | term.read().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if unused the RwLock will immediately unlock [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 185 | let _ = term.read().await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pm.rs:314:54 [INFO] [stdout] | [INFO] [stdout] 290 | let wi = match wi { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | let local_set = LocalSet::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | local_set.run_until(pm_worker_entry(wi)).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:198:21 [INFO] [stdout] | [INFO] [stdout] 198 | .filter(|x| x.m.0.try_read().is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:229:7 [INFO] [stdout] | [INFO] [stdout] 220 | pub fn new(pm: PmHandle) -> Arc> { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let (pms_tx, pms_rx) = mpsc::unbounded_channel(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | / tokio::runtime::Builder::new_current_thread() [INFO] [stdout] 230 | | .enable_all() [INFO] [stdout] 231 | | .build() [INFO] [stdout] 232 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scheduler.rs:233:19 [INFO] [stdout] | [INFO] [stdout] 220 | pub fn new(pm: PmHandle) -> Arc> { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | let (pms_tx, pms_rx) = mpsc::unbounded_channel(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | .block_on(pm_service(pm, pms_rx)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 17 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | ctx: &'static Self::Context, [INFO] [stdout] 19 | _: watch::Receiver<()>, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | ) -> Result { [INFO] [stdout] | __________________________^ [INFO] [stdout] 21 | | self.handle(ctx).await [INFO] [stdout] 22 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smr` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1fc8a58fff8237c7fea7c4a6041b8d2c9593f3dd8c1d54267768e73e2d2433d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1fc8a58fff8237c7fea7c4a6041b8d2c9593f3dd8c1d54267768e73e2d2433d0", kill_on_drop: false }` [INFO] [stdout] 1fc8a58fff8237c7fea7c4a6041b8d2c9593f3dd8c1d54267768e73e2d2433d0