[INFO] fetching crate smoljson 0.1.1... [INFO] checking smoljson-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate smoljson 0.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate smoljson 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smoljson 0.1.1 [INFO] finished tweaking crates.io crate smoljson 0.1.1 [INFO] tweaked toml for crates.io crate smoljson 0.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9c04ed6ddd4c829ca26fbb84edbd911979f0c105cf0c74fa6a47a2cc9d8c0512 [INFO] running `Command { std: "docker" "start" "-a" "9c04ed6ddd4c829ca26fbb84edbd911979f0c105cf0c74fa6a47a2cc9d8c0512", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c04ed6ddd4c829ca26fbb84edbd911979f0c105cf0c74fa6a47a2cc9d8c0512", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c04ed6ddd4c829ca26fbb84edbd911979f0c105cf0c74fa6a47a2cc9d8c0512", kill_on_drop: false }` [INFO] [stdout] 9c04ed6ddd4c829ca26fbb84edbd911979f0c105cf0c74fa6a47a2cc9d8c0512 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eaa33fa929a699d612ab1c54b78bd30a8bfc83d1c84b161e41332fae996962c5 [INFO] running `Command { std: "docker" "start" "-a" "eaa33fa929a699d612ab1c54b78bd30a8bfc83d1c84b161e41332fae996962c5", kill_on_drop: false }` [INFO] [stderr] Checking smoljson v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:152:33 [INFO] [stdout] | [INFO] [stdout] 152 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:154:37 [INFO] [stdout] | [INFO] [stdout] 154 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:159:37 [INFO] [stdout] | [INFO] [stdout] 159 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:167:41 [INFO] [stdout] | [INFO] [stdout] 167 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:222:37 [INFO] [stdout] | [INFO] [stdout] 222 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:242:41 [INFO] [stdout] | [INFO] [stdout] 242 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:152:33 [INFO] [stdout] | [INFO] [stdout] 152 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:154:37 [INFO] [stdout] | [INFO] [stdout] 154 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:159:37 [INFO] [stdout] | [INFO] [stdout] 159 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:167:41 [INFO] [stdout] | [INFO] [stdout] 167 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:222:37 [INFO] [stdout] | [INFO] [stdout] 222 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:242:41 [INFO] [stdout] | [INFO] [stdout] 242 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:251:15 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn finish(mut self) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | match self.next_token() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:491:12 [INFO] [stdout] | [INFO] [stdout] 477 | let tok = match tri!(self.bnext_or_err()) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | Ok(Some(tri!(tok))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:165:22 [INFO] [stdout] | [INFO] [stdout] 164 | fn from_iter>>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | Value::Array(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 170 | fn from_iter)>>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Value::Object(iter.into_iter().map(|(k, v)| (k.into(), v)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smoljson` (lib test) due to 5 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:251:15 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn finish(mut self) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | match self.next_token() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:491:12 [INFO] [stdout] | [INFO] [stdout] 477 | let tok = match tri!(self.bnext_or_err()) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 491 | Ok(Some(tri!(tok))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:165:22 [INFO] [stdout] | [INFO] [stdout] 164 | fn from_iter>>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | Value::Array(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 170 | fn from_iter)>>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Value::Object(iter.into_iter().map(|(k, v)| (k.into(), v)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smoljson` (lib) due to 5 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "eaa33fa929a699d612ab1c54b78bd30a8bfc83d1c84b161e41332fae996962c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eaa33fa929a699d612ab1c54b78bd30a8bfc83d1c84b161e41332fae996962c5", kill_on_drop: false }` [INFO] [stdout] eaa33fa929a699d612ab1c54b78bd30a8bfc83d1c84b161e41332fae996962c5