[INFO] fetching crate smokey 0.3.4... [INFO] checking smokey-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate smokey 0.3.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate smokey 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smokey 0.3.4 [INFO] finished tweaking crates.io crate smokey 0.3.4 [INFO] tweaked toml for crates.io crate smokey 0.3.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate smokey 0.3.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a78ac6954e95faa34b1b477e833af956dfd0bd4bb94d1336079fddce5647ccf4 [INFO] running `Command { std: "docker" "start" "-a" "a78ac6954e95faa34b1b477e833af956dfd0bd4bb94d1336079fddce5647ccf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a78ac6954e95faa34b1b477e833af956dfd0bd4bb94d1336079fddce5647ccf4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a78ac6954e95faa34b1b477e833af956dfd0bd4bb94d1336079fddce5647ccf4", kill_on_drop: false }` [INFO] [stdout] a78ac6954e95faa34b1b477e833af956dfd0bd4bb94d1336079fddce5647ccf4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 05ddbe9c79cc2bbfec9bf3d0cdb8aac7f1ec0d20727fc4edc72f57850b1c149d [INFO] running `Command { std: "docker" "start" "-a" "05ddbe9c79cc2bbfec9bf3d0cdb8aac7f1ec0d20727fc4edc72f57850b1c149d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling syn v1.0.87 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling signal-hook v0.3.10 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling pkg-config v0.3.20 [INFO] [stderr] Compiling cc v1.0.71 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking mio v0.7.9 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling libsqlite3-sys v0.24.1 [INFO] [stderr] Checking signal-hook-mio v0.2.1 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Compiling directories-next v2.0.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking futures-core v0.3.13 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling anyhow v1.0.42 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking crossterm v0.22.1 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Compiling smokey v0.3.4 (/opt/rustwide/workdir) [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking hashlink v0.7.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking simplelog v0.9.0 [INFO] [stderr] Checking bimap v0.6.1 [INFO] [stderr] Checking fastrand v1.4.0 [INFO] [stderr] Checking bytecount v0.6.2 [INFO] [stderr] Checking tui v0.17.0 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Checking rusqlite v0.27.0 [INFO] [stdout] warning: unused import: `draw_test` [INFO] [stdout] --> src/painters/mod.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | pub use typer::{draw_test, draw_test_and_update}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `draw_test` [INFO] [stdout] --> src/painters/mod.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | pub use typer::{draw_test, draw_test_and_update}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/utils/termprep.rs:73:35 [INFO] [stdout] | [INFO] [stdout] 73 | fn panic_hook(panic_info: &panic::PanicInfo) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/utils/termprep.rs:73:35 [INFO] [stdout] | [INFO] [stdout] 73 | fn panic_hook(panic_info: &panic::PanicInfo) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/application.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 92 | let final_config = config::get_final_config(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let test = TestState::with_colors(final_config.theme.to_test_colors()); [INFO] [stdout] 94 | let settings = Settings::with_config( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | ..Self::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:311:23 [INFO] [stdout] | [INFO] [stdout] 283 | let test_cfg = TypingTestConfig::default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | let conn = Connection::open(&*storage::DATABASE).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | database: RunHistoryDatbase::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:352:23 [INFO] [stdout] | [INFO] [stdout] 321 | pub fn with_config(colors: SettingsColors, ttc: TypingTestConfig) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | let mut test_cfg = ttc; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let conn = Connection::open(&*storage::DATABASE).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | database: RunHistoryDatbase::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 35 | .map(|i| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | i.unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|i| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | i.unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smokey` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/application.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 92 | let final_config = config::get_final_config(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let test = TestState::with_colors(final_config.theme.to_test_colors()); [INFO] [stdout] 94 | let settings = Settings::with_config( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | ..Self::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:311:23 [INFO] [stdout] | [INFO] [stdout] 283 | let test_cfg = TypingTestConfig::default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | let conn = Connection::open(&*storage::DATABASE).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | database: RunHistoryDatbase::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:352:23 [INFO] [stdout] | [INFO] [stdout] 321 | pub fn with_config(colors: SettingsColors, ttc: TypingTestConfig) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | let mut test_cfg = ttc; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | let conn = Connection::open(&*storage::DATABASE).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | database: RunHistoryDatbase::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 35 | .map(|i| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | i.unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 50 | .map(|i| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | i.unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smokey` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "05ddbe9c79cc2bbfec9bf3d0cdb8aac7f1ec0d20727fc4edc72f57850b1c149d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05ddbe9c79cc2bbfec9bf3d0cdb8aac7f1ec0d20727fc4edc72f57850b1c149d", kill_on_drop: false }` [INFO] [stdout] 05ddbe9c79cc2bbfec9bf3d0cdb8aac7f1ec0d20727fc4edc72f57850b1c149d