[INFO] fetching crate sml-rs 0.4.0... [INFO] checking sml-rs-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sml-rs 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sml-rs 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sml-rs 0.4.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate sml-rs 0.4.0 [INFO] tweaked toml for crates.io crate sml-rs 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate sml-rs 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d00c8d309c3d2875c15f5ea72bd2e87d32bf0fd4ad21e20253a8ec8e5f3611b [INFO] running `Command { std: "docker" "start" "-a" "4d00c8d309c3d2875c15f5ea72bd2e87d32bf0fd4ad21e20253a8ec8e5f3611b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d00c8d309c3d2875c15f5ea72bd2e87d32bf0fd4ad21e20253a8ec8e5f3611b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d00c8d309c3d2875c15f5ea72bd2e87d32bf0fd4ad21e20253a8ec8e5f3611b", kill_on_drop: false }` [INFO] [stdout] 4d00c8d309c3d2875c15f5ea72bd2e87d32bf0fd4ad21e20253a8ec8e5f3611b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9f13aa994c32b818c9ee3b13bcbe12e64d1ace90bdc05c70072b1dcd7d9fabd [INFO] running `Command { std: "docker" "start" "-a" "a9f13aa994c32b818c9ee3b13bcbe12e64d1ace90bdc05c70072b1dcd7d9fabd", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking sml-rs v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:275:22 [INFO] [stdout] | [INFO] [stdout] 270 | pub fn from_reader(reader: R) -> SmlReader, DefaultBuffer> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | decoder: DecoderReader::new(util::IoReader::new(reader)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:22 [INFO] [stdout] | [INFO] [stdout] 337 | iter: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | decoder: DecoderReader::new(util::IterReader::new(iter.into_iter())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:514:22 [INFO] [stdout] | [INFO] [stdout] 512 | pub fn from_reader(self, reader: R) -> SmlReader, Buf> { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 513 | SmlReader { [INFO] [stdout] 514 | decoder: DecoderReader::new(util::IoReader::new(reader)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:582:22 [INFO] [stdout] | [INFO] [stdout] 576 | pub fn from_iterator(self, iter: I) -> SmlReader, Buf> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 582 | decoder: DecoderReader::new(util::IterReader::new(iter.into_iter())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:230:34 [INFO] [stdout] | [INFO] [stdout] 230 | val.map(|(input, x)| (input, f(x))) [INFO] [stdout] | ---------- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:265:18 [INFO] [stdout] | [INFO] [stdout] 263 | iter: impl IntoIterator>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | ) -> Encoder> { [INFO] [stdout] 265 | Encoder::new(iter.into_iter().map(|x| *x.borrow())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:653:22 [INFO] [stdout] | [INFO] [stdout] 651 | fn new(bytes: I) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 652 | DecodeIterator { [INFO] [stdout] 653 | decoder: Decoder::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:706:25 [INFO] [stdout] | [INFO] [stdout] 704 | iter: impl IntoIterator>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 705 | ) -> DecodeIterator> { [INFO] [stdout] 706 | DecodeIterator::new(iter.into_iter().map(|x| *x.borrow())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport/decoder_reader.rs:46:22 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn new(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | DecoderReader { [INFO] [stdout] 46 | decoder: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sml-rs` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a9f13aa994c32b818c9ee3b13bcbe12e64d1ace90bdc05c70072b1dcd7d9fabd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9f13aa994c32b818c9ee3b13bcbe12e64d1ace90bdc05c70072b1dcd7d9fabd", kill_on_drop: false }` [INFO] [stdout] a9f13aa994c32b818c9ee3b13bcbe12e64d1ace90bdc05c70072b1dcd7d9fabd