[INFO] fetching crate smithy_core 0.0.7... [INFO] checking smithy_core-0.0.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate smithy_core 0.0.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate smithy_core 0.0.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smithy_core 0.0.7 [INFO] finished tweaking crates.io crate smithy_core 0.0.7 [INFO] tweaked toml for crates.io crate smithy_core 0.0.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding js-sys v0.3.57 (latest: v0.3.70) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasm-bindgen v0.2.80 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-backend v0.2.80 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-futures v0.3.27 (latest: v0.4.43) [INFO] [stderr] Adding wasm-bindgen-macro v0.2.80 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-macro-support v0.2.80 (latest: v0.2.93) [INFO] [stderr] Adding wasm-bindgen-shared v0.2.80 (latest: v0.2.93) [INFO] [stderr] Adding web-sys v0.3.57 (latest: v0.3.70) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c0dd2f3bc3e2ca6cf8b621e2ca2f62ebea6ce78829e13efded6d3ac66fa80d4 [INFO] running `Command { std: "docker" "start" "-a" "1c0dd2f3bc3e2ca6cf8b621e2ca2f62ebea6ce78829e13efded6d3ac66fa80d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c0dd2f3bc3e2ca6cf8b621e2ca2f62ebea6ce78829e13efded6d3ac66fa80d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c0dd2f3bc3e2ca6cf8b621e2ca2f62ebea6ce78829e13efded6d3ac66fa80d4", kill_on_drop: false }` [INFO] [stdout] 1c0dd2f3bc3e2ca6cf8b621e2ca2f62ebea6ce78829e13efded6d3ac66fa80d4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9830ae9962c5003ea0867663af624e047ed4414add27e5a10271cd7ff89df1d [INFO] running `Command { std: "docker" "start" "-a" "d9830ae9962c5003ea0867663af624e047ed4414add27e5a10271cd7ff89df1d", kill_on_drop: false }` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.80 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.80 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking enum_derive v0.1.7 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.80 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.80 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.80 [INFO] [stderr] Checking js-sys v0.3.57 [INFO] [stderr] Checking wasm-bindgen-futures v0.3.27 [INFO] [stderr] Checking web-sys v0.3.57 [INFO] [stderr] Checking smithy_types v0.0.7 [INFO] [stderr] Checking smithy_core v0.0.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `smithy_types::UiEvent` [INFO] [stdout] --> src/attach_event_listeners.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use smithy_types::UiEvent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `JsCast` and `closure::Closure` [INFO] [stdout] --> src/attach_event_listeners.rs:6:3 [INFO] [stdout] | [INFO] [stdout] 6 | closure::Closure, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 7 | JsCast, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Event` and `HtmlElement` [INFO] [stdout] --> src/attach_event_listeners.rs:43:3 [INFO] [stdout] | [INFO] [stdout] 43 | Event, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 44 | HtmlElement, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `smithy_types::UiEvent` [INFO] [stdout] --> src/attach_event_listeners.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use smithy_types::UiEvent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `JsCast` and `closure::Closure` [INFO] [stdout] --> src/attach_event_listeners.rs:6:3 [INFO] [stdout] | [INFO] [stdout] 6 | closure::Closure, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 7 | JsCast, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Event` and `HtmlElement` [INFO] [stdout] --> src/attach_event_listeners.rs:43:3 [INFO] [stdout] | [INFO] [stdout] 43 | Event, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 44 | HtmlElement, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `html_el` [INFO] [stdout] --> src/attach_event_listeners.rs:102:34 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn attach_ui_event_listeners(html_el: &js_fns::HTMLElement) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_html_el` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `html_el` [INFO] [stdout] --> src/attach_event_listeners.rs:102:34 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn attach_ui_event_listeners(html_el: &js_fns::HTMLElement) { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_html_el` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_event_depth` is never used [INFO] [stdout] --> src/lib.rs:65:4 [INFO] [stdout] | [INFO] [stdout] 65 | fn get_event_depth() -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `event_handling_phase_is_ongoing` is never used [INFO] [stdout] --> src/lib.rs:69:4 [INFO] [stdout] | [INFO] [stdout] 69 | fn event_handling_phase_is_ongoing() -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `derive_path` is never used [INFO] [stdout] --> src/attach_event_listeners.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 47 | fn derive_path(s: String) -> Result, std::num::ParseIntError> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DATA_SMITHY_PATH` is never used [INFO] [stdout] --> src/attach_event_listeners.rs:51:7 [INFO] [stdout] | [INFO] [stdout] 51 | const DATA_SMITHY_PATH: &'static str = "data-smithy-path"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | EVENT_DEPTH.with(|depth| *depth.borrow()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/with_inner_value.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 14 | fn with_inner_value(&'static self, callback: impl FnOnce(&mut T) -> R) -> R { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | self.with(|rc| { [INFO] [stdout] | _______________^ [INFO] [stdout] 16 | | let val_opt = rc.replace(None); [INFO] [stdout] 17 | | // TODO don't unwrap here, but what to do instead? [INFO] [stdout] 18 | | let mut val = val_opt.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 21 | | new_val [INFO] [stdout] 22 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_diff.rs:57:3 [INFO] [stdout] | [INFO] [stdout] 54 | let doc = web_sys::window().unwrap().document().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let new_container_el = doc.create_element("div").unwrap(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | new_container_el.set_inner_html(s); [INFO] [stdout] 57 | new_container_el.first_child().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_diff.rs:220:3 [INFO] [stdout] | [INFO] [stdout] 207 | let zipped: Box, Option<&CollapsedNode>)>> = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | if potentially_deleting { [INFO] [stdout] 209 | let zipped = crate::zip_util::optionalize_and_zip(old_nodes.iter(), new_nodes.iter()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | / zipped [INFO] [stdout] 221 | | .enumerate() [INFO] [stdout] 222 | | .flat_map(|(i, (current, new))| { [INFO] [stdout] 223 | | let real_i = get_i(i, max_len, potentially_deleting); [INFO] [stdout] ... | [INFO] [stdout] 242 | | } [INFO] [stdout] 243 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_util.rs:6:3 [INFO] [stdout] | [INFO] [stdout] 4 | iter: impl Iterator, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 5 | ) -> impl Iterator> { [INFO] [stdout] 6 | iter.map(|item| Some(item)).chain(repeat_with(|| None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_util.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 10 | left_iter: impl ExactSizeIterator, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | right_iter: impl ExactSizeIterator, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let left_optionalized = optionalize_and_extend_with_none(left_iter); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let right_optionalized = optionalize_and_extend_with_none(right_iter); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | left_optionalized.zip(right_optionalized).take(max_len) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_event_depth` is never used [INFO] [stdout] --> src/lib.rs:65:4 [INFO] [stdout] | [INFO] [stdout] 65 | fn get_event_depth() -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `event_handling_phase_is_ongoing` is never used [INFO] [stdout] --> src/lib.rs:69:4 [INFO] [stdout] | [INFO] [stdout] 69 | fn event_handling_phase_is_ongoing() -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `derive_path` is never used [INFO] [stdout] --> src/attach_event_listeners.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 47 | fn derive_path(s: String) -> Result, std::num::ParseIntError> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DATA_SMITHY_PATH` is never used [INFO] [stdout] --> src/attach_event_listeners.rs:51:7 [INFO] [stdout] | [INFO] [stdout] 51 | const DATA_SMITHY_PATH: &'static str = "data-smithy-path"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | EVENT_DEPTH.with(|depth| *depth.borrow()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/with_inner_value.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 14 | fn with_inner_value(&'static self, callback: impl FnOnce(&mut T) -> R) -> R { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | self.with(|rc| { [INFO] [stdout] | _______________^ [INFO] [stdout] 16 | | let val_opt = rc.replace(None); [INFO] [stdout] 17 | | // TODO don't unwrap here, but what to do instead? [INFO] [stdout] 18 | | let mut val = val_opt.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 21 | | new_val [INFO] [stdout] 22 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_diff.rs:57:3 [INFO] [stdout] | [INFO] [stdout] 54 | let doc = web_sys::window().unwrap().document().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let new_container_el = doc.create_element("div").unwrap(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | new_container_el.set_inner_html(s); [INFO] [stdout] 57 | new_container_el.first_child().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node_diff.rs:220:3 [INFO] [stdout] | [INFO] [stdout] 207 | let zipped: Box, Option<&CollapsedNode>)>> = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | if potentially_deleting { [INFO] [stdout] 209 | let zipped = crate::zip_util::optionalize_and_zip(old_nodes.iter(), new_nodes.iter()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | / zipped [INFO] [stdout] 221 | | .enumerate() [INFO] [stdout] 222 | | .flat_map(|(i, (current, new))| { [INFO] [stdout] 223 | | let real_i = get_i(i, max_len, potentially_deleting); [INFO] [stdout] ... | [INFO] [stdout] 242 | | } [INFO] [stdout] 243 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_util.rs:6:3 [INFO] [stdout] | [INFO] [stdout] 4 | iter: impl Iterator, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 5 | ) -> impl Iterator> { [INFO] [stdout] 6 | iter.map(|item| Some(item)).chain(repeat_with(|| None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip_util.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 10 | left_iter: impl ExactSizeIterator, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | right_iter: impl ExactSizeIterator, [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | let left_optionalized = optionalize_and_extend_with_none(left_iter); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let right_optionalized = optionalize_and_extend_with_none(right_iter); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | left_optionalized.zip(right_optionalized).take(max_len) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smithy_core` (lib) due to 7 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `smithy_core` (lib test) due to 7 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d9830ae9962c5003ea0867663af624e047ed4414add27e5a10271cd7ff89df1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9830ae9962c5003ea0867663af624e047ed4414add27e5a10271cd7ff89df1d", kill_on_drop: false }` [INFO] [stdout] d9830ae9962c5003ea0867663af624e047ed4414add27e5a10271cd7ff89df1d