[INFO] fetching crate smarterr-macro 0.1.7... [INFO] checking smarterr-macro-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate smarterr-macro 0.1.7 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate smarterr-macro 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smarterr-macro 0.1.7 [INFO] finished tweaking crates.io crate smarterr-macro 0.1.7 [INFO] tweaked toml for crates.io crate smarterr-macro 0.1.7 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e961dcfa119c3deb4ce25c0db7a7fe1cdb697f6c939504c56a29477caf2c2c62 [INFO] running `Command { std: "docker" "start" "-a" "e961dcfa119c3deb4ce25c0db7a7fe1cdb697f6c939504c56a29477caf2c2c62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e961dcfa119c3deb4ce25c0db7a7fe1cdb697f6c939504c56a29477caf2c2c62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e961dcfa119c3deb4ce25c0db7a7fe1cdb697f6c939504c56a29477caf2c2c62", kill_on_drop: false }` [INFO] [stdout] e961dcfa119c3deb4ce25c0db7a7fe1cdb697f6c939504c56a29477caf2c2c62 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a02f317dd9bc69f6502bb480c16297b87bd1ada735542d6e3f4bbd54af6ae0ee [INFO] running `Command { std: "docker" "start" "-a" "a02f317dd9bc69f6502bb480c16297b87bd1ada735542d6e3f4bbd54af6ae0ee", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking smarterr-macro v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:418:12 [INFO] [stdout] | [INFO] [stdout] 417 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | Ok(FledgedError { [INFO] [stdout] | ____________^ [INFO] [stdout] 419 | | visibility: input.parse::().unwrap_or(Visibility::Inherited {}), [INFO] [stdout] 420 | | name: input.parse()?, [INFO] [stdout] 421 | | definition: { [INFO] [stdout] ... | [INFO] [stdout] 424 | | }, [INFO] [stdout] 425 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:432:12 [INFO] [stdout] | [INFO] [stdout] 431 | let t: Option> = input.parse_terminated(ErrorDef::parse, Token![,]).ok(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 432 | Ok(SmartErrors { errors: t }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:529:12 [INFO] [stdout] | [INFO] [stdout] 519 | let mut names = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | Ok(HandledError { names }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:810:34 [INFO] [stdout] | [INFO] [stdout] 810 | .retain(|attr| !(attr.path().segments.len() == 1 && attr.path().segments[0].ident == "smarterr")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:810:69 [INFO] [stdout] | [INFO] [stdout] 810 | .retain(|attr| !(attr.path().segments.len() == 1 && attr.path().segments[0].ident == "smarterr")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:879:48 [INFO] [stdout] | [INFO] [stdout] 874 | let rt = if let Some(mod_name) = &module { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 875 | syn::Type::Verbatim(quote! { std::result::Result<(), #mod_name::#err_enum> }) [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 876 | } else { [INFO] [stdout] 877 | syn::Type::Verbatim(quote! { std::result::Result<(), #err_enum> }) [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 878 | }; [INFO] [stdout] 879 | ReturnType::Type(RArrow { spans }, Box::::new(rt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:888:48 [INFO] [stdout] | [INFO] [stdout] 883 | let rt = if let Some(mod_name) = &module { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 884 | syn::Type::Verbatim(quote! { std::result::Result<#tt, #mod_name::#err_enum> }) [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 885 | } else { [INFO] [stdout] 886 | syn::Type::Verbatim(quote! { std::result::Result<#tt, #err_enum> }) [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 887 | }; [INFO] [stdout] 888 | ReturnType::Type(RArrow { spans }, Box::::new(rt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:418:12 [INFO] [stdout] | [INFO] [stdout] 417 | let content; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 418 | Ok(FledgedError { [INFO] [stdout] | ____________^ [INFO] [stdout] 419 | | visibility: input.parse::().unwrap_or(Visibility::Inherited {}), [INFO] [stdout] 420 | | name: input.parse()?, [INFO] [stdout] 421 | | definition: { [INFO] [stdout] ... | [INFO] [stdout] 424 | | }, [INFO] [stdout] 425 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:432:12 [INFO] [stdout] | [INFO] [stdout] 431 | let t: Option> = input.parse_terminated(ErrorDef::parse, Token![,]).ok(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 432 | Ok(SmartErrors { errors: t }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smarterr-macro` (lib) due to 8 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:529:12 [INFO] [stdout] | [INFO] [stdout] 519 | let mut names = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | Ok(HandledError { names }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:810:34 [INFO] [stdout] | [INFO] [stdout] 810 | .retain(|attr| !(attr.path().segments.len() == 1 && attr.path().segments[0].ident == "smarterr")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:810:69 [INFO] [stdout] | [INFO] [stdout] 810 | .retain(|attr| !(attr.path().segments.len() == 1 && attr.path().segments[0].ident == "smarterr")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:879:48 [INFO] [stdout] | [INFO] [stdout] 874 | let rt = if let Some(mod_name) = &module { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 875 | syn::Type::Verbatim(quote! { std::result::Result<(), #mod_name::#err_enum> }) [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 876 | } else { [INFO] [stdout] 877 | syn::Type::Verbatim(quote! { std::result::Result<(), #err_enum> }) [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 878 | }; [INFO] [stdout] 879 | ReturnType::Type(RArrow { spans }, Box::::new(rt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:888:48 [INFO] [stdout] | [INFO] [stdout] 883 | let rt = if let Some(mod_name) = &module { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 884 | syn::Type::Verbatim(quote! { std::result::Result<#tt, #mod_name::#err_enum> }) [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 885 | } else { [INFO] [stdout] 886 | syn::Type::Verbatim(quote! { std::result::Result<#tt, #err_enum> }) [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 887 | }; [INFO] [stdout] 888 | ReturnType::Type(RArrow { spans }, Box::::new(rt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smarterr-macro` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "a02f317dd9bc69f6502bb480c16297b87bd1ada735542d6e3f4bbd54af6ae0ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a02f317dd9bc69f6502bb480c16297b87bd1ada735542d6e3f4bbd54af6ae0ee", kill_on_drop: false }` [INFO] [stdout] a02f317dd9bc69f6502bb480c16297b87bd1ada735542d6e3f4bbd54af6ae0ee