[INFO] fetching crate smartcast 0.1.1... [INFO] checking smartcast-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate smartcast 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate smartcast 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smartcast 0.1.1 [INFO] finished tweaking crates.io crate smartcast 0.1.1 [INFO] tweaked toml for crates.io crate smartcast 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 203 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding env_logger v0.7.1 (latest: v0.11.5) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding headers v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding headers-core v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-tls v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding multer v2.1.0 (latest: v3.1.0) [INFO] [stderr] Adding pem v1.1.1 (latest: v3.0.4) [INFO] [stderr] Adding pretty_env_logger v0.4.0 (latest: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rcgen v0.8.14 (latest: v0.13.1) [INFO] [stderr] Adding reqwest v0.11.27 (latest: v0.12.7) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.22.4 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding serde-xml-rs v0.4.1 (latest: v0.6.0) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding tokio-rustls v0.25.0 (latest: v0.26.0) [INFO] [stderr] Adding tokio-tungstenite v0.21.0 (latest: v0.23.1) [INFO] [stderr] Adding tungstenite v0.21.0 (latest: v0.24.0) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] [stderr] Adding yasna v0.4.0 (latest: v0.5.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9db14957aeb2574e8cc15645b4283d8d47ebbf9f1e09dabb85234f6834fefc3d [INFO] running `Command { std: "docker" "start" "-a" "9db14957aeb2574e8cc15645b4283d8d47ebbf9f1e09dabb85234f6834fefc3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9db14957aeb2574e8cc15645b4283d8d47ebbf9f1e09dabb85234f6834fefc3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9db14957aeb2574e8cc15645b4283d8d47ebbf9f1e09dabb85234f6834fefc3d", kill_on_drop: false }` [INFO] [stdout] 9db14957aeb2574e8cc15645b4283d8d47ebbf9f1e09dabb85234f6834fefc3d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dcddc520cd35d8b99bfac2339faad442a6701ec4969d081b66f24f19b5e8667f [INFO] running `Command { std: "docker" "start" "-a" "dcddc520cd35d8b99bfac2339faad442a6701ec4969d081b66f24f19b5e8667f", kill_on_drop: false }` [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling multer v2.1.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking pem v1.1.1 [INFO] [stderr] Checking yasna v0.4.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking serde-xml-rs v0.4.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking rcgen v0.8.14 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking warp v0.3.7 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking smartcast v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/device/apps.rs:153:68 [INFO] [stdout] | [INFO] [stdout] 153 | self.apps = apps.iter_mut().fold(HashMap::new(), |mut map, mut app| { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `chipset` is never read [INFO] [stdout] --> src/device/info.rs:19:16 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct DeviceInfo { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub(super) chipset: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DeviceInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device/apps.rs:176:8 [INFO] [stdout] | [INFO] [stdout] 172 | fn null_string<'de, D>(deserializer: D) -> std::result::Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(String::deserialize(deserializer).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device/info.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 86 | fn parse_input_friendly<'de, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | serde_json::from_value::(value.clone()).or_else(|_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device/info.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | serde_json::from_value::(value.clone()).or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | serde_json::from_value::(value["NAME"].take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smartcast` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "dcddc520cd35d8b99bfac2339faad442a6701ec4969d081b66f24f19b5e8667f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcddc520cd35d8b99bfac2339faad442a6701ec4969d081b66f24f19b5e8667f", kill_on_drop: false }` [INFO] [stdout] dcddc520cd35d8b99bfac2339faad442a6701ec4969d081b66f24f19b5e8667f