[INFO] fetching crate sm-ext 0.3.0... [INFO] checking sm-ext-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sm-ext 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate sm-ext 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sm-ext 0.3.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate sm-ext 0.3.0 [INFO] tweaked toml for crates.io crate sm-ext 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate sm-ext 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 630b7437496cd8a325693bd808ba4a8e988a350c73fe41eea37b7b453f061451 [INFO] running `Command { std: "docker" "start" "-a" "630b7437496cd8a325693bd808ba4a8e988a350c73fe41eea37b7b453f061451", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "630b7437496cd8a325693bd808ba4a8e988a350c73fe41eea37b7b453f061451", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "630b7437496cd8a325693bd808ba4a8e988a350c73fe41eea37b7b453f061451", kill_on_drop: false }` [INFO] [stdout] 630b7437496cd8a325693bd808ba4a8e988a350c73fe41eea37b7b453f061451 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4503f2956a97f04356080a4f94fd4a207c10c31b48456b5a70d71cb677bfd8eb [INFO] running `Command { std: "docker" "start" "-a" "4503f2956a97f04356080a4f94fd4a207c10c31b48456b5a70d71cb677bfd8eb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-core v0.3.1 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Checking futures-io v0.3.1 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Checking futures-sink v0.3.1 [INFO] [stderr] Checking futures-task v0.3.1 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking c_str_macro v1.0.2 [INFO] [stderr] Checking futures-timer v2.0.2 [INFO] [stderr] Checking futures-channel v0.3.1 [INFO] [stderr] Checking pin-project-lite v0.1.2 [INFO] [stderr] Checking once_cell v1.3.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Checking kv-log-macro v1.0.4 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking async-task v1.2.1 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking crossbeam-channel v0.4.0 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking async-std v1.4.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling sm-ext-derive v0.3.0 [INFO] [stderr] Compiling futures-macro v0.3.1 [INFO] [stderr] Checking sm-ext v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking futures-util v0.3.1 [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/lib.rs:868:54 [INFO] [stdout] | [INFO] [stdout] 868 | pub struct IPluginFunction<'ctx>(IPluginFunctionPtr, &'ctx IPluginContext); [INFO] [stdout] | --------------- field in this struct ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `IPluginFunction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:265:60 [INFO] [stdout] | [INFO] [stdout] 242 | pub fn new(delegate: T) -> IExtensionInterfaceAdapter { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | IExtensionInterfaceAdapter { vtable: Box::into_raw(Box::new(vtable)), delegate } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:275:50 [INFO] [stdout] | [INFO] [stdout] 275 | let result = std::panic::catch_unwind(|| (*this.cast::()).delegate.on_extension_load(IExtension(me), IShareSys(sys), late)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:307:45 [INFO] [stdout] | [INFO] [stdout] 307 | let _ = std::panic::catch_unwind(|| (*this.cast::()).delegate.on_extension_unload()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:312:45 [INFO] [stdout] | [INFO] [stdout] 312 | let _ = std::panic::catch_unwind(|| (*this.cast::()).delegate.on_extensions_all_loaded()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:317:45 [INFO] [stdout] | [INFO] [stdout] 317 | let _ = std::panic::catch_unwind(|| (*this.cast::()).delegate.on_extension_pause_change(pause)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:322:50 [INFO] [stdout] | [INFO] [stdout] 322 | let result = std::panic::catch_unwind(|| (*this.cast::()).delegate.query_interface_drop(SMInterface(interface))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:332:45 [INFO] [stdout] | [INFO] [stdout] 332 | let _ = std::panic::catch_unwind(|| (*this.cast::()).delegate.notify_interface_drop(SMInterface(interface))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:337:56 [INFO] [stdout] | [INFO] [stdout] 337 | let result = std::panic::catch_unwind(|| match (*this.cast::()).delegate.query_running() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:396:45 [INFO] [stdout] | [INFO] [stdout] 396 | let _ = std::panic::catch_unwind(|| (*this.cast::()).delegate.on_core_map_start(edict_list, edict_count, client_max)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:401:45 [INFO] [stdout] | [INFO] [stdout] 401 | let _ = std::panic::catch_unwind(|| (*this.cast::()).delegate.on_dependencies_dropped()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:406:45 [INFO] [stdout] | [INFO] [stdout] 406 | let _ = std::panic::catch_unwind(|| (*this.cast::()).delegate.on_core_map_end()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1441:12 [INFO] [stdout] | [INFO] [stdout] 1436 | fn into_handle<'ty>(self) -> Result, HandleError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1441 | Ok(HandleRef { ty, handle, ptr }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sm-ext` (lib) due to 13 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4503f2956a97f04356080a4f94fd4a207c10c31b48456b5a70d71cb677bfd8eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4503f2956a97f04356080a4f94fd4a207c10c31b48456b5a70d71cb677bfd8eb", kill_on_drop: false }` [INFO] [stdout] 4503f2956a97f04356080a4f94fd4a207c10c31b48456b5a70d71cb677bfd8eb