[INFO] fetching crate sleigh2rust 0.1.6... [INFO] checking sleigh2rust-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sleigh2rust 0.1.6 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate sleigh2rust 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sleigh2rust 0.1.6 [INFO] finished tweaking crates.io crate sleigh2rust 0.1.6 [INFO] tweaked toml for crates.io crate sleigh2rust 0.1.6 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d222d618a9b4d88c9ac03941e70f12093bf5eb0b09e18815a03c12165714b6e9 [INFO] running `Command { std: "docker" "start" "-a" "d222d618a9b4d88c9ac03941e70f12093bf5eb0b09e18815a03c12165714b6e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d222d618a9b4d88c9ac03941e70f12093bf5eb0b09e18815a03c12165714b6e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d222d618a9b4d88c9ac03941e70f12093bf5eb0b09e18815a03c12165714b6e9", kill_on_drop: false }` [INFO] [stdout] d222d618a9b4d88c9ac03941e70f12093bf5eb0b09e18815a03c12165714b6e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 89ea2c21a0aa8f9a61554bc42286c2c1149f34ad929c622b7831fb4f2db3fefb [INFO] running `Command { std: "docker" "start" "-a" "89ea2c21a0aa8f9a61554bc42286c2c1149f34ad929c622b7831fb4f2db3fefb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking sleigh-rs v0.1.5 [INFO] [stderr] Checking sleigh2rust v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `SeparateTokens` is never constructed [INFO] [stdout] --> src/builder/formater.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct SeparateTokens<'a>(&'a str); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `disassembly_fun` is never read [INFO] [stdout] --> src/builder/disassembler/constructor/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct ConstructorStruct { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 27 | pub disassembly_fun: Ident, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `display_param` is never read [INFO] [stdout] --> src/builder/disassembler/constructor/disassembly.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct DisassemblyDisplay<'a> { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub display_param: &'a Ident, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `root_tables` and `root_token_fields` are never read [INFO] [stdout] --> src/builder/disassembler/constructor/disassembly.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 195 | pub struct DisassemblyPattern<'a> { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 200 | pub root_tables: &'a IndexMap, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 201 | pub root_token_fields: &'a IndexMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `varnode_bytes` is never read [INFO] [stdout] --> src/builder/meaning.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct VarMeaning { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub varnode_bytes: NonZeroTypeU, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VarMeaning` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 16 | file: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let sleigh = file_to_sleigh(file.as_ref())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok(Disassembler::new(sleigh, debug).into_token_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/disassembler/table.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 121 | let context_constraint = (context_mask != 0) [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | / context_constraint [INFO] [stdout] 130 | | .chain(pattern_constraint) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/disassembler/constructor/pattern.rs:737:45 [INFO] [stdout] | [INFO] [stdout] 733 | let table_name = format_ident!( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | (field_table.table, (field_table, table_name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/disassembly.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 55 | let mut work_stack: Vec<_> = Vec::with_capacity(2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | match work_stack.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/register.rs:64:35 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn from_printable(name: Ident, sleigh: &sleigh_rs::Sleigh) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let mut vars = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Self::from_iterator(name, vars.into_iter().map(|id| sleigh.varnode(id))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sleigh2rust` (lib test) due to 6 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `SeparateTokens` is never constructed [INFO] [stdout] --> src/builder/formater.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct SeparateTokens<'a>(&'a str); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `disassembly_fun` is never read [INFO] [stdout] --> src/builder/disassembler/constructor/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct ConstructorStruct { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 27 | pub disassembly_fun: Ident, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `display_param` is never read [INFO] [stdout] --> src/builder/disassembler/constructor/disassembly.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct DisassemblyDisplay<'a> { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub display_param: &'a Ident, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `root_tables` and `root_token_fields` are never read [INFO] [stdout] --> src/builder/disassembler/constructor/disassembly.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 195 | pub struct DisassemblyPattern<'a> { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 200 | pub root_tables: &'a IndexMap, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 201 | pub root_token_fields: &'a IndexMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `varnode_bytes` is never read [INFO] [stdout] --> src/builder/meaning.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct VarMeaning { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub varnode_bytes: NonZeroTypeU, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VarMeaning` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 16 | file: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | let sleigh = file_to_sleigh(file.as_ref())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok(Disassembler::new(sleigh, debug).into_token_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/disassembler/table.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 121 | let context_constraint = (context_mask != 0) [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | / context_constraint [INFO] [stdout] 130 | | .chain(pattern_constraint) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/disassembler/constructor/pattern.rs:737:45 [INFO] [stdout] | [INFO] [stdout] 733 | let table_name = format_ident!( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | (field_table.table, (field_table, table_name)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/disassembly.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 55 | let mut work_stack: Vec<_> = Vec::with_capacity(2); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | match work_stack.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder/register.rs:64:35 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn from_printable(name: Ident, sleigh: &sleigh_rs::Sleigh) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let mut vars = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | Self::from_iterator(name, vars.into_iter().map(|id| sleigh.varnode(id))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sleigh2rust` (lib) due to 6 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "89ea2c21a0aa8f9a61554bc42286c2c1149f34ad929c622b7831fb4f2db3fefb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89ea2c21a0aa8f9a61554bc42286c2c1149f34ad929c622b7831fb4f2db3fefb", kill_on_drop: false }` [INFO] [stdout] 89ea2c21a0aa8f9a61554bc42286c2c1149f34ad929c622b7831fb4f2db3fefb