[INFO] fetching crate slb 0.3.1... [INFO] checking slb-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate slb 0.3.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate slb 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate slb 0.3.1 [INFO] finished tweaking crates.io crate slb 0.3.1 [INFO] tweaked toml for crates.io crate slb 0.3.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate slb 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f80df46777e1abb008352a6ffac8a92fc5b4d2d1f33fde8f5bd2d669b251e725 [INFO] running `Command { std: "docker" "start" "-a" "f80df46777e1abb008352a6ffac8a92fc5b4d2d1f33fde8f5bd2d669b251e725", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f80df46777e1abb008352a6ffac8a92fc5b4d2d1f33fde8f5bd2d669b251e725", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f80df46777e1abb008352a6ffac8a92fc5b4d2d1f33fde8f5bd2d669b251e725", kill_on_drop: false }` [INFO] [stdout] f80df46777e1abb008352a6ffac8a92fc5b4d2d1f33fde8f5bd2d669b251e725 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9c744f8da7095adeaee482f09e1d8e31b05f639d65c68c98f8cacf16c4fd51d [INFO] running `Command { std: "docker" "start" "-a" "a9c744f8da7095adeaee482f09e1d8e31b05f639d65c68c98f8cacf16c4fd51d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling structopt-derive v0.4.15 [INFO] [stderr] Checking structopt v0.3.22 [INFO] [stderr] Checking slb v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:178:22 [INFO] [stdout] | [INFO] [stdout] 178 | .map(|child| child.stdout.take().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:192:27 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|output| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let txs_ref_clone = Arc::clone(&txs_ref); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let stats = Arc::clone(&stats); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 193 | | let output = BufReader::new(output); [INFO] [stdout] 194 | | let txs_ref_local = txs_ref_clone.deref(); [INFO] [stdout] 195 | | let mut lines_sent = vec![0usize; nthreads]; [INFO] [stdout] ... | [INFO] [stdout] 210 | | } [INFO] [stdout] 211 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 223 | let file = File::create(&path).expect("write file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | [INFO] [stdout] 225 | / Command::new("/bin/bash") [INFO] [stdout] 226 | | .arg("-c") [INFO] [stdout] 227 | | .arg(folder_cmd) [INFO] [stdout] 228 | | .stdin(Stdio::piped()) [INFO] [stdout] 229 | | .stdout(file) [INFO] [stdout] 230 | | .spawn() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:241:27 [INFO] [stdout] | [INFO] [stdout] 240 | .map(|(mut child, rx)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 242 | | let mut child_stdin = child.stdin.take().expect("child stdin"); [INFO] [stdout] 243 | | while let Ok(lines) = rx.recv() { [INFO] [stdout] 244 | | child_stdin.write_all(&lines).expect("write lines"); [INFO] [stdout] ... | [INFO] [stdout] 248 | | assert!(child.wait().expect("wait").success()); [INFO] [stdout] 249 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:258:28 [INFO] [stdout] | [INFO] [stdout] 258 | .for_each(|handle| handle.join().expect("map output join")); [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:266:28 [INFO] [stdout] | [INFO] [stdout] 266 | .for_each(|handle| handle.join().expect("fold join")); [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:178:22 [INFO] [stdout] | [INFO] [stdout] 178 | .map(|child| child.stdout.take().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:192:27 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|output| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let txs_ref_clone = Arc::clone(&txs_ref); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let stats = Arc::clone(&stats); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 193 | | let output = BufReader::new(output); [INFO] [stdout] 194 | | let txs_ref_local = txs_ref_clone.deref(); [INFO] [stdout] 195 | | let mut lines_sent = vec![0usize; nthreads]; [INFO] [stdout] ... | [INFO] [stdout] 210 | | } [INFO] [stdout] 211 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:225:13 [INFO] [stdout] | [INFO] [stdout] 223 | let file = File::create(&path).expect("write file"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | [INFO] [stdout] 225 | / Command::new("/bin/bash") [INFO] [stdout] 226 | | .arg("-c") [INFO] [stdout] 227 | | .arg(folder_cmd) [INFO] [stdout] 228 | | .stdin(Stdio::piped()) [INFO] [stdout] 229 | | .stdout(file) [INFO] [stdout] 230 | | .spawn() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:241:27 [INFO] [stdout] | [INFO] [stdout] 240 | .map(|(mut child, rx)| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | thread::spawn(move || { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 242 | | let mut child_stdin = child.stdin.take().expect("child stdin"); [INFO] [stdout] 243 | | while let Ok(lines) = rx.recv() { [INFO] [stdout] 244 | | child_stdin.write_all(&lines).expect("write lines"); [INFO] [stdout] ... | [INFO] [stdout] 248 | | assert!(child.wait().expect("wait").success()); [INFO] [stdout] 249 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:258:28 [INFO] [stdout] | [INFO] [stdout] 258 | .for_each(|handle| handle.join().expect("map output join")); [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:266:28 [INFO] [stdout] | [INFO] [stdout] 266 | .for_each(|handle| handle.join().expect("fold join")); [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `slb` (bin "slb" test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `slb` (bin "slb") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "a9c744f8da7095adeaee482f09e1d8e31b05f639d65c68c98f8cacf16c4fd51d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9c744f8da7095adeaee482f09e1d8e31b05f639d65c68c98f8cacf16c4fd51d", kill_on_drop: false }` [INFO] [stdout] a9c744f8da7095adeaee482f09e1d8e31b05f639d65c68c98f8cacf16c4fd51d